Re: [U-Boot] [PATCHv2 03/10] net: mvpp2x: Enable GoP packet padding in TX

[Joe Hershberger]

On Wed, Aug 9, 2017 at 2:37 AM,   wrote:
> From: Stefan Chulski 
>
> This patch enables padding of packets shorter than 64B in TX(set by default).
> Disabling of padding causes crashes on MACCIATO board.
>
> Signed-off-by: Stefan Chulski 
> Tested-by: iSoC Platform CI 
> Reviewed-by: Igal Liberman 

Acked-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCHv2 03/10] net: mvpp2x: Enable GoP packet padding in TX

[stefanc]

From: Stefan Chulski 

This patch enables padding of packets shorter than 64B in TX(set by default).
Disabling of padding causes crashes on MACCIATO board.

Signed-off-by: Stefan Chulski 
Tested-by: iSoC Platform CI 
Reviewed-by: Igal Liberman 
---
 drivers/net/mvpp2.c | 12 
 1 file changed, 12 deletions(-)

diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
index 1264f14..3083111 100644
--- a/drivers/net/mvpp2.c
+++ b/drivers/net/mvpp2.c
@@ -3063,10 +3063,6 @@ static void gop_gmac_sgmii2_5_cfg(struct mvpp2_port 
*port)
val |= MVPP2_GMAC_CTRL4_QSGMII_BYPASS_ACTIVE_MASK;
writel(val, port->base + MVPP2_GMAC_CTRL_4_REG);
 
-   val = readl(port->base + MVPP2_GMAC_CTRL_2_REG);
-   val |= MVPP2_GMAC_PORT_DIS_PADING_MASK;
-   writel(val, port->base + MVPP2_GMAC_CTRL_2_REG);
-
val = readl(port->base + MVPP2_GMAC_CTRL_0_REG);
/*
 * Configure GIG MAC to 1000Base-X mode connected to a fiber
@@ -3109,10 +3105,6 @@ static void gop_gmac_sgmii_cfg(struct mvpp2_port *port)
val |= MVPP2_GMAC_CTRL4_QSGMII_BYPASS_ACTIVE_MASK;
writel(val, port->base + MVPP2_GMAC_CTRL_4_REG);
 
-   val = readl(port->base + MVPP2_GMAC_CTRL_2_REG);
-   val |= MVPP2_GMAC_PORT_DIS_PADING_MASK;
-   writel(val, port->base + MVPP2_GMAC_CTRL_2_REG);
-
val = readl(port->base + MVPP2_GMAC_CTRL_0_REG);
/* configure GIG MAC to SGMII mode */
val &= ~MVPP2_GMAC_PORT_TYPE_MASK;
@@ -3151,10 +3143,6 @@ static void gop_gmac_rgmii_cfg(struct mvpp2_port *port)
val |= MVPP2_GMAC_CTRL4_EXT_PIN_GMII_SEL_MASK;
writel(val, port->base + MVPP2_GMAC_CTRL_4_REG);
 
-   val = readl(port->base + MVPP2_GMAC_CTRL_2_REG);
-   val &= ~MVPP2_GMAC_PORT_DIS_PADING_MASK;
-   writel(val, port->base + MVPP2_GMAC_CTRL_2_REG);
-
val = readl(port->base + MVPP2_GMAC_CTRL_0_REG);
/* configure GIG MAC to SGMII mode */
val &= ~MVPP2_GMAC_PORT_TYPE_MASK;
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot