Re: [U-Boot] [RFC 1/1] dm: video: tegra124: incorrect logical condition

On 03/06/2018 11:08 AM, Anatolij Gustschin wrote: > Hi all, > > On Wed, 31 Jan 2018 01:16:07 +0100 > Heinrich Schuchardt xypron.g...@gmx.de wrote: > >> 2 << 24 | A is always true. To use check against a bitmask we need &. > > it is always true, but here we are not checking against a bitmask, so

Re: [U-Boot] [RFC 1/1] dm: video: tegra124: incorrect logical condition

Hi all, On Wed, 31 Jan 2018 01:16:07 +0100 Heinrich Schuchardt xypron.g...@gmx.de wrote: > 2 << 24 | A is always true. To use check against a bitmask we need &. it is always true, but here we are not checking against a bitmask, so the patch is wrong. We set or clear register bit (depending on

[U-Boot] [RFC 1/1] dm: video: tegra124: incorrect logical condition

2 << 24 | A is always true. To use check against a bitmask we need &. Identified with cppcheck. Signed-off-by: Heinrich Schuchardt --- I do not have the hardware available. But the current coding is fishy. Please, clarify what should be coded here. ---