Re: [U-Boot] [UBOOT PATCH] spi: zynq_qspi: Fixed incorrect return value error

[Jagan Teki]

On Thu, Jun 14, 2018 at 12:30 PM, Michal Simek  wrote:
> On 14.6.2018 08:46, Vipul Kumar wrote:
>> This patch replaced "return 0" with "return status" to fix the
>> incorrect return value error reported by the coverity.
>>
>> Signed-off-by: Vipul Kumar 
>> ---
>>  drivers/spi/zynq_qspi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c
>> index ee8796d..9ad1927 100644
>> --- a/drivers/spi/zynq_qspi.c
>> +++ b/drivers/spi/zynq_qspi.c
>> @@ -486,7 +486,7 @@ static int zynq_qspi_transfer(struct zynq_qspi_priv 
>> *priv)
>>   break;
>>   }
>>
>> - return 0;
>> + return status;
>>  }
>>
>>  static int zynq_qspi_claim_bus(struct udevice *dev)
>>
>
> Reviewed-by: Michal Simek 

Applied to u-boot-spi/master
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [UBOOT PATCH] spi: zynq_qspi: Fixed incorrect return value error

[Michal Simek]

On 14.6.2018 08:46, Vipul Kumar wrote:
> This patch replaced "return 0" with "return status" to fix the
> incorrect return value error reported by the coverity.
> 
> Signed-off-by: Vipul Kumar 
> ---
>  drivers/spi/zynq_qspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c
> index ee8796d..9ad1927 100644
> --- a/drivers/spi/zynq_qspi.c
> +++ b/drivers/spi/zynq_qspi.c
> @@ -486,7 +486,7 @@ static int zynq_qspi_transfer(struct zynq_qspi_priv *priv)
>   break;
>   }
>  
> - return 0;
> + return status;
>  }
>  
>  static int zynq_qspi_claim_bus(struct udevice *dev)
> 

Reviewed-by: Michal Simek 

Thanks,
Michal
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [UBOOT PATCH] spi: zynq_qspi: Fixed incorrect return value error

[Vipul Kumar]

This patch replaced "return 0" with "return status" to fix the
incorrect return value error reported by the coverity.

Signed-off-by: Vipul Kumar 
---
 drivers/spi/zynq_qspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c
index ee8796d..9ad1927 100644
--- a/drivers/spi/zynq_qspi.c
+++ b/drivers/spi/zynq_qspi.c
@@ -486,7 +486,7 @@ static int zynq_qspi_transfer(struct zynq_qspi_priv *priv)
break;
}

-   return 0;
+   return status;
 }

 static int zynq_qspi_claim_bus(struct udevice *dev)
--
2.7.4

This email and any attachments are intended for the sole use of the named 
recipient(s) and contain(s) confidential information that may be proprietary, 
privileged or copyrighted under applicable law. If you are not the intended 
recipient, do not read, copy, or forward this email message or any attachments. 
Delete this email message and any attachments immediately.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot