Re: [PATCH] arm: mvebu: Clean up Thecus N2350 board DTS
On 6/6/23 23:45, Tony Dinh wrote:
- Update the Thecus N2350 DTS to conform with latest device-tree binding
and styles.
- Correct typo in mdio node.
Signed-off-by: Tony Dinh
Applied to u-boot-marvell/master
Thanks,
Stefan
---
arch/arm/dts/armada-385-thecus-n2350.dts | 210 +++
1 file changed, 98 insertions(+), 112 deletions(-)
diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts
b/arch/arm/dts/armada-385-thecus-n2350.dts
index fc29c4d25a..2ad5158c0c 100644
--- a/arch/arm/dts/armada-385-thecus-n2350.dts
+++ b/arch/arm/dts/armada-385-thecus-n2350.dts
@@ -23,7 +23,7 @@
stdout-path = "serial0:115200n8";
};
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x 0x4000>; /* 1GB */
};
@@ -37,43 +37,43 @@
};
- usb3_0_phy: usb3_0_phy {
+ usb3_0_phy: usb-phy {
compatible = "usb-nop-xceiv";
vcc-supply = <_0_power>;
+#phy-cells = <0>;
};
- usb3_1_phy: usb3_1_phy {
+ usb3_1_phy: usb-phy {
compatible = "usb-nop-xceiv";
vcc-supply = <_1_power>;
+#phy-cells = <0>;
};
- gpio-keys {
+ keys {
compatible = "gpio-keys";
- #address-cells = <1>;
- #size-cells = <0>;
pinctrl-0 = <_power_button _copy_button
_reset_button>;
pinctrl-names = "default";
- button@1 {
+ button-1 {
label = "Power Button";
linux,code = ;
gpios = < 17 GPIO_ACTIVE_HIGH>;
};
- button@2 {
+ button-2 {
label = "Copy Button";
linux,code = ;
gpios = < 20 GPIO_ACTIVE_HIGH>;
};
- button@3 {
+ button-3 {
label = "Reset Button";
linux,code = ;
gpios = < 18 GPIO_ACTIVE_HIGH>;
};
};
- gpio-leds {
+ leds {
compatible = "gpio-leds";
pinctrl-0 = <_sata1_white_led
_sata1_red_led
@@ -88,142 +88,132 @@
pinctrl-names = "default";
- white_sata1 {
+ led-1 {
label = "n2350:white:sata1";
gpios = < 20 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "ide-disk1";
};
- red_sata1 {
+ led-2 {
label = "n2350:red:sata1";
gpios = < 14 GPIO_ACTIVE_HIGH>;
};
- white-sata2 {
+ led-3 {
label = "n2350:white:sata2";
gpios = < 19 GPIO_ACTIVE_HIGH>;
};
- red-sata2 {
+ led-4 {
label = "n2350:red:sata2";
gpios = < 15 GPIO_ACTIVE_HIGH>;
};
- white-sys {
+ led-5 {
label = "n2350:white:sys";
gpios = < 14 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "default-on";
};
- red-sys {
+ led-6 {
label = "n2350:red:sys";
gpios = < 15 GPIO_ACTIVE_HIGH>;
};
- blue-pwr {
+ led-7 {
label = "n2350:blue:pwr";
gpios = < 11 GPIO_ACTIVE_HIGH>;
};
- red-pwr {
+ led-8 {
label = "n2350:red:pwr";
gpios = < 18 GPIO_ACTIVE_HIGH>;
};
- white-usb {
+ led-9 {
label = "n2350:white:usb";
gpios = < 16 GPIO_ACTIVE_HIGH>;
};
- red-usb {
+ led-10 {
label = "n2350:red:usb";
gpios = < 17 GPIO_ACTIVE_HIGH>;
};
};
- regulators {
- compatible = "simple-bus";
- #address-cells = <1>;
- #size-cells = <0>;
-
- usb3_0_power: regulator@1 {
- compatible = "regulator-fixed";
- reg = <1>;
- regulator-name = "USB3_0_Power";
- regulator-min-microvolt = <500>;
- regulator-max-microvolt = <500>;
- enable-active-high;
- regulator-always-on;
- regulator-boot-on;
- gpio = < 21 GPIO_ACTIVE_HIGH>;
- };
-
- usb3_1_power: regulator@2 {
- compatible = "regulator-fixed";
- reg = <1>;
- regulator-name
Re: [PATCH] arm: mvebu: Clean up Thecus N2350 board DTS
On Tuesday 06 June 2023 14:45:39 Tony Dinh wrote:
> - Update the Thecus N2350 DTS to conform with latest device-tree binding
> and styles.
> - Correct typo in mdio node.
>
> Signed-off-by: Tony Dinh
Reviewed-by: Pali Rohár
> ---
>
> arch/arm/dts/armada-385-thecus-n2350.dts | 210 +++
> 1 file changed, 98 insertions(+), 112 deletions(-)
>
> diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts
> b/arch/arm/dts/armada-385-thecus-n2350.dts
> index fc29c4d25a..2ad5158c0c 100644
> --- a/arch/arm/dts/armada-385-thecus-n2350.dts
> +++ b/arch/arm/dts/armada-385-thecus-n2350.dts
> @@ -23,7 +23,7 @@
> stdout-path = "serial0:115200n8";
> };
>
> - memory {
> + memory@0 {
> device_type = "memory";
> reg = <0x 0x4000>; /* 1GB */
> };
> @@ -37,43 +37,43 @@
>
> };
>
> - usb3_0_phy: usb3_0_phy {
> + usb3_0_phy: usb-phy {
> compatible = "usb-nop-xceiv";
> vcc-supply = <_0_power>;
> + #phy-cells = <0>;
> };
>
> - usb3_1_phy: usb3_1_phy {
> + usb3_1_phy: usb-phy {
> compatible = "usb-nop-xceiv";
> vcc-supply = <_1_power>;
> + #phy-cells = <0>;
> };
>
> - gpio-keys {
> + keys {
> compatible = "gpio-keys";
> - #address-cells = <1>;
> - #size-cells = <0>;
> pinctrl-0 = <_power_button _copy_button
> _reset_button>;
> pinctrl-names = "default";
>
> - button@1 {
> + button-1 {
> label = "Power Button";
> linux,code = ;
> gpios = < 17 GPIO_ACTIVE_HIGH>;
> };
>
> - button@2 {
> + button-2 {
> label = "Copy Button";
> linux,code = ;
> gpios = < 20 GPIO_ACTIVE_HIGH>;
> };
>
> - button@3 {
> + button-3 {
> label = "Reset Button";
> linux,code = ;
> gpios = < 18 GPIO_ACTIVE_HIGH>;
> };
> };
>
> - gpio-leds {
> + leds {
> compatible = "gpio-leds";
> pinctrl-0 = <_sata1_white_led
> _sata1_red_led
> @@ -88,142 +88,132 @@
>
> pinctrl-names = "default";
>
> - white_sata1 {
> + led-1 {
> label = "n2350:white:sata1";
> gpios = < 20 GPIO_ACTIVE_HIGH>;
> - linux,default-trigger = "ide-disk1";
> };
>
> - red_sata1 {
> + led-2 {
> label = "n2350:red:sata1";
> gpios = < 14 GPIO_ACTIVE_HIGH>;
> };
>
> - white-sata2 {
> + led-3 {
> label = "n2350:white:sata2";
> gpios = < 19 GPIO_ACTIVE_HIGH>;
> };
>
> - red-sata2 {
> + led-4 {
> label = "n2350:red:sata2";
> gpios = < 15 GPIO_ACTIVE_HIGH>;
> };
>
> - white-sys {
> + led-5 {
> label = "n2350:white:sys";
> gpios = < 14 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "default-on";
> };
>
> - red-sys {
> + led-6 {
> label = "n2350:red:sys";
> gpios = < 15 GPIO_ACTIVE_HIGH>;
> };
>
> - blue-pwr {
> + led-7 {
> label = "n2350:blue:pwr";
> gpios = < 11 GPIO_ACTIVE_HIGH>;
> };
>
> - red-pwr {
> + led-8 {
> label = "n2350:red:pwr";
> gpios = < 18 GPIO_ACTIVE_HIGH>;
> };
>
> - white-usb {
> + led-9 {
> label = "n2350:white:usb";
> gpios = < 16 GPIO_ACTIVE_HIGH>;
> };
>
> - red-usb {
> + led-10 {
> label = "n2350:red:usb";
> gpios = < 17 GPIO_ACTIVE_HIGH>;
> };
> };
>
> - regulators {
> - compatible = "simple-bus";
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - usb3_0_power: regulator@1 {
> - compatible = "regulator-fixed";
> - reg = <1>;
> - regulator-name = "USB3_0_Power";
> - regulator-min-microvolt = <500>;
> - regulator-max-microvolt = <500>;
> - enable-active-high;
> - regulator-always-on;
> - regulator-boot-on;
Re: [PATCH] arm: mvebu: Clean up Thecus N2350 board DTS
On 6/6/23 23:45, Tony Dinh wrote:
- Update the Thecus N2350 DTS to conform with latest device-tree binding
and styles.
- Correct typo in mdio node.
Signed-off-by: Tony Dinh
Reviewed-by: Stefan Roese
Thanks,
Stefan
---
arch/arm/dts/armada-385-thecus-n2350.dts | 210 +++
1 file changed, 98 insertions(+), 112 deletions(-)
diff --git a/arch/arm/dts/armada-385-thecus-n2350.dts
b/arch/arm/dts/armada-385-thecus-n2350.dts
index fc29c4d25a..2ad5158c0c 100644
--- a/arch/arm/dts/armada-385-thecus-n2350.dts
+++ b/arch/arm/dts/armada-385-thecus-n2350.dts
@@ -23,7 +23,7 @@
stdout-path = "serial0:115200n8";
};
- memory {
+ memory@0 {
device_type = "memory";
reg = <0x 0x4000>; /* 1GB */
};
@@ -37,43 +37,43 @@
};
- usb3_0_phy: usb3_0_phy {
+ usb3_0_phy: usb-phy {
compatible = "usb-nop-xceiv";
vcc-supply = <_0_power>;
+#phy-cells = <0>;
};
- usb3_1_phy: usb3_1_phy {
+ usb3_1_phy: usb-phy {
compatible = "usb-nop-xceiv";
vcc-supply = <_1_power>;
+#phy-cells = <0>;
};
- gpio-keys {
+ keys {
compatible = "gpio-keys";
- #address-cells = <1>;
- #size-cells = <0>;
pinctrl-0 = <_power_button _copy_button
_reset_button>;
pinctrl-names = "default";
- button@1 {
+ button-1 {
label = "Power Button";
linux,code = ;
gpios = < 17 GPIO_ACTIVE_HIGH>;
};
- button@2 {
+ button-2 {
label = "Copy Button";
linux,code = ;
gpios = < 20 GPIO_ACTIVE_HIGH>;
};
- button@3 {
+ button-3 {
label = "Reset Button";
linux,code = ;
gpios = < 18 GPIO_ACTIVE_HIGH>;
};
};
- gpio-leds {
+ leds {
compatible = "gpio-leds";
pinctrl-0 = <_sata1_white_led
_sata1_red_led
@@ -88,142 +88,132 @@
pinctrl-names = "default";
- white_sata1 {
+ led-1 {
label = "n2350:white:sata1";
gpios = < 20 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "ide-disk1";
};
- red_sata1 {
+ led-2 {
label = "n2350:red:sata1";
gpios = < 14 GPIO_ACTIVE_HIGH>;
};
- white-sata2 {
+ led-3 {
label = "n2350:white:sata2";
gpios = < 19 GPIO_ACTIVE_HIGH>;
};
- red-sata2 {
+ led-4 {
label = "n2350:red:sata2";
gpios = < 15 GPIO_ACTIVE_HIGH>;
};
- white-sys {
+ led-5 {
label = "n2350:white:sys";
gpios = < 14 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "default-on";
};
- red-sys {
+ led-6 {
label = "n2350:red:sys";
gpios = < 15 GPIO_ACTIVE_HIGH>;
};
- blue-pwr {
+ led-7 {
label = "n2350:blue:pwr";
gpios = < 11 GPIO_ACTIVE_HIGH>;
};
- red-pwr {
+ led-8 {
label = "n2350:red:pwr";
gpios = < 18 GPIO_ACTIVE_HIGH>;
};
- white-usb {
+ led-9 {
label = "n2350:white:usb";
gpios = < 16 GPIO_ACTIVE_HIGH>;
};
- red-usb {
+ led-10 {
label = "n2350:red:usb";
gpios = < 17 GPIO_ACTIVE_HIGH>;
};
};
- regulators {
- compatible = "simple-bus";
- #address-cells = <1>;
- #size-cells = <0>;
-
- usb3_0_power: regulator@1 {
- compatible = "regulator-fixed";
- reg = <1>;
- regulator-name = "USB3_0_Power";
- regulator-min-microvolt = <500>;
- regulator-max-microvolt = <500>;
- enable-active-high;
- regulator-always-on;
- regulator-boot-on;
- gpio = < 21 GPIO_ACTIVE_HIGH>;
- };
-
- usb3_1_power: regulator@2 {
- compatible = "regulator-fixed";
- reg = <1>;
- regulator-name =
