Re: [PATCH] doc: rockchip: Update documentation with Rock Pi 4
Hi Tom, On 19/5/20 18:02, Tom Rini wrote: On Tue, May 19, 2020 at 05:29:31PM -0300, Walter Lozano wrote: Hi Jagan On 19/5/20 15:57, Jagan Teki wrote: On Wed, May 20, 2020 at 12:15 AM Walter Lozano wrote: Update README.rockchip to reflect the support of Radxa Rock Pi 4 Signed-off-by: Walter Lozano --- doc/README.rockchip | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) We have doc/board/rockchip please update there. Documentation in doc/board/rockchip already states the support for Radxa Rock Pi 4. Unfortunately having two different documentation which overlaps tends to be redundancy prone. At this point I think that the best approach it to spawn two tasks 1- Update the doc/README.rockchip with any specific information which needs to be updated 2- Continue to move doc/README.rockchip to doc/board/rockchip as you started to do I might find some time to work in task 2, but in the meantime I think this patch goes in the direction of task 1 Do you agree? I'd like to see doc/README.rockchip go away in favour of doc/board/rockchip/ as soon as possible, especially since this is an area with active development. I'd rather see an update to doc/README.rockchip saying that doc/board/rockchip/rockchip.rst has the list of supported hardware as the step forward here. Thanks! OK, it makes sense. I'll prepare such patch and send it. Regards, Walter
Re: [PATCH] doc: rockchip: Update documentation with Rock Pi 4
On Tue, May 19, 2020 at 05:29:31PM -0300, Walter Lozano wrote: > Hi Jagan > > On 19/5/20 15:57, Jagan Teki wrote: > > On Wed, May 20, 2020 at 12:15 AM Walter Lozano > > wrote: > > > Update README.rockchip to reflect the support of Radxa Rock Pi 4 > > > > > > Signed-off-by: Walter Lozano > > > --- > > > doc/README.rockchip | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > We have doc/board/rockchip please update there. > > Documentation in doc/board/rockchip already states the support for Radxa > Rock Pi 4. Unfortunately having two different documentation which overlaps > tends to be redundancy prone. > > > At this point I think that the best approach it to spawn two tasks > > 1- Update the doc/README.rockchip with any specific information which needs > to be updated > > 2- Continue to move doc/README.rockchip to doc/board/rockchip as you started > to do > > > I might find some time to work in task 2, but in the meantime I think this > patch goes in the direction of task 1 > > > Do you agree? I'd like to see doc/README.rockchip go away in favour of doc/board/rockchip/ as soon as possible, especially since this is an area with active development. I'd rather see an update to doc/README.rockchip saying that doc/board/rockchip/rockchip.rst has the list of supported hardware as the step forward here. Thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH] doc: rockchip: Update documentation with Rock Pi 4
Hi Jagan On 19/5/20 15:57, Jagan Teki wrote: On Wed, May 20, 2020 at 12:15 AM Walter Lozano wrote: Update README.rockchip to reflect the support of Radxa Rock Pi 4 Signed-off-by: Walter Lozano --- doc/README.rockchip | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) We have doc/board/rockchip please update there. Documentation in doc/board/rockchip already states the support for Radxa Rock Pi 4. Unfortunately having two different documentation which overlaps tends to be redundancy prone. At this point I think that the best approach it to spawn two tasks 1- Update the doc/README.rockchip with any specific information which needs to be updated 2- Continue to move doc/README.rockchip to doc/board/rockchip as you started to do I might find some time to work in task 2, but in the meantime I think this patch goes in the direction of task 1 Do you agree? Regards, Walter
Re: [PATCH] doc: rockchip: Update documentation with Rock Pi 4
On Wed, May 20, 2020 at 12:15 AM Walter Lozano wrote: > > Update README.rockchip to reflect the support of Radxa Rock Pi 4 > > Signed-off-by: Walter Lozano > --- > doc/README.rockchip | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) We have doc/board/rockchip please update there. Jagan.
