Re: [PATCH 1/1] cmd: blkls: Add blkls command

2020-03-26 Thread Simon Glass
Hi Niel, On Wed, 25 Mar 2020 at 07:46, Niel Fourie wrote: > > Add a command to print a list of available block device drivers, > and for each, the list of known block devices. > > Signed-off-by: Niel Fourie > --- > cmd/Kconfig | 8 > cmd/Makefile| 1 + > c

Re: [PATCH 1/1] cmd: blkls: Add blkls command

2020-03-25 Thread Niel Fourie
Hi Stefan, On 3/25/20 3:13 PM, Stefan Roese wrote: +config CMD_LSBLK +    depends on HAVE_BLOCK_DEVICE You depend on CONFIG_HAVE_BLOCK_DEVICE here... + +#if CONFIG_IS_ENABLED(HAVE_BLOCK_DEVICE) ... so this #ifdef should not be necessary, right? Oops, you are right... I forgot to take out

Re: [PATCH 1/1] cmd: blkls: Add blkls command

2020-03-25 Thread Stefan Roese
Hi Niel, On 25.03.20 14:46, Niel Fourie wrote: Add a command to print a list of available block device drivers, and for each, the list of known block devices. Signed-off-by: Niel Fourie --- cmd/Kconfig | 8 cmd/Makefile| 1 + cmd/lsblk.c