Re: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-23 Thread Alper Nebi Yasak
On 23/05/2022 17:10, Tom Rini wrote: > On Mon, May 23, 2022 at 06:28:44AM +, Peng Fan (OSS) wrote: >>> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 >>> >>> Why are you mentioning LTO in the commit message? When I read the >>> comm

Re: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-23 Thread Alper Nebi Yasak
On 22/05/2022 17:50, Tom Rini wrote: > On Sun, May 22, 2022 at 04:56:08PM +0300, Alper Nebi Yasak wrote: >> It looks like we should be able to change things in common/spl/spl.c to: >> >> #if CONFIG_IS_ENABLED(BINMAN_SYMBOLS) >> /* See spl.h for information about this */ >>

Re: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-23 Thread Tom Rini
On Mon, May 23, 2022 at 06:28:44AM +, Peng Fan (OSS) wrote: > > Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > > > > On Sat, May 21, 2022 at 08:33:56AM +, Peng Fan wrote: > > > > Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > &

RE: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-23 Thread Peng Fan (OSS)
> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > > On Sat, May 21, 2022 at 08:33:56AM +, Peng Fan wrote: > > > Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > > > > > > On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS)

RE: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-23 Thread Peng Fan (OSS)
> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > > On 21/05/2022 15:05, Tom Rini wrote: > > On Sat, May 21, 2022 at 08:33:56AM +, Peng Fan wrote: > >>> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > >>> > >>> On F

Re: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-22 Thread Tom Rini
On Sun, May 22, 2022 at 04:56:08PM +0300, Alper Nebi Yasak wrote: > On 21/05/2022 15:05, Tom Rini wrote: > > On Sat, May 21, 2022 at 08:33:56AM +, Peng Fan wrote: > >>> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > >>> > >>> On Fr

Re: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-22 Thread Alper Nebi Yasak
On 21/05/2022 15:05, Tom Rini wrote: > On Sat, May 21, 2022 at 08:33:56AM +, Peng Fan wrote: >>> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 >>> >>> On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS) wrote: >>> >>>> From:

Re: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-22 Thread Alper Nebi Yasak
On 20/05/2022 17:10, Peng Fan (OSS) wrote: > From: Peng Fan > > set the symbol as weak not work if LTO is enabled. Since u_boot_any is > only used on X86 for now, so guard it with X86, otherwise build break > if we use BINMAN_SYMBOLS on i.MX. > > Tested-by: Tim Harvey #imx8m[m,n,p]-venice >

Re: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-21 Thread Tom Rini
On Sat, May 21, 2022 at 08:33:56AM +, Peng Fan wrote: > > Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > > > > On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS) wrote: > > > > > From: Peng Fan > > > > > > set t

RE: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-21 Thread Peng Fan
> Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > > On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > set the symbol as weak not work if LTO is enabled. Since u_boot_any is > > only used on X86 for

Re: [PATCH V4 1/8] spl: guard u_boot_any with X86

2022-05-20 Thread Tom Rini
On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > set the symbol as weak not work if LTO is enabled. Since u_boot_any is > only used on X86 for now, so guard it with X86, otherwise build break > if we use BINMAN_SYMBOLS on i.MX. > > Tested-by: Tim Harvey