RE: [PATCH u-boot 1/2] eth/r8152: fix assigning the wrong endpoint

2020-05-25 Thread Hayes Wang
Marek Vasut [mailto:ma...@denx.de] > Sent: Friday, May 22, 2020 9:22 PM [...] > > - if ((ep_addr & USB_DIR_IN) && !ep_in_found) { > > - ss->ep_in = ep_addr & > > - USB_ENDPOINT_NUMBER_MASK; > > -

Re: [PATCH u-boot 1/2] eth/r8152: fix assigning the wrong endpoint

2020-05-22 Thread Marek Vasut
On 5/22/20 10:54 AM, Hayes Wang wrote: > Although I think it never occurs, the code doesn't make sense, because > it may allow to assign an IN endpoint to ss->ep_out. > > Signed-off-by: Hayes Wang > --- > drivers/usb/eth/r8152.c | 14 -- > 1 file changed, 8 insertions(+), 6