Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards

2021-10-22 Thread Francesco Dolcini
Hello Stefano,

On Thu, Oct 21, 2021 at 01:08:16PM +0200, Francesco Dolcini wrote:
> On Thu, Oct 21, 2021 at 12:16:33PM +0200, Stefano Babic wrote:
> > On 01.09.21 09:48, Francesco Dolcini wrote:
> > > 
> > > Use the complete 512kb (4 blocks) nand partition reserved for u-boot
> > > environment instead of just the first block, this allows the module
> > > to have a working environment even if 3 blocks are bad.
> > > 
> > > 
> > > Francesco Dolcini (2):
> > >colibri-imx6ull: improve env badblock management
> > >colibri-imx7: improve env badblock management
> > > 
> > >   include/configs/colibri-imx6ull.h | 5 +
> > >   include/configs/colibri_imx7.h| 5 +
> > >   2 files changed, 10 insertions(+)
> > > 
> > 
> > Sure, but is it not time to move CONFIG_ENV_RANGE into Kconfig (and drop it
> > from whitelist= ?
> 
> I'll try to have a look at it later tonight, I cannot warrant anything at the
> moment.

So, I gave it a try, but it is not trivial (CONFIG_ENV_RANGE is using most of
the time other CONFIG options that are not in kconfig yet) :-/

At the moment I have no much time to invest on this topic, I hope it would be 
fine
to merge these 2 patches as they are.

Francesco


Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards

2021-10-22 Thread Stefano Babic

Hi Francesco,

On 22.10.21 09:59, Francesco Dolcini wrote:

Hello Stefano,

On Thu, Oct 21, 2021 at 01:08:16PM +0200, Francesco Dolcini wrote:

On Thu, Oct 21, 2021 at 12:16:33PM +0200, Stefano Babic wrote:

On 01.09.21 09:48, Francesco Dolcini wrote:


Use the complete 512kb (4 blocks) nand partition reserved for u-boot
environment instead of just the first block, this allows the module
to have a working environment even if 3 blocks are bad.


Francesco Dolcini (2):
colibri-imx6ull: improve env badblock management
colibri-imx7: improve env badblock management

   include/configs/colibri-imx6ull.h | 5 +
   include/configs/colibri_imx7.h| 5 +
   2 files changed, 10 insertions(+)



Sure, but is it not time to move CONFIG_ENV_RANGE into Kconfig (and drop it
from whitelist= ?


I'll try to have a look at it later tonight, I cannot warrant anything at the
moment.


So, I gave it a try, but it is not trivial (CONFIG_ENV_RANGE is using most of
the time other CONFIG options that are not in kconfig yet) :-/

At the moment I have no much time to invest on this topic, I hope it would be 
fine
to merge these 2 patches as they are.


Ok, I will merge your patches into u-boot-imx.

Best regards,
Stefano


--
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=


Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards

2021-10-21 Thread Francesco Dolcini
Hello Stefano,

On Thu, Oct 21, 2021 at 12:16:33PM +0200, Stefano Babic wrote:
> On 01.09.21 09:48, Francesco Dolcini wrote:
> > 
> > Use the complete 512kb (4 blocks) nand partition reserved for u-boot
> > environment instead of just the first block, this allows the module
> > to have a working environment even if 3 blocks are bad.
> > 
> > 
> > Francesco Dolcini (2):
> >colibri-imx6ull: improve env badblock management
> >colibri-imx7: improve env badblock management
> > 
> >   include/configs/colibri-imx6ull.h | 5 +
> >   include/configs/colibri_imx7.h| 5 +
> >   2 files changed, 10 insertions(+)
> > 
> 
> Sure, but is it not time to move CONFIG_ENV_RANGE into Kconfig (and drop it
> from whitelist= ?

I'll try to have a look at it later tonight, I cannot warrant anything at the
moment.

Francesco



Re: [PATCH v1 0/2] board: toradex: improve env badblock management for NAND variant boards

2021-10-21 Thread Stefano Babic

Hi Francesco,

On 01.09.21 09:48, Francesco Dolcini wrote:


Use the complete 512kb (4 blocks) nand partition reserved for u-boot
environment instead of just the first block, this allows the module
to have a working environment even if 3 blocks are bad.


Francesco Dolcini (2):
   colibri-imx6ull: improve env badblock management
   colibri-imx7: improve env badblock management

  include/configs/colibri-imx6ull.h | 5 +
  include/configs/colibri_imx7.h| 5 +
  2 files changed, 10 insertions(+)



Sure, but is it not time to move CONFIG_ENV_RANGE into Kconfig (and drop 
it from whitelist= ?


Best regards,
Stefano Babic

--
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=