Re: [PATCH v1 42/43] x86: Rename board_final_cleanup() to board_final_init()

[Bin Meng]

On Mon, Jun 15, 2020 at 11:58 AM Simon Glass  wrote:
>
> This function sounds like something that is called when U-Boot is about to
> jump to Linux. In fact it is an init function.
>
> Rename it to reduce confusion.
>
> Signed-off-by: Simon Glass 
> ---
>
>  arch/x86/cpu/coreboot/coreboot.c | 4 ++--
>  arch/x86/cpu/cpu.c   | 8 
>  arch/x86/cpu/efi/app.c   | 2 +-
>  arch/x86/cpu/quark/quark.c   | 2 +-
>  arch/x86/lib/fsp/fsp_common.c| 2 +-
>  5 files changed, 9 insertions(+), 9 deletions(-)
>

Reviewed-by: Bin Meng 

Re: [PATCH v1 42/43] x86: Rename board_final_cleanup() to board_final_init()

[Wolfgang Wallner]

Hi Simon,

-"Simon Glass"  schrieb: -
> Betreff: [PATCH v1 42/43] x86: Rename board_final_cleanup() to 
> board_final_init()
> 
> This function sounds like something that is called when U-Boot is about to
> jump to Linux. In fact it is an init function.
> 
> Rename it to reduce confusion.
> 
> Signed-off-by: Simon Glass 
> ---
> 
>  arch/x86/cpu/coreboot/coreboot.c | 4 ++--
>  arch/x86/cpu/cpu.c   | 8 
>  arch/x86/cpu/efi/app.c   | 2 +-
>  arch/x86/cpu/quark/quark.c   | 2 +-
>  arch/x86/lib/fsp/fsp_common.c| 2 +-
>  5 files changed, 9 insertions(+), 9 deletions(-)

Reviewed-by: Wolfgang Wallner