Re: [PATCH v2 04/15] Revert "drivers: smem: sandbox"

2026-05-18 Thread Fabio Estevam 
On Mon, May 4, 2026 at 4:07 PM Casey Connolly  wrote:
>
> This reverts commit 7fd7e2cf339ea2ec570f6dae1cdfaf8e066eb4af.

It would be helpful to have an explanation here for why the revert is
being made.

Re: [PATCH v2 04/15] Revert "drivers: smem: sandbox"

2026-05-18 Thread Neil Armstrong 

On 5/4/26 20:57, Casey Connolly wrote:

This reverts commit 7fd7e2cf339ea2ec570f6dae1cdfaf8e066eb4af.

Signed-off-by: Casey Connolly 
---
  arch/sandbox/dts/test.dts   | 4 
  configs/sandbox64_defconfig | 2 --
  configs/sandbox_defconfig   | 2 --
  3 files changed, 8 deletions(-)

diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index ac92ebf1afd7..50201ad61ccd 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -1521,12 +1521,8 @@
compatible = "sandbox,scsi";
sandbox,filepath = "scsi.img";
};
  
-	smem@0 {

-   compatible = "sandbox,smem";
-   };
-
sound {
compatible = "sandbox,sound";
cpu {
sound-dai = <&i2s 0>;
diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig
index 60a30d048750..53f7af4270af 100644
--- a/configs/sandbox64_defconfig
+++ b/configs/sandbox64_defconfig
@@ -240,10 +240,8 @@ CONFIG_SANDBOX_RESET=y
  CONFIG_DM_RTC=y
  CONFIG_RTC_RV8803=y
  CONFIG_SCSI=y
  CONFIG_SANDBOX_SERIAL=y
-CONFIG_SMEM=y
-CONFIG_SANDBOX_SMEM=y
  CONFIG_SOUND=y
  CONFIG_SOUND_SANDBOX=y
  CONFIG_SOC_DEVICE=y
  CONFIG_SANDBOX_SPI=y
diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
index f26295103f1c..7f26405e6ed0 100644
--- a/configs/sandbox_defconfig
+++ b/configs/sandbox_defconfig
@@ -331,10 +331,8 @@ CONFIG_RTC_RV8803=y
  CONFIG_RTC_HT1380=y
  CONFIG_SCSI=y
  CONFIG_SANDBOX_SERIAL=y
  CONFIG_SANDBOX_SM=y
-CONFIG_SMEM=y
-CONFIG_SANDBOX_SMEM=y
  CONFIG_SOUND=y
  CONFIG_SOUND_DA7219=y
  CONFIG_SOUND_MAX98357A=y
  CONFIG_SOUND_SANDBOX=y



Reviewed-by: Neil Armstrong 

Thanks,
Neil

Re: [PATCH v2 04/15] Revert "drivers: smem: sandbox"

2026-05-05 Thread Sumit Garg 
On Mon, May 04, 2026 at 08:57:32PM +0200, Casey Connolly wrote:
> This reverts commit 7fd7e2cf339ea2ec570f6dae1cdfaf8e066eb4af.
> 
> Signed-off-by: Casey Connolly 
> ---
>  arch/sandbox/dts/test.dts   | 4 
>  configs/sandbox64_defconfig | 2 --
>  configs/sandbox_defconfig   | 2 --
>  3 files changed, 8 deletions(-)

Reviewed-by: Sumit Garg 

-Sumit

> 
> diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
> index ac92ebf1afd7..50201ad61ccd 100644
> --- a/arch/sandbox/dts/test.dts
> +++ b/arch/sandbox/dts/test.dts
> @@ -1521,12 +1521,8 @@
>   compatible = "sandbox,scsi";
>   sandbox,filepath = "scsi.img";
>   };
>  
> - smem@0 {
> - compatible = "sandbox,smem";
> - };
> -
>   sound {
>   compatible = "sandbox,sound";
>   cpu {
>   sound-dai = <&i2s 0>;
> diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig
> index 60a30d048750..53f7af4270af 100644
> --- a/configs/sandbox64_defconfig
> +++ b/configs/sandbox64_defconfig
> @@ -240,10 +240,8 @@ CONFIG_SANDBOX_RESET=y
>  CONFIG_DM_RTC=y
>  CONFIG_RTC_RV8803=y
>  CONFIG_SCSI=y
>  CONFIG_SANDBOX_SERIAL=y
> -CONFIG_SMEM=y
> -CONFIG_SANDBOX_SMEM=y
>  CONFIG_SOUND=y
>  CONFIG_SOUND_SANDBOX=y
>  CONFIG_SOC_DEVICE=y
>  CONFIG_SANDBOX_SPI=y
> diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
> index f26295103f1c..7f26405e6ed0 100644
> --- a/configs/sandbox_defconfig
> +++ b/configs/sandbox_defconfig
> @@ -331,10 +331,8 @@ CONFIG_RTC_RV8803=y
>  CONFIG_RTC_HT1380=y
>  CONFIG_SCSI=y
>  CONFIG_SANDBOX_SERIAL=y
>  CONFIG_SANDBOX_SM=y
> -CONFIG_SMEM=y
> -CONFIG_SANDBOX_SMEM=y
>  CONFIG_SOUND=y
>  CONFIG_SOUND_DA7219=y
>  CONFIG_SOUND_MAX98357A=y
>  CONFIG_SOUND_SANDBOX=y
> 
> -- 
> 2.53.0
>