Re: [PATCH v3 0/5] Fix compiler warnings for 32-bit ARM
On Sun, Oct 31, 2021 at 05:47:00PM -0600, Simon Glass wrote: > Hi, > > On Sun, 1 Aug 2021 at 18:56, Simon Glass wrote: > > > > These were noticed when building sandbox on a Raspberry Pi 400, which uses > > 32-bit linux. > > > > To make this work, I enabled CONFIG_HOST_32BIT in 'make menuconfig'. It > > would be nice if that were automatic, since we have the logic already in > > arch/sandbox/config.mk > > > > So this series adds that. > > > > It also fixes the unicode warnings of the form: > > > > /usr/bin/ld: warning: arch/sandbox/cpu/start.o uses 2-byte wchar_t yet the > > output is to use 4-byte wchar_t; use of wchar_t values across objects > > may fail > > > > as suggested by Heinrich. > > > > Changes in v3: > > - Mention the link to the new upstream patch > > - Change some things EFI things missed (or new since) last time > > - Use 'bitness' instead of 'bit' > > - Add a new patch to change non-EFI occurences > > > > Changes in v2: > > - Add new patch to reduce checkpatch unicode-string spam > > - Drop patches previously applied > > - Put all the packages in gcc.rst > > > > Joe Perches (1): > > checkpatch: Support wide strings Has this been merged upstream yet? It's going to get lost otherwise. > > Simon Glass (4): > > efi: Use 16-bit unicode strings > > treewide: Use 16-bit unicode strings What was the outcome here? I think I was saying we should make some global correction to the source tree, was this in fact it? > > sandbox: Detect the host bit size automatically Commented on now. > > RFC: treewide: Drop -fshort-char I think this causes other problems unfortunately? -- Tom signature.asc Description: PGP signature
Re: [PATCH v3 0/5] Fix compiler warnings for 32-bit ARM
Hi, On Sun, 1 Aug 2021 at 18:56, Simon Glass wrote: > > These were noticed when building sandbox on a Raspberry Pi 400, which uses > 32-bit linux. > > To make this work, I enabled CONFIG_HOST_32BIT in 'make menuconfig'. It > would be nice if that were automatic, since we have the logic already in > arch/sandbox/config.mk > > So this series adds that. > > It also fixes the unicode warnings of the form: > > /usr/bin/ld: warning: arch/sandbox/cpu/start.o uses 2-byte wchar_t yet the > output is to use 4-byte wchar_t; use of wchar_t values across objects > may fail > > as suggested by Heinrich. > > Changes in v3: > - Mention the link to the new upstream patch > - Change some things EFI things missed (or new since) last time > - Use 'bitness' instead of 'bit' > - Add a new patch to change non-EFI occurences > > Changes in v2: > - Add new patch to reduce checkpatch unicode-string spam > - Drop patches previously applied > - Put all the packages in gcc.rst > > Joe Perches (1): > checkpatch: Support wide strings > > Simon Glass (4): > efi: Use 16-bit unicode strings > sandbox: Detect the host bit size automatically > treewide: Use 16-bit unicode strings > RFC: treewide: Drop -fshort-char Any word on this series please? Regards, Simon > > Makefile | 13 ++- > arch/arm/config.mk| 2 +- > arch/sandbox/Kconfig | 13 ++- > arch/x86/config.mk| 2 +- > arch/x86/cpu/Makefile | 2 +- > arch/x86/lib/Makefile | 6 +- > cmd/efidebug.c| 12 +- > include/efi_loader.h | 2 +- > include/efi_selftest.h| 4 +- > lib/efi/Makefile | 4 +- > lib/efi_loader/efi_bootmgr.c | 12 +- > lib/efi_loader/efi_boottime.c | 2 +- > lib/efi_loader/efi_capsule.c | 20 ++-- > lib/efi_loader/efi_helper.c | 2 +- > lib/efi_loader/efi_image_loader.c | 8 +- > lib/efi_loader/efi_setup.c| 20 ++-- > lib/efi_loader/efi_signature.c| 4 +- > lib/efi_loader/efi_string.c | 2 +- > lib/efi_loader/efi_var_common.c | 14 +-- > lib/efi_loader/efi_variable.c | 6 +- > lib/efi_loader/efi_variable_tee.c | 2 +- > lib/efi_loader/helloworld.c | 40 +++ > lib/efi_selftest/dtbdump.c| 82 +++--- > lib/efi_selftest/efi_selftest.c | 2 +- > lib/efi_selftest/efi_selftest_block_device.c | 6 +- > lib/efi_selftest/efi_selftest_devicepath.c| 2 +- > lib/efi_selftest/efi_selftest_exception.c | 2 +- > lib/efi_selftest/efi_selftest_fdt.c | 6 +- > lib/efi_selftest/efi_selftest_hii.c | 8 +- > lib/efi_selftest/efi_selftest_load_file.c | 4 +- > lib/efi_selftest/efi_selftest_loadimage.c | 4 +- > .../efi_selftest_miniapp_exception.c | 4 +- > lib/efi_selftest/efi_selftest_miniapp_exit.c | 8 +- > .../efi_selftest_miniapp_return.c | 2 +- > lib/efi_selftest/efi_selftest_reset.c | 2 +- > lib/efi_selftest/efi_selftest_textoutput.c| 12 +- > .../efi_selftest_unicode_collation.c | 38 +++ > lib/efi_selftest/efi_selftest_util.c | 106 +- > lib/efi_selftest/efi_selftest_variables.c | 22 ++-- > .../efi_selftest_variables_runtime.c | 4 +- > lib/efi_selftest/initrddump.c | 60 +- > lib/lzma/Types.h | 4 +- > scripts/checkpatch.pl | 7 +- > scripts/kconfig/Makefile | 14 ++- > test/print_ut.c | 2 +- > test/unicode_ut.c | 22 ++-- > 46 files changed, 320 insertions(+), 295 deletions(-) > > -- > 2.32.0.554.ge1b32706d8-goog >
