Re: [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options""
Simon,
On Mon, Oct 11, 2021 at 08:54:10AM -0600, Simon Glass wrote:
> Hi Takahiro, Ilias,
>
> On Sun, 10 Oct 2021 at 18:29, AKASHI Takahiro
> wrote:
> >
> > On Fri, Oct 08, 2021 at 10:11:59PM +0300, Ilias Apalodimas wrote:
> > > Hi Simon,
> > >
> > > On Fri, Oct 08, 2021 at 09:38:11AM -0600, Simon Glass wrote:
> > > > Hi Takahiro,
> > > >
> > > > On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro
> > > > wrote:
> > > > >
> > > > > This reverts commit d428e81266a59974ade74c1ba019af39f23304ab.
> > > > > We have agreed with removing dtb-related stuff from mkeficapsule
> > > > > command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move
> > > > > signature from DTB to .rodata"") was applied.
> > > >
> > > > Can you please explain why this is being removed? How is the public
> > > > key to be communicated?
> > >
> > > Via the script that Akashi-san is adding in this patch series.
> >
> > Yeah, please see my patch#4 for fdtsig.sh.
>
> OK I see. I don't think I was copied on that. I replied on the patch.
In my initial submission, there were some accidentally-duplicated patches
that would have caused some confusion.
> Is there a tree somewhere with all the patches and docs so I can take a look?
Please take a look at:
https://git.linaro.org/people/takahiro.akashi/u-boot.git efi/dm_disk
-Takahiro Akashi
> Regards,
> Simon
>
>
>
> > The reason why I think we should remove the feature from mkeficapsule
> > command is partly because we can do the same task by using *existing*
> > fdt tools and partly because having two totally-independent functionality
> > (one for a capsule binary and one for fdt) in a single tool seems confusing.
> >
> > > >
> > > > Please can you also copy me on future related patches? (thank for you
> > > > for the private email alerting me)
> > > >
> > > > What does "We have agreed" mean?
> > >
> > > This has nothing to do with the public key. This is only changing the
> > > tool
> > > we used to include the key in the DTB. It is the same patch I mentioned
> > > you
> > > should never have reverted in the first place on your pull request, but
> > > since
> > > that happened very late in the release cycle we said we would re-apply it
> > > after
> > > the release.
> >
> > Indeed.
> >
> > -Takahiro Akashi
> >
> >
> > > >
> > > > >
> > > > > Signed-off-by: AKASHI Takahiro
> > > > > ---
> > > > > tools/mkeficapsule.c | 229
> > > > > ++-
> > > > > 1 file changed, 7 insertions(+), 222 deletions(-)
> > > > >
> > > >
> > > > Regards,
> > > > Simon
> > >
> > > It was my patch to begin with so I am not really sure my reviewed tag has
> > > any value, but FWIW
> > >
> > > Reviewed-by: Ilias Apalodimas
Re: [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options""
Hi Takahiro, Ilias,
On Sun, 10 Oct 2021 at 18:29, AKASHI Takahiro
wrote:
>
> On Fri, Oct 08, 2021 at 10:11:59PM +0300, Ilias Apalodimas wrote:
> > Hi Simon,
> >
> > On Fri, Oct 08, 2021 at 09:38:11AM -0600, Simon Glass wrote:
> > > Hi Takahiro,
> > >
> > > On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro
> > > wrote:
> > > >
> > > > This reverts commit d428e81266a59974ade74c1ba019af39f23304ab.
> > > > We have agreed with removing dtb-related stuff from mkeficapsule
> > > > command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move
> > > > signature from DTB to .rodata"") was applied.
> > >
> > > Can you please explain why this is being removed? How is the public
> > > key to be communicated?
> >
> > Via the script that Akashi-san is adding in this patch series.
>
> Yeah, please see my patch#4 for fdtsig.sh.
OK I see. I don't think I was copied on that. I replied on the patch.
Is there a tree somewhere with all the patches and docs so I can take a look?
Regards,
Simon
> The reason why I think we should remove the feature from mkeficapsule
> command is partly because we can do the same task by using *existing*
> fdt tools and partly because having two totally-independent functionality
> (one for a capsule binary and one for fdt) in a single tool seems confusing.
>
> > >
> > > Please can you also copy me on future related patches? (thank for you
> > > for the private email alerting me)
> > >
> > > What does "We have agreed" mean?
> >
> > This has nothing to do with the public key. This is only changing the tool
> > we used to include the key in the DTB. It is the same patch I mentioned you
> > should never have reverted in the first place on your pull request, but
> > since
> > that happened very late in the release cycle we said we would re-apply it
> > after
> > the release.
>
> Indeed.
>
> -Takahiro Akashi
>
>
> > >
> > > >
> > > > Signed-off-by: AKASHI Takahiro
> > > > ---
> > > > tools/mkeficapsule.c | 229 ++-
> > > > 1 file changed, 7 insertions(+), 222 deletions(-)
> > > >
> > >
> > > Regards,
> > > Simon
> >
> > It was my patch to begin with so I am not really sure my reviewed tag has
> > any value, but FWIW
> >
> > Reviewed-by: Ilias Apalodimas
Re: [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options""
On Fri, Oct 08, 2021 at 10:11:59PM +0300, Ilias Apalodimas wrote:
> Hi Simon,
>
> On Fri, Oct 08, 2021 at 09:38:11AM -0600, Simon Glass wrote:
> > Hi Takahiro,
> >
> > On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro
> > wrote:
> > >
> > > This reverts commit d428e81266a59974ade74c1ba019af39f23304ab.
> > > We have agreed with removing dtb-related stuff from mkeficapsule
> > > command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move
> > > signature from DTB to .rodata"") was applied.
> >
> > Can you please explain why this is being removed? How is the public
> > key to be communicated?
>
> Via the script that Akashi-san is adding in this patch series.
Yeah, please see my patch#4 for fdtsig.sh.
The reason why I think we should remove the feature from mkeficapsule
command is partly because we can do the same task by using *existing*
fdt tools and partly because having two totally-independent functionality
(one for a capsule binary and one for fdt) in a single tool seems confusing.
> >
> > Please can you also copy me on future related patches? (thank for you
> > for the private email alerting me)
> >
> > What does "We have agreed" mean?
>
> This has nothing to do with the public key. This is only changing the tool
> we used to include the key in the DTB. It is the same patch I mentioned you
> should never have reverted in the first place on your pull request, but since
> that happened very late in the release cycle we said we would re-apply it
> after
> the release.
Indeed.
-Takahiro Akashi
> >
> > >
> > > Signed-off-by: AKASHI Takahiro
> > > ---
> > > tools/mkeficapsule.c | 229 ++-
> > > 1 file changed, 7 insertions(+), 222 deletions(-)
> > >
> >
> > Regards,
> > Simon
>
> It was my patch to begin with so I am not really sure my reviewed tag has
> any value, but FWIW
>
> Reviewed-by: Ilias Apalodimas
Re: [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options""
Hi Simon,
On Fri, Oct 08, 2021 at 09:38:11AM -0600, Simon Glass wrote:
> Hi Takahiro,
>
> On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro
> wrote:
> >
> > This reverts commit d428e81266a59974ade74c1ba019af39f23304ab.
> > We have agreed with removing dtb-related stuff from mkeficapsule
> > command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move
> > signature from DTB to .rodata"") was applied.
>
> Can you please explain why this is being removed? How is the public
> key to be communicated?
Via the script that Akashi-san is adding in this patch series.
>
> Please can you also copy me on future related patches? (thank for you
> for the private email alerting me)
>
> What does "We have agreed" mean?
This has nothing to do with the public key. This is only changing the tool
we used to include the key in the DTB. It is the same patch I mentioned you
should never have reverted in the first place on your pull request, but since
that happened very late in the release cycle we said we would re-apply it after
the release.
>
> >
> > Signed-off-by: AKASHI Takahiro
> > ---
> > tools/mkeficapsule.c | 229 ++-
> > 1 file changed, 7 insertions(+), 222 deletions(-)
> >
>
> Regards,
> Simon
It was my patch to begin with so I am not really sure my reviewed tag has
any value, but FWIW
Reviewed-by: Ilias Apalodimas
Re: [PATCH v4 01/11] Revert "Revert "mkeficapsule: Remove dtb related options""
Hi Takahiro,
On Thu, 7 Oct 2021 at 00:24, AKASHI Takahiro wrote:
>
> This reverts commit d428e81266a59974ade74c1ba019af39f23304ab.
> We have agreed with removing dtb-related stuff from mkeficapsule
> command even if the commit 47a25e81d35c ("Revert "efi_capsule: Move
> signature from DTB to .rodata"") was applied.
Can you please explain why this is being removed? How is the public
key to be communicated?
Please can you also copy me on future related patches? (thank for you
for the private email alerting me)
What does "We have agreed" mean?
>
> Signed-off-by: AKASHI Takahiro
> ---
> tools/mkeficapsule.c | 229 ++-
> 1 file changed, 7 insertions(+), 222 deletions(-)
>
Regards,
Simon
