Re: [PATCH v6 06/12] test/py: efi_capsule: add image authentication test

2021-11-02 Thread Ilias Apalodimas
On Tue, 2 Nov 2021 at 16:58, Simon Glass  wrote:
>
> On Mon, 1 Nov 2021 at 18:56, AKASHI Takahiro  
> wrote:
> >
> > Add a couple of test cases against capsule image authentication
> > for capsule-on-disk, where only a signed capsule file with the verified
> > signature will be applied to the system.
> >
> > Due to the difficulty of embedding a public key (esl file) in U-Boot
> > binary during pytest setup time, all the keys/certificates are pre-created.
> >
> > Signed-off-by: AKASHI Takahiro 
> > ---
> >  .../py/tests/test_efi_capsule/capsule_defs.py |   5 +
> >  test/py/tests/test_efi_capsule/conftest.py|  52 +++-
> >  test/py/tests/test_efi_capsule/signature.dts  |  10 +
> >  .../test_capsule_firmware_signed.py   | 254 ++
> >  4 files changed, 318 insertions(+), 3 deletions(-)
> >  create mode 100644 test/py/tests/test_efi_capsule/signature.dts
> >  create mode 100644 
> > test/py/tests/test_efi_capsule/test_capsule_firmware_signed.py
>
> Reviewed-by: Simon Glass 

Acked-by: Ilias Apalodimas 


Re: [PATCH v6 06/12] test/py: efi_capsule: add image authentication test

2021-11-02 Thread Simon Glass
On Mon, 1 Nov 2021 at 18:56, AKASHI Takahiro  wrote:
>
> Add a couple of test cases against capsule image authentication
> for capsule-on-disk, where only a signed capsule file with the verified
> signature will be applied to the system.
>
> Due to the difficulty of embedding a public key (esl file) in U-Boot
> binary during pytest setup time, all the keys/certificates are pre-created.
>
> Signed-off-by: AKASHI Takahiro 
> ---
>  .../py/tests/test_efi_capsule/capsule_defs.py |   5 +
>  test/py/tests/test_efi_capsule/conftest.py|  52 +++-
>  test/py/tests/test_efi_capsule/signature.dts  |  10 +
>  .../test_capsule_firmware_signed.py   | 254 ++
>  4 files changed, 318 insertions(+), 3 deletions(-)
>  create mode 100644 test/py/tests/test_efi_capsule/signature.dts
>  create mode 100644 
> test/py/tests/test_efi_capsule/test_capsule_firmware_signed.py

Reviewed-by: Simon Glass