Re: [PATCH v6 7/7] bootm: Tidy up use of autostart env var
Hi Wolfgang, On Fri, 15 Oct 2021 at 08:45, Wolfgang Denk wrote: > > Dear Simon Glass, > > In message <20211014182257.468649-6-...@chromium.org> you wrote: > > This has different semantics in different places. Go with the bootm method > > and put it in a common function so that the behaviour is consistent in > > U-Boot. Update the docs. > > > > Signed-off-by: Simon Glass > > Suggested-by: Wolfgang Denk > > It should be noted that this commit changes the behaviour of U-Boot > for "autostart" users, thus it has the potential of breaking > existent systems. > > The problematic cases are in do_bootelf() [cmd/elf.c] and > do_bootm_standalone() [common/bootm_os.c]; the 3rd place where this > is used - bootm_maybe_autostart() [cmd/bootm.c] - does not change. > > Or am I missing something? Just to reply here, I sent an updated patch explaining that this does in fact change behaviour, but only in a case that seems safe enough. Regards, Simon
Re: [PATCH v6 7/7] bootm: Tidy up use of autostart env var
Dear Simon Glass, In message <20211014182257.468649-6-...@chromium.org> you wrote: > This has different semantics in different places. Go with the bootm method > and put it in a common function so that the behaviour is consistent in > U-Boot. Update the docs. > > Signed-off-by: Simon Glass > Suggested-by: Wolfgang Denk It should be noted that this commit changes the behaviour of U-Boot for "autostart" users, thus it has the potential of breaking existent systems. The problematic cases are in do_bootelf() [cmd/elf.c] and do_bootm_standalone() [common/bootm_os.c]; the 3rd place where this is used - bootm_maybe_autostart() [cmd/bootm.c] - does not change. Or am I missing something? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de I express preference for a chronological sequence of events which precludes a violence. - Terry Pratchett, _The Dark Side of the Sun_
