Re: [U-Boot] [PATCH] AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI)
What is the status of this patch for getting MCI working on SAM9 CPUs? I am working on a new AT91SAM9G45 board and would like to incorporate it if it is ready for prime time. It is not clear to me who should be signing off on this patch and if they have done so. If there is work to be done on this and I could help, please let me know. I intend to submit the patches to get my 9G45 board mainlined and this might be a good way for me to start learning the intricacies of making and submitting a proper patch. Any suggestions will be appreciated. Thanks, Bill Landolina Technology Atlanta Corporation w...@techatl.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI)
William C. Landolina wrote: What is the status of this patch for getting MCI working on SAM9 CPUs? I am working on a new AT91SAM9G45 board and would like to incorporate it if it is ready for prime time. It is not clear to me who should be signing off on this patch and if they have done so. The Patch is ready and working for 9260/9XE, I signed it off. Next step is for Eric(Hong) Xu to add it to the at91 custodian git, and finally it to be pulled into mainstream. If there is work to be done on this and I could help, please let me know. I intend to submit the patches to get my 9G45 board mainlined and this might be a good way for me to start learning the intricacies of making and submitting a proper patch. For other than 9260/9XE SoCs it should work fine, maybe some defines have to be added to their at91x.h header files, you'll find that out if you try to use ATMEL_MCI there. Any suggestions will be appreciated. Soon I will be working on support for more than 4 GB cards. Reinhard ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI)
Dear Reinhard, Could you please rebase your code to master@ git://git.denx.de/u-boot-at91.git ? Thanks! BR, Eric Reinhard Meyer (-VC) wrote: This patch adds support for the Atmel MultiMedia Card Interface (MCI) in AT91SAM9260 and AT91SAM9XE SoCs and preserves the original support for the AVR32AP700x SoCs. It patches the original atmel_mci.c driver to remove byte order and toolchain dependencies and makes it a common MCI driver for Atmels AVR32AP7000 and AT91SAM9260 based SoCs. The driver itself is not specific to those SoCs and should work with other Atmel devices having an identical MultiMedia Card Interface (MCI), provided the functions get_mci_clk_rate() and SoC_mci_hw_init() are defined. Tested on AT91SAM9XE-EK (AT91SAM9XE512) Tested on ATNGW100 (AVR32AP7000) Signed-off-by: Reinhard Meyer reinhard.me...@emk-elektronik.de --- arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c | 20 arch/arm/include/asm/arch-at91/clk.h |5 + arch/arm/include/asm/arch-at91/hardware.h |1 + doc/README.atmel_mci | 68 + drivers/mmc/atmel_mci.c | 112 ++--- drivers/mmc/atmel_mci.h |6 +- include/mmc.h | 93 ++--- 7 files changed, 207 insertions(+), 98 deletions(-) create mode 100644 doc/README.atmel_mci ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI)
Eric Xu schrieb: Dear Reinhard, Could you please rebase your code to master@ git://git.denx.de/u-boot-at91.git ? Thanks! BR, Eric Reinhard Meyer (-VC) wrote: This patch adds support for the Atmel MultiMedia Card Interface (MCI) in AT91SAM9260 and AT91SAM9XE SoCs and preserves the original support for the AVR32AP700x SoCs. Hi Eric, I am not a GIT specialist and working in the main GIT tree. How do I rebase into another tree? Does the patch not apply to your at91.git tree? Reinhard attachment: reinhard_meyer.vcf___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI)
Dear Eric Xu, In message 4c31770b.1020...@atmel.com you wrote: Could you please rebase your code to master@ git://git.denx.de/u-boot-at91.git ? Why are you requesting this? I do not want a situation that patches need to be submitted agaionst a number of different trees or branches, with the unavoidable result that the majority of readers here on the list cannot test the postings bcause they do not apply against the master repository. Because of that, http://www.denx.de/wiki/U-Boot/Patches states explicitly: Please use the master branch of the mainline U-Boot git repository (git://git.denx.de/u-boot.git) as reference, unless (usually late in a release cycle) there has been an announcement to use the next branch of this repository instead. If your AT91 repository requires a different state, it is your task as custodian to keep it in sync with master, and to resolve any merge conflicts resulting from the remaining differences. Reinhards patch appears to apply cleanly against master, so it should NOT be changed. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Real computer scientists despise the idea of actual hardware. Hard- ware has limitations, software doesn't. It's a real shame that Turing machines are so poor at I/O. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI)
Dear Wolfgang, It seems the root cause of my failure of applying Reinhard's patch is the exchange server settings. Some of the space/tabs are converted/expanded in a wrong way. Thanks for the help and hints from you and Mr.Reinhard. BR, Eric -Original Message- From: Wolfgang Denk [mailto:w...@denx.de] Sent: 2010-7-5 (星期一) 20:46 To: Xu, Hong Cc: reinhard.me...@emk-elektronik.de; u-boot Subject: Re: 答复: [U-Boot] [PATCH] AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI) Dear Xu, Hong, In message 0f5f73e36031fd46ad3f2e6948f0c0a0205...@frimb01.corp.atmel.com you wrote: The reason is I tried to apply the patch on top of 1) master branch of the mainline U-Boot 2) current master of u-boot-at91.git 3) The old master of u-boot-at91.git all of them are failed. Since you said the patch is cleanly against master of mainline U-Boot, = I'll rework. It applies indeed without problems on top of the current master branch (i. e. on top of commit v2010.06-73-g54841ab) : - git-am -3 -i -u --whitespace=strip ~/Mail/U-Boot/8433 Commit Body is: -- AT91SAM9260/9XE: add support for MultiMedia Card Interface (MCI) This patch adds support for the Atmel MultiMedia Card Interface (MCI) in AT91SAM9260 and AT91SAM9XE SoCs and preserves the original support for the AVR32AP700x SoCs. It patches the original atmel_mci.c driver to remove byte order and toolchain dependencies and makes it a common MCI driver for Atmels AVR32AP7000 and AT91SAM9260 based SoCs. The driver itself is not specific to those SoCs and should work with other Atmel devices having an identical MultiMedia Card Interface (MCI), [...] ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
