Re: [U-Boot] [PATCH] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set

2018-02-02 Thread Masahiro Yamada 
2018-02-01 0:21 GMT+09:00 Alexey Brodkin :
> Hi Masahiro-san,
>
> On Thu, 2018-02-01 at 00:18 +0900, Masahiro Yamada wrote:
>> 2018-01-31 1:28 GMT+09:00 Alexey Brodkin :
>> > Hi MAsahiro-san, Tom,
>> >
>> > On Wed, 2018-01-31 at 01:23 +0900, Masahiro Yamada wrote:
>> > > 2018-01-31 0:23 GMT+09:00 Alexey Brodkin :
>> > > >
>> > >
>> > > Please feel free to include historical reason:
>> > >
>> > > This ifneq conditional was added for Blackfin because it did not use
>> > > CONFIG_SYS_TEXT_BASE.
>> > > See.
>> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_u-2Dboot_u-2Dboot_blob_v2017.03_arch_blackfin_config.mk-23L67=DwIBaQ=DPL6_X_
>> > > 6JkX
>> > > Fx7AXWqB0tg=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I=mezwGj3E5EIPuE8Oln2gVeTJ-8q19KNepz7Jo-
>> > > Kcu1o=dmnDXQ05QLyAFKUgnsVyJOS8aybk3rhbDNsgiio6zvA=
>> > >
>> > > Then Blackfin is gone, so should be OK.
>> >
>> > Should I send a respin with this valuable addition or whoever's going to 
>> > apply will
>> > fix-up this?
>> >
>> > -Alexey
>>
>>
>> Either will do for me.
>
> I'd prefer to let you do this fix-up so we don't spam both mailing list and 
> patchwork with v2.
>
> -Alexey

I think your comment in another one is good
(http://patchwork.ozlabs.org/patch/868299/)

If you are reluctant on v2, you can ask Tom to
rephrase the log when this patch is applied.



-- 
Best Regards
Masahiro Yamada
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set

2018-01-31 Thread Alexey Brodkin 
Hi Masahiro-san,

On Thu, 2018-02-01 at 00:18 +0900, Masahiro Yamada wrote:
> 2018-01-31 1:28 GMT+09:00 Alexey Brodkin :
> > Hi MAsahiro-san, Tom,
> > 
> > On Wed, 2018-01-31 at 01:23 +0900, Masahiro Yamada wrote:
> > > 2018-01-31 0:23 GMT+09:00 Alexey Brodkin :
> > > > 
> > > 
> > > Please feel free to include historical reason:
> > > 
> > > This ifneq conditional was added for Blackfin because it did not use
> > > CONFIG_SYS_TEXT_BASE.
> > > See.
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_u-2Dboot_u-2Dboot_blob_v2017.03_arch_blackfin_config.mk-23L67=DwIBaQ=DPL6_X_
> > > 6JkX
> > > Fx7AXWqB0tg=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I=mezwGj3E5EIPuE8Oln2gVeTJ-8q19KNepz7Jo-
> > > Kcu1o=dmnDXQ05QLyAFKUgnsVyJOS8aybk3rhbDNsgiio6zvA=
> > > 
> > > Then Blackfin is gone, so should be OK.
> > 
> > Should I send a respin with this valuable addition or whoever's going to 
> > apply will
> > fix-up this?
> > 
> > -Alexey
> 
> 
> Either will do for me.

I'd prefer to let you do this fix-up so we don't spam both mailing list and 
patchwork with v2.

-Alexey
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set

2018-01-31 Thread Masahiro Yamada 
2018-01-31 1:28 GMT+09:00 Alexey Brodkin :
> Hi MAsahiro-san, Tom,
>
> On Wed, 2018-01-31 at 01:23 +0900, Masahiro Yamada wrote:
>> 2018-01-31 0:23 GMT+09:00 Alexey Brodkin :
>> >
>> Please feel free to include historical reason:
>>
>> This ifneq conditional was added for Blackfin because it did not use
>> CONFIG_SYS_TEXT_BASE.
>> See.
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_u-2Dboot_u-2Dboot_blob_v2017.03_arch_blackfin_config.mk-23L67=DwIBaQ=DPL6_X_6JkX
>> Fx7AXWqB0tg=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I=mezwGj3E5EIPuE8Oln2gVeTJ-8q19KNepz7Jo-
>> Kcu1o=dmnDXQ05QLyAFKUgnsVyJOS8aybk3rhbDNsgiio6zvA=
>>
>> Then Blackfin is gone, so should be OK.
>
> Should I send a respin with this valuable addition or whoever's going to 
> apply will
> fix-up this?
>
> -Alexey


Either will do for me.

-- 
Best Regards
Masahiro Yamada
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set

2018-01-30 Thread Alexey Brodkin 
Hi MAsahiro-san, Tom,

On Wed, 2018-01-31 at 01:23 +0900, Masahiro Yamada wrote:
> 2018-01-31 0:23 GMT+09:00 Alexey Brodkin :
> > 
> Please feel free to include historical reason:
> 
> This ifneq conditional was added for Blackfin because it did not use
> CONFIG_SYS_TEXT_BASE.
> See.
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_u-2Dboot_u-2Dboot_blob_v2017.03_arch_blackfin_config.mk-23L67=DwIBaQ=DPL6_X_6JkX
> Fx7AXWqB0tg=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I=mezwGj3E5EIPuE8Oln2gVeTJ-8q19KNepz7Jo-
> Kcu1o=dmnDXQ05QLyAFKUgnsVyJOS8aybk3rhbDNsgiio6zvA=
> 
> Then Blackfin is gone, so should be OK.

Should I send a respin with this valuable addition or whoever's going to apply 
will
fix-up this?

-Alexey
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Build system: Don't check for CONFIG_SYS_TEXT_BASE being set

2018-01-30 Thread Masahiro Yamada 
2018-01-31 0:23 GMT+09:00 Alexey Brodkin :
> CONFIG_SYS_TEXT_BASE must be set anyways and then it is used in many
> places in the same Makefile without any checks so there's no point in
> keeping this check araound just in one place.
>
> Signed-off-by: Alexey Brodkin 
> Cc: Tom Rini 
> ---
>  Makefile | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index ab3453dcebdc..6f15612b4d07 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -820,9 +820,7 @@ LDFLAGS_u-boot += $(LDFLAGS_FINAL)
>  # Avoid 'Not enough room for program headers' error on binutils 2.28 onwards.
>  LDFLAGS_u-boot += $(call ld-option, --no-dynamic-linker)
>
> -ifneq ($(CONFIG_SYS_TEXT_BASE),)
>  LDFLAGS_u-boot += -Ttext $(CONFIG_SYS_TEXT_BASE)
> -endif





Please feel free to include historical reason:

This ifneq conditional was added for Blackfin because it did not use
CONFIG_SYS_TEXT_BASE.
See.
https://github.com/u-boot/u-boot/blob/v2017.03/arch/blackfin/config.mk#L67

Then Blackfin is gone, so should be OK.

Acked-by: Masahiro Yamada 




>  # Normally we fill empty space with 0xff
>  quiet_cmd_objcopy = OBJCOPY $@
> --
> 2.14.3
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot



-- 
Best Regards
Masahiro Yamada
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot