Re: [U-Boot] [PATCH] Replace references to extern console_buffer with a function call

2008-08-15 Thread Wolfgang Denk
Dear Peter Tyser, what is the purpose of this patch? As far as I can see we gain nothing, but we lose on memory footpint. I guess there is some problem you're trying to fix, but you did not mention it? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk

Re: [U-Boot] [PATCH] Replace references to extern console_buffer with a function call

2008-08-15 Thread Peter Tyser
what is the purpose of this patch? As far as I can see we gain nothing, but we lose on memory footpint. I guess there is some problem you're trying to fix, but you did not mention it? I've added a basic debug serial console which relies on this patch. The debug console is a simple command

Re: [U-Boot] [PATCH] Replace references to extern console_buffer with a function call

2008-08-15 Thread Peter Tyser
I'm not sure if the debug console will be accepted to mainline, but I think this patch alone is an improvement over the current implementation Frankly, I don't think so - it just makes the code bigger for no good use to 99.9% of the users. of using a global string and multiple