Peter,
On Thu, Mar 17, 2011 at 7:32 AM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
+ /* Is PLL-X already running? */
+ reg = readl(clkrst-crc_pllx_base);
+ if (reg PLL_ENABLE)
+ return;
+
+ /* Do PLLX init if it isn't running, but BootROM
Allesandro,
On Thu, Mar 17, 2011 at 8:30 AM, Alessandro Rubini
rubini-l...@gnudd.com wrote:
It looks like most of your uses are standalone functions that would
function just fine on their own. Is there a reason you prefer to have
them in a C-file instead of in an assembly file?
Just
Hi Tom,
+ /* Is PLL-X already running? */
+ reg = readl(clkrst-crc_pllx_base);
+ if (reg PLL_ENABLE)
+ return;
+
+ /* Do PLLX init if it isn't running, but BootROM sets it, so TBD
*/
+}
The above function looks incorrect.
What looks
It looks like most of your uses are standalone functions that would
function just fine on their own. Is there a reason you prefer to have
them in a C-file instead of in an assembly file?
Just laziness ;)
I'll move these to a new .S file in the next patchset.
Actually, writing
Hi Tom,
I'm not too familiar with the architecture, so many comments are
aesthetic. It would be a good idea to run the patch through
checkpatch.pl too.
diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S
index 684f2d2..50a1725 100644
--- a/arch/arm/cpu/armv7/start.S
+++
Albert,
On Sun, Mar 13, 2011 at 10:46 AM, Albert ARIBAUD albert.arib...@free.fr wrote:
Le 16/02/2011 21:26, Tom Warren a écrit :
Signed-off-by: Tom Warrentwar...@nvidia.com
---
arch/arm/cpu/armv7/start.S | 6 +
arch/arm/cpu/armv7/tegra2/Makefile | 2 +-
Peter,
On Mon, Mar 14, 2011 at 8:33 AM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
I'm not too familiar with the architecture, so many comments are
aesthetic. It would be a good idea to run the patch through
checkpatch.pl too.
I run checkpatch on every submission. Only 1 warning was
Hi Tom,
snip
+static void init_pll_x(void)
+{
+ struct clk_rst_ctlr *clkrst = (struct clk_rst_ctlr
*)NV_PA_CLK_RST_BASE;
+ u32 reg;
The spaces in front of reg can be removed. Ditto for all
functions/variables.
Not sure what you mean, here, Peter. There are no
Peter,
On Mon, Mar 14, 2011 at 3:20 PM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
snip
+static void init_pll_x(void)
+{
+ struct clk_rst_ctlr *clkrst = (struct clk_rst_ctlr *)NV_PA_CLK_RST
_BASE;
+ u32 reg;
The spaces in front of reg can be removed. Ditto for
Albert,
On Tue, Feb 22, 2011 at 4:57 PM, Albert ARIBAUD albert.arib...@free.fr wrote:
Hi Tom,
Le 23/02/2011 00:41, Tom Warren a écrit :
Anyone willing to review this? I'd like to get it pulled in to
Albert's arm repo ASAP.
I should be able to review it during the week-end--not before,
Albert,
On Tue, Feb 22, 2011 at 4:57 PM, Albert ARIBAUD albert.arib...@free.fr wrote:
Hi Tom,
Le 23/02/2011 00:41, Tom Warren a écrit :
Anyone willing to review this? I'd like to get it pulled in to
Albert's arm repo ASAP.
I should be able to review it during the week-end--not before,
Anyone willing to review this? I'd like to get it pulled in to
Albert's arm repo ASAP.
Thanks,
Tom
On Wed, Feb 16, 2011 at 1:26 PM, Tom Warren twarren.nvi...@gmail.com wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/cpu/armv7/start.S | 6 +
Hi Tom,
Le 23/02/2011 00:41, Tom Warren a écrit :
Anyone willing to review this? I'd like to get it pulled in to
Albert's arm repo ASAP.
I should be able to review it during the week-end--not before, sorry.
Note however that since this is not a bugfix and it came after the merge
window
13 matches
Mail list logo
