Re: [U-Boot] [PATCH] env: Relocate env drivers if manual reloc is required

2018-04-12 Thread Michal Simek 
Hi,

On 12.4.2018 18:42, Simon Glass wrote:
> Hi Michal,
> 
> On 12 April 2018 at 04:26, Michal Simek  wrote:
>> From: Siva Durga Prasad Paladugu 
>>
>> Relocate env drivers if manual relocation is enabled. This
>> patch fixes the issue of u-boot hang incase if env is
>> present in any of the flash devices.
>>
>> Signed-off-by: Siva Durga Prasad Paladugu 
>> Signed-off-by: Michal Simek 
>> ---
>>
>>  env/common.c  |  1 +
>>  env/env.c | 21 +
>>  include/environment.h |  5 +
>>  3 files changed, 27 insertions(+)
> 
> Reviewed-by: Simon Glass 
> 
> Please see below
> 
>>
>> diff --git a/env/common.c b/env/common.c
>> index f21ff7009695..d282868ee51b 100644
>> --- a/env/common.c
>> +++ b/env/common.c
>> @@ -227,6 +227,7 @@ void env_relocate(void)
>>  {
>>  #if defined(CONFIG_NEEDS_MANUAL_RELOC)
>> env_reloc();
>> +   fix_envdriver();
>> env_htab.change_ok += gd->reloc_off;
>>  #endif
>> if (gd->env_valid == ENV_INVALID) {
>> diff --git a/env/env.c b/env/env.c
>> index 3795dbc24e2b..15a0597100f4 100644
>> --- a/env/env.c
>> +++ b/env/env.c
>> @@ -10,6 +10,27 @@
>>
>>  DECLARE_GLOBAL_DATA_PTR;
>>
>> +#if defined(CONFIG_NEEDS_MANUAL_RELOC)
>> +void fix_envdriver(void)
> 
> How about env_fix_drivers() ? The env_ prefix is nice for something in
> the environment code.
> 
> [..]
> 

v2 sent with name changed.

Thanks,
Michal

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] env: Relocate env drivers if manual reloc is required

2018-04-12 Thread Simon Glass 
Hi Michal,

On 12 April 2018 at 04:26, Michal Simek  wrote:
> From: Siva Durga Prasad Paladugu 
>
> Relocate env drivers if manual relocation is enabled. This
> patch fixes the issue of u-boot hang incase if env is
> present in any of the flash devices.
>
> Signed-off-by: Siva Durga Prasad Paladugu 
> Signed-off-by: Michal Simek 
> ---
>
>  env/common.c  |  1 +
>  env/env.c | 21 +
>  include/environment.h |  5 +
>  3 files changed, 27 insertions(+)

Reviewed-by: Simon Glass 

Please see below

>
> diff --git a/env/common.c b/env/common.c
> index f21ff7009695..d282868ee51b 100644
> --- a/env/common.c
> +++ b/env/common.c
> @@ -227,6 +227,7 @@ void env_relocate(void)
>  {
>  #if defined(CONFIG_NEEDS_MANUAL_RELOC)
> env_reloc();
> +   fix_envdriver();
> env_htab.change_ok += gd->reloc_off;
>  #endif
> if (gd->env_valid == ENV_INVALID) {
> diff --git a/env/env.c b/env/env.c
> index 3795dbc24e2b..15a0597100f4 100644
> --- a/env/env.c
> +++ b/env/env.c
> @@ -10,6 +10,27 @@
>
>  DECLARE_GLOBAL_DATA_PTR;
>
> +#if defined(CONFIG_NEEDS_MANUAL_RELOC)
> +void fix_envdriver(void)

How about env_fix_drivers() ? The env_ prefix is nice for something in
the environment code.

[..]

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot