Re: [U-Boot] [PATCH] spi: Zap mpc8xx_spi driver

2018-11-06 Thread Christophe LEROY 



Le 05/11/2018 à 11:11, Jagan Teki a écrit :

On Fri, Mar 2, 2018 at 3:17 PM Christophe LEROY  wrote:


Le 26/02/2018 à 15:43, Jagan Teki a écrit :

- Driver not used by any boards

This driver should be used by MCR3000 board. For the time
being SPI is not activated on that board because we are struggling
with u-boot size. I'm working on re-activating SPI soon on this board.

I also have another board that I'm planing to include in the near
future. That board stores ethernet addresses in an SPI E2PROM, so this
driver will be mandatory for it.

Therefore, please do not drop it now. It will be converted to DM before
the deadline.

Any patch for this? planning to merge it on MW



MW stands for ... MittWoch, that is Wednesday ?

See serie https://patchwork.ozlabs.org/project/uboot/list/?series=74249

Christophe
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] spi: Zap mpc8xx_spi driver

2018-11-05 Thread Jagan Teki 
On Fri, Mar 2, 2018 at 3:17 PM Christophe LEROY  wrote:
>
>
> Le 26/02/2018 à 15:43, Jagan Teki a écrit :
> > - Driver not used by any boards
>
> This driver should be used by MCR3000 board. For the time
> being SPI is not activated on that board because we are struggling
> with u-boot size. I'm working on re-activating SPI soon on this board.
>
> I also have another board that I'm planing to include in the near
> future. That board stores ethernet addresses in an SPI E2PROM, so this
> driver will be mandatory for it.
>
> Therefore, please do not drop it now. It will be converted to DM before
> the deadline.

Any patch for this? planning to merge it on MW
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] spi: Zap mpc8xx_spi driver

2018-03-02 Thread Christophe LEROY 


Le 26/02/2018 à 15:43, Jagan Teki a écrit :

- Driver not used by any boards


This driver should be used by MCR3000 board. For the time
being SPI is not activated on that board because we are struggling
with u-boot size. I'm working on re-activating SPI soon on this board.

I also have another board that I'm planing to include in the near 
future. That board stores ethernet addresses in an SPI E2PROM, so this

driver will be mandatory for it.

Therefore, please do not drop it now. It will be converted to DM before 
the deadline.


Christophe


- No update on 'dm conversion'

Signed-off-by: Jagan Teki 
---
  drivers/spi/Kconfig  |   6 -
  drivers/spi/Makefile |   1 -
  drivers/spi/mpc8xx_spi.c | 336 ---
  3 files changed, 343 deletions(-)
  delete mode 100644 drivers/spi/mpc8xx_spi.c

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 235a8c7d73..fd3f115ccf 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -274,12 +274,6 @@ config LPC32XX_SSP
help
  Enable support for SPI on LPC32xx
  
-config MPC8XX_SPI

-   bool "MPC8XX SPI Driver"
-   depends on 8xx
-   help
- Enable support for SPI on MPC8XX
-
  config MPC8XXX_SPI
bool "MPC8XXX SPI Driver"
help
diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile
index 4b6000fd9a..f104836630 100644
--- a/drivers/spi/Makefile
+++ b/drivers/spi/Makefile
@@ -31,7 +31,6 @@ obj-$(CONFIG_FSL_QSPI) += fsl_qspi.o
  obj-$(CONFIG_ICH_SPI) +=  ich.o
  obj-$(CONFIG_KIRKWOOD_SPI) += kirkwood_spi.o
  obj-$(CONFIG_LPC32XX_SSP) += lpc32xx_ssp.o
-obj-$(CONFIG_MPC8XX_SPI) += mpc8xx_spi.o
  obj-$(CONFIG_MPC8XXX_SPI) += mpc8xxx_spi.o
  obj-$(CONFIG_MVEBU_A3700_SPI) += mvebu_a3700_spi.o
  obj-$(CONFIG_MXC_SPI) += mxc_spi.o
diff --git a/drivers/spi/mpc8xx_spi.c b/drivers/spi/mpc8xx_spi.c
deleted file mode 100644
index b5bd558526..00
--- a/drivers/spi/mpc8xx_spi.c
+++ /dev/null
@@ -1,336 +0,0 @@
-/*
- * Copyright (c) 2001 Navin Boppuri / Prashant Patel
- * ,
- * 
- * Copyright (c) 2001 Gerd Mennchen 
- * Copyright (c) 2001 Wolfgang Denk, DENX Software Engineering, .
- *
- * SPDX-License-Identifier:GPL-2.0+
- */
-
-/*
- * MPC8xx CPM SPI interface.
- *
- * Parts of this code are probably not portable and/or specific to
- * the board which I used for the tests. Please send fixes/complaints
- * to w...@denx.de
- *
- */
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#define SPI_EEPROM_WREN0x06
-#define SPI_EEPROM_RDSR0x05
-#define SPI_EEPROM_READ0x03
-#define SPI_EEPROM_WRITE   0x02
-
-/* ---
- * Offset for initial SPI buffers in DPRAM:
- * We need a 520 byte scratch DPRAM area to use at an early stage.
- * It is used between the two initialization calls (spi_init_f()
- * and spi_init_r()).
- * The value 0xb00 makes it far enough from the start of the data
- * area (as well as from the stack pointer).
- * --- */
-#ifndefCONFIG_SYS_SPI_INIT_OFFSET
-#defineCONFIG_SYS_SPI_INIT_OFFSET  0xB00
-#endif
-
-#define CPM_SPI_BASE_RXCPM_SPI_BASE
-#define CPM_SPI_BASE_TX(CPM_SPI_BASE + sizeof(cbd_t))
-
-/* ---
- * Function prototypes
- * --- */
-ssize_t spi_xfer(size_t);
-
-/* ---
- * Variables
- * --- */
-
-#define MAX_BUFFER 0x104
-
-/* --
- * Initially we place the RX and TX buffers at a fixed location in DPRAM!
- * -- */
-static uchar *rxbuf =
-   (uchar *)&((cpm8xx_t *)&((immap_t *)CONFIG_SYS_IMMR)->im_cpm)->cp_dpmem
-   [CONFIG_SYS_SPI_INIT_OFFSET];
-static uchar *txbuf =
-   (uchar *)&((cpm8xx_t *)&((immap_t *)CONFIG_SYS_IMMR)->im_cpm)->cp_dpmem
-   [CONFIG_SYS_SPI_INIT_OFFSET+MAX_BUFFER];
-
-/* **
- *
- *  Function:spi_init_f
- *
- *  Description: Init SPI-Controller (ROM part)
- *
- *  return:  ---
- *
- * *** */
-void spi_init_f(void)
-{
-   immap_t __iomem *immr = (immap_t __iomem *)CONFIG_SYS_IMMR;
-   cpm8xx_t __iomem *cp = >im_cpm;
-   spi_t __iomem *spi = (spi_t __iomem *)>cp_dparam[PROFF_SPI];
-   cbd_t __iomem *tbdf, *rbdf;
-
-   /* Disable relocation */
-   out_be16(>spi_rpbase, 0);
-
-/* 1 */
-   /* 
-* Initialize Port B SPI pins -> page 34-8 MPC860UM
-* (we are only in Master Mode

Re: [U-Boot] [PATCH] spi: Zap mpc8xx_spi driver

2018-02-26 Thread Tom Rini 
On Mon, Feb 26, 2018 at 08:13:11PM +0530, Jagan Teki wrote:

> - Driver not used by any boards
> - No update on 'dm conversion'
> 
> Signed-off-by: Jagan Teki 

Reviewed-by: Tom Rini 

Christophe?

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot