Re: [U-Boot] [PATCH] test/py: gpt: Use long options for sgdisk
On Tue, Jul 02, 2019 at 09:20:32PM +0300, Sam Protsenko wrote: > sgdisk 0.8.10.2 from AOSP doesn't support short options, failing with > errors like this: > > sgdisk: invalid option -- 'U' > > Test fails due to that error. Let's use long options to make the test > work with any sgdisk version. > > Signed-off-by: Sam Protsenko > Acked-by: Stephen Warren Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] test/py: gpt: Use long options for sgdisk
Hi Stephen, On Tue, Jul 2, 2019 at 9:35 PM Stephen Warren wrote: > > On 7/2/19 12:20 PM, Sam Protsenko wrote: > > sgdisk 0.8.10.2 from AOSP doesn't support short options, failing with > > errors like this: > > > > sgdisk: invalid option -- 'U' > > > > Test fails due to that error. Let's use long options to make the test > > work with any sgdisk version. > > Acked-by: Stephen Warren > > ... but I do wonder how you're running this on AOSP; surely this can't > be the only issue that prevents U-Boot building and test/py from running? I just happened to have AOSP out/ and prebuilt/ directories in the beginning of my $PATH env var, in order to use most recent adb and fastboot. And sgdisk is also present there, that's how I ended up running U-Boot tests using sgdisk from AOSP :) Everything else is executing without errors. So I figured, why don't fix this case, if we can keep tests working with any sgdisk version. But yeah, this is the minor fix. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH] test/py: gpt: Use long options for sgdisk
On 7/2/19 12:20 PM, Sam Protsenko wrote: sgdisk 0.8.10.2 from AOSP doesn't support short options, failing with errors like this: sgdisk: invalid option -- 'U' Test fails due to that error. Let's use long options to make the test work with any sgdisk version. Acked-by: Stephen Warren ... but I do wonder how you're running this on AOSP; surely this can't be the only issue that prevents U-Boot building and test/py from running? ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot