Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Sandy Patterson]

>
> 1) It seems the BACK_TO_BROM feature is broken. It doesn't boot using the
>> 2016.09. I'm afraid I don't have the time to track it down.
>>
> It works fine on my evb, do you flash the image correctly? it's different
> with the way you don't use BACK_TO_BROM.
>

Well, I tested again on the latest master branch and its working now. I
probably had something screwed up. I did notice that the BACK_TO_BROM was
moved to Kconfig.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Kever Yang]

Hi Sandy,

On 09/19/2016 09:33 PM, Sandy Patterson wrote:

Hi Kever and Vagrant,

I tested this patch on my rock2 board against 2016.09. (I didn't have 
my board with me over the weekend)


Thanks for your test and for your log, my source code do have one bug 
and I have fix and upload the V2 patch set.




1) It seems the BACK_TO_BROM feature is broken. It doesn't boot using 
the 2016.09. I'm afraid I don't have the time to track it down.
It works fine on my evb, do you flash the image correctly? it's 
different with the way you don't use BACK_TO_BROM.


Regards,
- Kever
2) It seems the SPL is still small enough to test this feature. 
(vagrant you can forget about the back to brom feature unless you need 
more SPL space).


3) I get the same behavior as Vagrant on the rock2 board. I'm 
including DEBUG output in case that helps Kever. I tried to trace it, 
but it seems a larger undertaking than I can manage right now. 
(vagrant, you can add DEBUG #define's into the 
file include/configs/firefly-rk3288.h to get the output below.. my 
guess is it's similar.)


This trace is almost exactly the same between enabling the SDRAM 
detection and not. I marked the point where it halts. The fdt is a 
slightly different size, but that is expected.


Sandy


initcall: 0010af55
U-Boot code: 0010 -> 0014F8C0  BSS: -> 0018D1B8
initcall: 0010add1
initcall: 0010b359
Model: Radxa Rock 2 Square
initcall: 0010af95
DRAM:  initcall: 00100d19
malloc_simple: size=3c, ptr=7d8, limit=2000: fe79c
uclass_find_device_by_seq: 0 -1
uclass_find_device_by_seq: 0 0
   - -1 -1
   - not found
fdtdec_get_int_array: interrupts
get_prop_check_min_len: interrupts
malloc_simple: size=4, ptr=7dc, limit=2000: fe7d8
uclass_find_device_by_seq: 0 -1
uclass_find_device_by_seq: 0 0
   - -1 1
   - -1 -1
   - -1 0
   - found
uclass_find_device_by_seq: 0 1
   - -1 1
   - found
uclass_find_device_by_seq: 0 2
   - -1 1
   - -1 -1
   - -1 0
   - -1 -1
   - not found
fdtdec_get_int_array: interrupts
get_prop_check_min_len: interrupts
malloc_simple: size=14, ptr=7f0, limit=2000: fe7dc
malloc_simple: size=4, ptr=7f4, limit=2000: fe7f0
uclass_find_device_by_seq: 0 -1
uclass_find_device_by_seq: 0 0
   - -1 1
   - -1 -1
   - -1 0
   - found
uclass_find_device_by_seq: 0 1
   - -1 1
   - found
uclass_find_device_by_seq: 0 2
   - -1 1
   - -1 -1
   - -1 0
   - -1 2
   - found
uclass_find_device_by_seq: 0 3
   - -1 1
   - -1 -1
   - -1 0
   - -1 2
   - not found
fdtdec_get_int_array: interrupts
get_prop_check_min_len: interrupts
malloc_simple: size=14, ptr=808, limit=2000: fe7f4
malloc_simple: size=c, ptr=814, limit=2000: fe808
uclass_find_device_by_seq: 0 -1
uclass_find_device_by_seq: 0 0
   - -1 -1
   - not found
fdtdec_get_int_array: interrupts
get_prop_check_min_len: interrupts
OF: ** translation for device clock-controller@ff76 **
OF: bus is default (na=1, ns=1) on
OF: translating address: 76ff
OF: reached root node
clk_request(dev=000fe474, clk=000fe7bc)
SDRAM base=0, size=8000
initcall: 0010b129
Monitor len: 0008D1B8
Ram size: 8000
Ram top: 8000
initcall: 0010adf1
initcall: 0010af0d
TLB table from 7fff to 7fff4000
initcall: 0010af75
video_reserve: Reserving 4f bytes at 7fb0 for video device 
'vop@ff94'

Video frame buffers from 7fb0 to 7fff
initcall: 0010ae05
initcall: 0010aecd
Reserving 564k for U-Boot at: 7fa72000
initcall: 0010aea5
Reserving 32776k for malloc() at: 7da7
initcall: 0010b059
Reserving 80 Bytes for Board Info at: 7da6ffb0
initcall: 0010ae09
initcall: 0010ae7d
Reserving 200 Bytes for Global Data at: 7da6fee8
initcall: 0010ae2d
Reserving 38464 Bytes for FDT at: 7da668a8
initcall: 0010ae11
initcall: 0010b18d
initcall: 0010b113
initcall: 0010b099

RAM Configuration:
== SDRAM DETECTION FEATURE HALTS HERE 
Bank #0: 0 2 GiB

DRAM:  2 GiB
initcall: 0010ae19
New Stack Pointer is: 7da66880
initcall: 0010b02d
initcall: 0010afd5
Relocation Offset is: 7f972000
Relocating to 7fa72000, new gd at 7da6fee8, sp at 7da66880
initcall: 7fa7d1cd
initcall: 7fa7d1d1
initcall: 0010b32d (relocated to 7fa7d32d)
dram_bank_mmu_setup: bank: 0
initcall: 0010b305 (relocated to 7fa7d305)
efi_runtime_relocate: Relocating to offset=7fa72000




___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Sandy Patterson]

Hi Kever and Vagrant,

I tested this patch on my rock2 board against 2016.09. (I didn't have my
board with me over the weekend)

1) It seems the BACK_TO_BROM feature is broken. It doesn't boot using the
2016.09. I'm afraid I don't have the time to track it down.
2) It seems the SPL is still small enough to test this feature. (vagrant
you can forget about the back to brom feature unless you need more SPL
space).

3) I get the same behavior as Vagrant on the rock2 board. I'm including
DEBUG output in case that helps Kever. I tried to trace it, but it seems a
larger undertaking than I can manage right now. (vagrant, you can add DEBUG
#define's into the file include/configs/firefly-rk3288.h to get the output
below.. my guess is it's similar.)

This trace is almost exactly the same between enabling the SDRAM detection
and not. I marked the point where it halts. The fdt is a slightly different
size, but that is expected.

Sandy


initcall: 0010af55
U-Boot code: 0010 -> 0014F8C0  BSS: -> 0018D1B8
initcall: 0010add1
initcall: 0010b359
Model: Radxa Rock 2 Square
initcall: 0010af95
DRAM:  initcall: 00100d19
malloc_simple: size=3c, ptr=7d8, limit=2000: fe79c
uclass_find_device_by_seq: 0 -1
uclass_find_device_by_seq: 0 0
   - -1 -1
   - not found
fdtdec_get_int_array: interrupts
get_prop_check_min_len: interrupts
malloc_simple: size=4, ptr=7dc, limit=2000: fe7d8
uclass_find_device_by_seq: 0 -1
uclass_find_device_by_seq: 0 0
   - -1 1
   - -1 -1
   - -1 0
   - found
uclass_find_device_by_seq: 0 1
   - -1 1
   - found
uclass_find_device_by_seq: 0 2
   - -1 1
   - -1 -1
   - -1 0
   - -1 -1
   - not found
fdtdec_get_int_array: interrupts
get_prop_check_min_len: interrupts
malloc_simple: size=14, ptr=7f0, limit=2000: fe7dc
malloc_simple: size=4, ptr=7f4, limit=2000: fe7f0
uclass_find_device_by_seq: 0 -1
uclass_find_device_by_seq: 0 0
   - -1 1
   - -1 -1
   - -1 0
   - found
uclass_find_device_by_seq: 0 1
   - -1 1
   - found
uclass_find_device_by_seq: 0 2
   - -1 1
   - -1 -1
   - -1 0
   - -1 2
   - found
uclass_find_device_by_seq: 0 3
   - -1 1
   - -1 -1
   - -1 0
   - -1 2
   - not found
fdtdec_get_int_array: interrupts
get_prop_check_min_len: interrupts
malloc_simple: size=14, ptr=808, limit=2000: fe7f4
malloc_simple: size=c, ptr=814, limit=2000: fe808
uclass_find_device_by_seq: 0 -1
uclass_find_device_by_seq: 0 0
   - -1 -1
   - not found
fdtdec_get_int_array: interrupts
get_prop_check_min_len: interrupts
OF: ** translation for device clock-controller@ff76 **
OF: bus is default (na=1, ns=1) on
OF: translating address: 76ff
OF: reached root node
clk_request(dev=000fe474, clk=000fe7bc)
SDRAM base=0, size=8000
initcall: 0010b129
Monitor len: 0008D1B8
Ram size: 8000
Ram top: 8000
initcall: 0010adf1
initcall: 0010af0d
TLB table from 7fff to 7fff4000
initcall: 0010af75
video_reserve: Reserving 4f bytes at 7fb0 for video device
'vop@ff94'
Video frame buffers from 7fb0 to 7fff
initcall: 0010ae05
initcall: 0010aecd
Reserving 564k for U-Boot at: 7fa72000
initcall: 0010aea5
Reserving 32776k for malloc() at: 7da7
initcall: 0010b059
Reserving 80 Bytes for Board Info at: 7da6ffb0
initcall: 0010ae09
initcall: 0010ae7d
Reserving 200 Bytes for Global Data at: 7da6fee8
initcall: 0010ae2d
Reserving 38464 Bytes for FDT at: 7da668a8
initcall: 0010ae11
initcall: 0010b18d
initcall: 0010b113
initcall: 0010b099

RAM Configuration:
== SDRAM DETECTION FEATURE HALTS HERE 
Bank #0: 0 2 GiB

DRAM:  2 GiB
initcall: 0010ae19
New Stack Pointer is: 7da66880
initcall: 0010b02d
initcall: 0010afd5
Relocation Offset is: 7f972000
Relocating to 7fa72000, new gd at 7da6fee8, sp at 7da66880
initcall: 7fa7d1cd
initcall: 7fa7d1d1
initcall: 0010b32d (relocated to 7fa7d32d)
dram_bank_mmu_setup: bank: 0
initcall: 0010b305 (relocated to 7fa7d305)
efi_runtime_relocate: Relocating to offset=7fa72000
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Vagrant Cascadian]

On 2016-09-15, Sandy Patterson wrote:
> An alternative for you might be to disable OF_PLATDATA for firefly and
> enable BACK_TO_BROM.

I wasn't able to successfully build with OF_PLATDATA disabled; sounds
like there are more patches needed for firefly for that to work.


> You may not be getting any output because you didn't modify your burning
> process.
> See the README.rockchip section on CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
> for details, but you have to dd your images slightly differently with this
> macro enabled.

Thanks! Unfortunately, even after using the burning process for
CONFIG_ROCKCHIP_SPL_BACK_TO_BROM described in README.rockchip.

The patches (on top of what was submitted in this series) I've applied
to v2016.09 are:

Index: u-boot/include/common.h
===
--- u-boot.orig/include/common.h
+++ u-boot/include/common.h
@@ -95,6 +95,10 @@ typedef volatile unsigned char   vu_char;
 #define CONFIG_SYS_SUPPORT_64BIT_DATA
 #endif
 
+#ifndef CONFIG_SPL_BUILD
+#define DEBUG
+#endif
+
 #ifdef DEBUG
 #define _DEBUG 1
 #else

Index: u-boot/arch/arm/mach-rockchip/rk3288/sdram_rk3288.c
===
--- u-boot.orig/arch/arm/mach-rockchip/rk3288/sdram_rk3288.c
+++ u-boot/arch/arm/mach-rockchip/rk3288/sdram_rk3288.c
@@ -1039,7 +1039,7 @@ static int conv_of_platdata(struct udevi
memcpy(>phy_timing, of_plat->rockchip_phy_timing,
   sizeof(plat->phy_timing));
memcpy(>base, of_plat->rockchip_sdram_params, sizeof(plat->base));
-   plat->num_channels = of_plat->rockchip_num_channels;
+   plat->num_channels = 2;
ret = regmap_init_mem_platdata(dev, of_plat->reg,
   ARRAY_SIZE(of_plat->reg) / 2,
   >map);

Index: u-boot/configs/firefly-rk3288_defconfig
===
--- u-boot.orig/configs/firefly-rk3288_defconfig
+++ u-boot/configs/firefly-rk3288_defconfig
@@ -70,3 +70,4 @@ CONFIG_USE_TINY_PRINTF=y
 CONFIG_CMD_DHRYSTONE=y
 CONFIG_ERRNO_STR=y
 # CONFIG_SPL_OF_LIBFDT is not set
+CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y


I think I'll wait for an updated series to do more tests, so I'm not
testing patches on patches on patches. Also reduces the liklihood of me
misinterpreting what people are suggesting to try.


live well,
  vagrant


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Kever Yang]

Hi Sandy Patterson,

On 09/15/2016 08:00 PM, Sandy Patterson wrote:

Hi Kever,

With regards to the SPL size issue, I believe that the
CONFIG_ROCKCHIP_SPL_BACK_TO_BROM option should work with
all of the rk3288 boards. So if your patch causes unbootable SPL's because
they're too big, then you should probably enable the BROM macro (and 
disable OF_PLATDATA).


Firefly uses a different method to shrink the SPL which causes a bunch 
of changes
throughout the codebase. This patch would need to be applied to the 
OF_PLATDATA

sections for firefly to work.


Thanks for your comment, I will update a V2 patch after I make sure it 
works with other board,

but I don't have a firefly on my hand currently.

I think you mean my patch need to work with:
- BROM enabled and OF_PLATDATA disabled
- BROM disabled and OF_PLATDATA enabled
right?



Vagrant,

An alternative for you might be to disable OF_PLATDATA for firefly and 
enable BACK_TO_BROM.
You may not be getting any output because you didn't modify your 
burning process.

See the README.rockchip section on CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
for details, but you have to dd your images slightly differently with 
this macro enabled.


Also, you might get more info from Ziyuan's DEBUG advice.


Hi Vagrant,

Once you see the SPL output message, that means the DRAM init is 
OK, to double check if the DRAM
init correct, you can add log for return value of sdram_size_mb() after 
apply my patch.


Thanks,
- Kever


Sandy Patterson


On Sun, Sep 11, 2016 at 10:01 PM, Ziyuan Xu > wrote:


hi Vagrant,



On 2016年09月11日 03:01, Vagrant Cascadian wrote:

On 2016-09-10, Ziyuan Xu wrote:

On 2016年09月09日 03:28, Vagrant Cascadian wrote:

On 2016-09-08, Kever Yang wrote:

The rk3288 spl size is very close to 32KB while
the rk3288 bootrom
has the limitation of maximum size of SPL is 32KB.
After apply this
patch, the SPL size will exceed 32KB if we do not
enable macro
CONFIG_ROCKCHIP_SPL_BACK_TO_BROM.

With CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y, it fails to boot with
no output
on the console.


This patch has test with 2GB DDR3 and 2GB/4GB LPDDR3.

Thanks for the patch!

Unfortunately, fails to build the firefly-rk3288
target, using
arm-linux-gnueabihf-gcc (Debian 6.1.1-9) 6.1.1
20160705, applied to
u-boot master 01c5075506afcb7a74e0db8600af8979f45881b5:

CC 
spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o

arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function
'conv_of_platdata':
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1042:30:
error: 'struct
dtd_rockchip_rk3288_dmc' has no member named
'rockchip_num_channels';
did you mean 'rockchip_noc'?
plat->num_channels = of_plat->rockchip_num_channels;

-   plat->num_channels = of_plat->rockchip_num_channels;
+   plat->num_channels = 2;

firefly-rk3288 deploy CONFIG_OF_PLATDATA,  driver read
platform data
from include/generated/dt-structs.h which is generated
according to dts
file.
Please try above change.

With this change, it builds, but it hangs at boot:

   U-Boot SPL 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 -
18:51:28)
   Trying to boot from MMC1


   U-Boot 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 -
18:51:28 +)

   Model: Firefly-RK3288
   DRAM:


Could you help to add DEBUG macro in common.h like:
#indef CONFIG_SPL_BUILD
#define DEBUG
#endif

So that we can figure out where it is.



This is on a firefly with 2GB of ram. I also have one with 4GB
of ram,
hence my interest in this patch series!


live well,
   vagrant






___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Sandy Patterson]

Hi Kever,

With regards to the SPL size issue, I believe that the
CONFIG_ROCKCHIP_SPL_BACK_TO_BROM option should work with
all of the rk3288 boards. So if your patch causes unbootable SPL's because
they're too big, then you should probably enable the BROM macro (and
disable OF_PLATDATA).

Firefly uses a different method to shrink the SPL which causes a bunch of
changes
throughout the codebase. This patch would need to be applied to the
OF_PLATDATA
sections for firefly to work.

Vagrant,

An alternative for you might be to disable OF_PLATDATA for firefly and
enable BACK_TO_BROM.
You may not be getting any output because you didn't modify your burning
process.
See the README.rockchip section on CONFIG_ROCKCHIP_SPL_BACK_TO_BROM
for details, but you have to dd your images slightly differently with this
macro enabled.

Also, you might get more info from Ziyuan's DEBUG advice.

Sandy Patterson


On Sun, Sep 11, 2016 at 10:01 PM, Ziyuan Xu  wrote:

> hi Vagrant,
>
>
>
> On 2016年09月11日 03:01, Vagrant Cascadian wrote:
>
>> On 2016-09-10, Ziyuan Xu wrote:
>>
>>> On 2016年09月09日 03:28, Vagrant Cascadian wrote:
>>>
 On 2016-09-08, Kever Yang wrote:

> The rk3288 spl size is very close to 32KB while the rk3288 bootrom
> has the limitation of maximum size of SPL is 32KB. After apply this
> patch, the SPL size will exceed 32KB if we do not enable macro
> CONFIG_ROCKCHIP_SPL_BACK_TO_BROM.
>
 With CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y, it fails to boot with no
>> output
>> on the console.
>>
>>
>> This patch has test with 2GB DDR3 and 2GB/4GB LPDDR3.
>
 Thanks for the patch!

 Unfortunately, fails to build the firefly-rk3288 target, using
 arm-linux-gnueabihf-gcc (Debian 6.1.1-9) 6.1.1 20160705, applied to
 u-boot master 01c5075506afcb7a74e0db8600af8979f45881b5:

 CC  spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o
 arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function
 'conv_of_platdata':
 arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1042:30: error: 'struct
 dtd_rockchip_rk3288_dmc' has no member named
 'rockchip_num_channels';
 did you mean 'rockchip_noc'?
 plat->num_channels = of_plat->rockchip_num_channels;

>>> -   plat->num_channels = of_plat->rockchip_num_channels;
>>> +   plat->num_channels = 2;
>>>
>>> firefly-rk3288 deploy CONFIG_OF_PLATDATA,  driver read platform data
>>> from include/generated/dt-structs.h which is generated according to dts
>>> file.
>>> Please try above change.
>>>
>> With this change, it builds, but it hangs at boot:
>>
>>U-Boot SPL 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 - 18:51:28)
>>Trying to boot from MMC1
>>
>>
>>U-Boot 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 - 18:51:28 +)
>>
>>Model: Firefly-RK3288
>>DRAM:
>>
>
> Could you help to add DEBUG macro in common.h like:
> #indef CONFIG_SPL_BUILD
> #define DEBUG
> #endif
>
> So that we can figure out where it is.
>
>
>
>> This is on a firefly with 2GB of ram. I also have one with 4GB of ram,
>> hence my interest in this patch series!
>>
>>
>> live well,
>>vagrant
>>
>
>
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Ziyuan Xu]

hi Vagrant,


On 2016年09月11日 03:01, Vagrant Cascadian wrote:

On 2016-09-10, Ziyuan Xu wrote:

On 2016年09月09日 03:28, Vagrant Cascadian wrote:

On 2016-09-08, Kever Yang wrote:

The rk3288 spl size is very close to 32KB while the rk3288 bootrom
has the limitation of maximum size of SPL is 32KB. After apply this
patch, the SPL size will exceed 32KB if we do not enable macro
CONFIG_ROCKCHIP_SPL_BACK_TO_BROM.

With CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y, it fails to boot with no output
on the console.



This patch has test with 2GB DDR3 and 2GB/4GB LPDDR3.

Thanks for the patch!

Unfortunately, fails to build the firefly-rk3288 target, using
arm-linux-gnueabihf-gcc (Debian 6.1.1-9) 6.1.1 20160705, applied to
u-boot master 01c5075506afcb7a74e0db8600af8979f45881b5:

CC  spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function
'conv_of_platdata':
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1042:30: error: 'struct
dtd_rockchip_rk3288_dmc' has no member named 'rockchip_num_channels';
did you mean 'rockchip_noc'?
plat->num_channels = of_plat->rockchip_num_channels;

-   plat->num_channels = of_plat->rockchip_num_channels;
+   plat->num_channels = 2;

firefly-rk3288 deploy CONFIG_OF_PLATDATA,  driver read platform data
from include/generated/dt-structs.h which is generated according to dts
file.
Please try above change.

With this change, it builds, but it hangs at boot:

   U-Boot SPL 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 - 18:51:28)
   Trying to boot from MMC1


   U-Boot 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 - 18:51:28 +)

   Model: Firefly-RK3288
   DRAM:


Could you help to add DEBUG macro in common.h like:
#indef CONFIG_SPL_BUILD
#define DEBUG
#endif

So that we can figure out where it is.



This is on a firefly with 2GB of ram. I also have one with 4GB of ram,
hence my interest in this patch series!


live well,
   vagrant



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Vagrant Cascadian]

On 2016-09-10, Ziyuan Xu wrote:
> On 2016年09月09日 03:28, Vagrant Cascadian wrote:
>> On 2016-09-08, Kever Yang wrote:
>>> The rk3288 spl size is very close to 32KB while the rk3288 bootrom
>>> has the limitation of maximum size of SPL is 32KB. After apply this
>>> patch, the SPL size will exceed 32KB if we do not enable macro
>>> CONFIG_ROCKCHIP_SPL_BACK_TO_BROM.

With CONFIG_ROCKCHIP_SPL_BACK_TO_BROM=y, it fails to boot with no output
on the console.


>>> This patch has test with 2GB DDR3 and 2GB/4GB LPDDR3.
>> Thanks for the patch!
>>
>> Unfortunately, fails to build the firefly-rk3288 target, using
>> arm-linux-gnueabihf-gcc (Debian 6.1.1-9) 6.1.1 20160705, applied to
>> u-boot master 01c5075506afcb7a74e0db8600af8979f45881b5:
>>
>>CC  spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o
>> arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function
>>'conv_of_platdata':
>> arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1042:30: error: 'struct
>>dtd_rockchip_rk3288_dmc' has no member named 'rockchip_num_channels';
>>did you mean 'rockchip_noc'?
>>plat->num_channels = of_plat->rockchip_num_channels;
>
> -   plat->num_channels = of_plat->rockchip_num_channels;
> +   plat->num_channels = 2;
>
> firefly-rk3288 deploy CONFIG_OF_PLATDATA,  driver read platform data
> from include/generated/dt-structs.h which is generated according to dts
> file.
> Please try above change.

With this change, it builds, but it hangs at boot:

  U-Boot SPL 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 - 18:51:28)
  Trying to boot from MMC1


  U-Boot 2016.09-rc2+dfsg1-2~20160910~6 (Sep 10 2016 - 18:51:28 +)

  Model: Firefly-RK3288
  DRAM:

This is on a firefly with 2GB of ram. I also have one with 4GB of ram,
hence my interest in this patch series!


live well,
  vagrant


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Ziyuan Xu]

hi Vagrant,


On 2016年09月09日 03:28, Vagrant Cascadian wrote:

On 2016-09-08, Kever Yang wrote:

The rk3288 spl size is very close to 32KB while the rk3288 bootrom
has the limitation of maximum size of SPL is 32KB. After apply this
patch, the SPL size will exceed 32KB if we do not enable macro
CONFIG_ROCKCHIP_SPL_BACK_TO_BROM.

I think this patch is usful and should be go upstream other than the
size issue.

This patch has test with 2GB DDR3 and 2GB/4GB LPDDR3.

Thanks for the patch!

Unfortunately, fails to build the firefly-rk3288 target, using
arm-linux-gnueabihf-gcc (Debian 6.1.1-9) 6.1.1 20160705, applied to
u-boot master 01c5075506afcb7a74e0db8600af8979f45881b5:

   CC  spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function
   'conv_of_platdata':
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1042:30: error: 'struct
   dtd_rockchip_rk3288_dmc' has no member named 'rockchip_num_channels';
   did you mean 'rockchip_noc'?
   plat->num_channels = of_plat->rockchip_num_channels;


-   plat->num_channels = of_plat->rockchip_num_channels;
+   plat->num_channels = 2;

firefly-rk3288 deploy CONFIG_OF_PLATDATA,  driver read platform data 
from include/generated/dt-structs.h which is generated according to dts 
file.

Please try above change.

@Kever,

Please fix below.

arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function 
‘conv_of_platdata’:
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1035:6: warning: unused 
variable ‘i’ [-Wunused-variable]




   ^~
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1035:6: warning: unused
   variable 'i' [-Wunused-variable]
   int i, ret;
   ^
scripts/Makefile.build:280: recipe for target
   'spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o' failed
make[3]: *** [spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o] Error 1
scripts/Makefile.build:425: recipe for target
   'spl/arch/arm/mach-rockchip/rk3288' failed
make[2]: *** [spl/arch/arm/mach-rockchip/rk3288] Error 2
scripts/Makefile.spl:292: recipe for target 'spl/arch/arm/mach-rockchip'
   failed
make[1]: *** [spl/arch/arm/mach-rockchip] Error 2
Makefile:1334: recipe for target 'spl/u-boot-spl' failed
make: *** [spl/u-boot-spl] Error 2


live well,
   vagrant



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/2] Add sdram capacity auto detect for rk3288

[Vagrant Cascadian]

On 2016-09-08, Kever Yang wrote:
> The rk3288 spl size is very close to 32KB while the rk3288 bootrom
> has the limitation of maximum size of SPL is 32KB. After apply this
> patch, the SPL size will exceed 32KB if we do not enable macro
> CONFIG_ROCKCHIP_SPL_BACK_TO_BROM.
>
> I think this patch is usful and should be go upstream other than the
> size issue.
>
> This patch has test with 2GB DDR3 and 2GB/4GB LPDDR3.

Thanks for the patch!

Unfortunately, fails to build the firefly-rk3288 target, using
arm-linux-gnueabihf-gcc (Debian 6.1.1-9) 6.1.1 20160705, applied to
u-boot master 01c5075506afcb7a74e0db8600af8979f45881b5:

  CC  spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function
  'conv_of_platdata':
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1042:30: error: 'struct
  dtd_rockchip_rk3288_dmc' has no member named 'rockchip_num_channels';
  did you mean 'rockchip_noc'?
  plat->num_channels = of_plat->rockchip_num_channels;
  ^~
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1035:6: warning: unused
  variable 'i' [-Wunused-variable]
  int i, ret;
  ^
scripts/Makefile.build:280: recipe for target
  'spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o' failed
make[3]: *** [spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o] Error 1
scripts/Makefile.build:425: recipe for target
  'spl/arch/arm/mach-rockchip/rk3288' failed
make[2]: *** [spl/arch/arm/mach-rockchip/rk3288] Error 2
scripts/Makefile.spl:292: recipe for target 'spl/arch/arm/mach-rockchip'
  failed
make[1]: *** [spl/arch/arm/mach-rockchip] Error 2
Makefile:1334: recipe for target 'spl/u-boot-spl' failed
make: *** [spl/u-boot-spl] Error 2


live well,
  vagrant


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot