Re: [U-Boot] [PATCH 04/17] mvebu: Add board_pex_config()

[Dirk Eibach]

2016-12-01 9:30 GMT+01:00 Stefan Roese :
> On 23.11.2016 16:12, Mario Six wrote:
>>
>> Allow boards to do some initialization when PCIe comes up.
>
>
> What is it that your boards needs to do when PCIe comes up? Could
> you please give me an example here?

You might have a look at Patch 00 of this series. We have a quirky
FPGA as a PCIe device that needs some special treamtment when PCIe is
is coming up.

> ...
>> +void __board_pex_config(void)
>> +{
>> +   /* nothing in this weak default implementation */
>> +}
>> +void board_pex_config(void)
>> +   __attribute__((weak, alias("__board_pex_config")));
>> +
>
>
> Its easier to use this syntax instead:
>
> __weak board_pex_config(void)
> ...
>
> You don't need to add the __attribute this way.

Mario could you take car of this in V2?

Cheers
Dirk
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 04/17] mvebu: Add board_pex_config()

[Stefan Roese]

On 23.11.2016 16:12, Mario Six wrote:

Allow boards to do some initialization when PCIe comes up.


What is it that your boards needs to do when PCIe comes up? Could
you please give me an example here?


Signed-off-by: Dirk Eibach 
---
 arch/arm/mach-mvebu/serdes/a38x/ctrl_pex.c | 10 ++
 arch/arm/mach-mvebu/serdes/a38x/ctrl_pex.h |  2 ++
 2 files changed, 12 insertions(+)

diff --git a/arch/arm/mach-mvebu/serdes/a38x/ctrl_pex.c 
b/arch/arm/mach-mvebu/serdes/a38x/ctrl_pex.c
index 98c447c..2b85e6e 100644
--- a/arch/arm/mach-mvebu/serdes/a38x/ctrl_pex.c
+++ b/arch/arm/mach-mvebu/serdes/a38x/ctrl_pex.c
@@ -13,6 +13,13 @@
 #include "ctrl_pex.h"
 #include "sys_env_lib.h"

+void __board_pex_config(void)
+{
+   /* nothing in this weak default implementation */
+}
+void board_pex_config(void)
+   __attribute__((weak, alias("__board_pex_config")));
+


Its easier to use this syntax instead:

__weak board_pex_config(void)
...

You don't need to add the __attribute this way.

Thanks,
Stefan
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot