Re: [U-Boot] [PATCH 05/82] console: Don't enable CONFIG-CONSOLE_MUX, etc. in SPL

2016-10-17 Thread Simon Glass 
Hi Bin,

On 10 October 2016 at 21:15, Bin Meng  wrote:
> Hi Simon,
>
> Typo of CONFIG-CONSOLE_MUX in the commit title.
>
> On Mon, Sep 26, 2016 at 11:33 AM, Simon Glass  wrote:
>> CONFIG_CONSOLE_MUX and CONFIG_SYS_CONSOLE_IS_IN_ENV are not applicable
>> for SPL. Update the console code to use CONFIG_IS_ENABLED(), so that these
>> options will be inactive in SPL.
>
> I don't understand, what's the difference between CONFIG_IS_ENABLE() and 
> #ifdef?

CONFIG_IS_ENABLED() can have a different value for SPL and U-Boot
proper. It uses CONFIG_xxx or CONFIG_SPL_xxx depending on which is
being built.

>
>>
>> Signed-off-by: Simon Glass 
>> ---
>>
>>  common/console.c | 30 +++---
>>  1 file changed, 15 insertions(+), 15 deletions(-)

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 05/82] console: Don't enable CONFIG-CONSOLE_MUX, etc. in SPL

2016-10-10 Thread Bin Meng 
Hi Simon,

Typo of CONFIG-CONSOLE_MUX in the commit title.

On Mon, Sep 26, 2016 at 11:33 AM, Simon Glass  wrote:
> CONFIG_CONSOLE_MUX and CONFIG_SYS_CONSOLE_IS_IN_ENV are not applicable
> for SPL. Update the console code to use CONFIG_IS_ENABLED(), so that these
> options will be inactive in SPL.

I don't understand, what's the difference between CONFIG_IS_ENABLE() and #ifdef?

>
> Signed-off-by: Simon Glass 
> ---
>
>  common/console.c | 30 +++---
>  1 file changed, 15 insertions(+), 15 deletions(-)
>

[snip]

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot