Re: [U-Boot] [PATCH 08/27] spl: Add a way to declare an SPL image loader

[Simon Glass]

Hi Tom,

On 18 September 2016 at 16:15, Tom Rini  wrote:
> On Sun, Sep 18, 2016 at 01:44:57PM -0600, Simon Glass wrote:
>> Add a linker list macro which can be used to declare an SPL image loader.
>> Update spl_load_image() to search available loaders for the correct one.
>>
>> Signed-off-by: Simon Glass 
>> ---
>>
>>  common/spl/spl.c | 20 
>>  include/spl.h| 32 
>>  2 files changed, 52 insertions(+)
>>
>> diff --git a/common/spl/spl.c b/common/spl/spl.c
>> index 3716e6a..719ae6e 100644
>> --- a/common/spl/spl.c
>> +++ b/common/spl/spl.c
>> @@ -344,12 +344,32 @@ static void announce_boot_device(u32 boot_device)
>>  static inline void announce_boot_device(u32 boot_device) { }
>>  #endif
>>
>> +static struct spl_image_loader *spL_find_loader(uint boot_device)
>
> I don't like spL here, I mis-read that as a typo the second time I saw
> it.  Maybe a function comment and spl_ll_find_loader ?

Oops that was a typo. Fixed, thanks.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 08/27] spl: Add a way to declare an SPL image loader

[Tom Rini]

On Sun, Sep 18, 2016 at 01:44:57PM -0600, Simon Glass wrote:
> Add a linker list macro which can be used to declare an SPL image loader.
> Update spl_load_image() to search available loaders for the correct one.
> 
> Signed-off-by: Simon Glass 
> ---
> 
>  common/spl/spl.c | 20 
>  include/spl.h| 32 
>  2 files changed, 52 insertions(+)
> 
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index 3716e6a..719ae6e 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -344,12 +344,32 @@ static void announce_boot_device(u32 boot_device)
>  static inline void announce_boot_device(u32 boot_device) { }
>  #endif
>  
> +static struct spl_image_loader *spL_find_loader(uint boot_device)

I don't like spL here, I mis-read that as a typo the second time I saw
it.  Maybe a function comment and spl_ll_find_loader ?

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot