Re: [U-Boot] [PATCH 1/1] easylogo: avoid buffer overrun
On Thu, Aug 15, 2019 at 11:54:15PM +0200, Heinrich Schuchardt wrote: > Building easylogo with `HOST_TOOLS_ALL=y make tools` results in a build > warning due to a possible buffer overrun: > > tools/easylogo/easylogo.c:453:4: note: ‘sprintf’ output between 7 and > 262 bytes into a destination of size 256 > sprintf (str, "%s, 0x%02x", app, *dataptr++); > ^~~~ > > Truncate the output to fit into the destination buffer. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] easylogo: avoid buffer overrun
On Fri, Aug 16, 2019 at 12:11:57AM +0200, Heinrich Schuchardt wrote: > On 8/15/19 11:54 PM, Heinrich Schuchardt wrote: > >Building easylogo with `HOST_TOOLS_ALL=y make tools` results in a build > >warning due to a possible buffer overrun: > > > >tools/easylogo/easylogo.c:453:4: note: ‘sprintf’ output between 7 and > >262 bytes into a destination of size 256 > > sprintf (str, "%s, 0x%02x", app, *dataptr++); > > ^~~~ > > > >Truncate the output to fit into the destination buffer. > > > >Signed-off-by: Heinrich Schuchardt > > Could we change .travis.yml and .gitlab-ci.yml to build all tools? Don't see why not, once they'd be green again. Follow up patch if that's the only problem, v2 of the series if you find more things to correct. Thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] easylogo: avoid buffer overrun
On 8/15/19 11:54 PM, Heinrich Schuchardt wrote: Building easylogo with `HOST_TOOLS_ALL=y make tools` results in a build warning due to a possible buffer overrun: tools/easylogo/easylogo.c:453:4: note: ‘sprintf’ output between 7 and 262 bytes into a destination of size 256 sprintf (str, "%s, 0x%02x", app, *dataptr++); ^~~~ Truncate the output to fit into the destination buffer. Signed-off-by: Heinrich Schuchardt Could we change .travis.yml and .gitlab-ci.yml to build all tools? Best regards Heinrich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
