Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-08 Thread Rob Clark
On Sun, Oct 8, 2017 at 12:41 PM, Alexander Graf wrote: > > >> Am 08.10.2017 um 17:54 schrieb Rob Clark : >> >>> On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt >>> wrote: >>> Patch efi_loader: add stub HII protocols uses UINTN

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-08 Thread Alexander Graf
> Am 08.10.2017 um 17:54 schrieb Rob Clark : > >> On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt >> wrote: >> Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent >> comment Simon remarked that types should not be uppercase.

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-08 Thread Rob Clark
On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt wrote: > Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent > comment Simon remarked that types should not be uppercase. So I was > planning to replace all occurences of UINTN by size_t in an upcoming

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-05 Thread Alexander Graf
On 04.10.17 18:39, Rob Clark wrote: On Wed, Oct 4, 2017 at 12:29 PM, Heinrich Schuchardt wrote: On 10/04/2017 05:25 PM, Alexander Graf wrote: On 04.10.17 16:57, Rob Clark wrote: On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt wrote: On

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-05 Thread Alexander Graf
On 04.10.17 18:29, Heinrich Schuchardt wrote: On 10/04/2017 05:25 PM, Alexander Graf wrote: On 04.10.17 16:57, Rob Clark wrote: On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt wrote: On 10/04/2017 04:14 PM, Rob Clark wrote: On Wed, Oct 4, 2017 at 9:03 AM,

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 12:29 PM, Heinrich Schuchardt wrote: > On 10/04/2017 05:25 PM, Alexander Graf wrote: >> >> >> On 04.10.17 16:57, Rob Clark wrote: >>> On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt >>> wrote: On 10/04/2017 04:14 PM, Rob

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt wrote: > On 10/04/2017 04:57 PM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt >> wrote: >>> On 10/04/2017 04:14 PM, Rob Clark wrote: On Wed, Oct 4, 2017 at 9:03 AM,

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Heinrich Schuchardt
On 10/04/2017 05:25 PM, Alexander Graf wrote: > > > On 04.10.17 16:57, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt >> wrote: >>> On 10/04/2017 04:14 PM, Rob Clark wrote: On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Heinrich Schuchardt
On 10/04/2017 04:57 PM, Rob Clark wrote: > On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt > wrote: >> On 10/04/2017 04:14 PM, Rob Clark wrote: >>> On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt >>> wrote: Queued and signaled describe

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Alexander Graf
On 04.10.17 16:57, Rob Clark wrote: On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt wrote: On 10/04/2017 04:14 PM, Rob Clark wrote: On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt wrote: Queued and signaled describe boolean states of

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 10:46 AM, Heinrich Schuchardt wrote: > On 10/04/2017 04:14 PM, Rob Clark wrote: >> On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt >> wrote: >>> Queued and signaled describe boolean states of events. >>> So let's use type bool

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Heinrich Schuchardt
On 10/04/2017 04:14 PM, Rob Clark wrote: > On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt > wrote: >> Queued and signaled describe boolean states of events. >> So let's use type bool and rename the structure members to is_queued >> and is_signaled. >> >> Update the

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 9:03 AM, Heinrich Schuchardt wrote: > Queued and signaled describe boolean states of events. > So let's use type bool and rename the structure members to is_queued > and is_signaled. > > Update the comments for is_queued and is_signaled. Reviewed-by: