Re: [U-Boot] [PATCH 1/2] net: dwc_eth_qos: Change eqos_ops function to static

2019-08-15 Thread Joe Hershberger
On Thu, Aug 1, 2019 at 4:31 AM Patrick Delaunay  wrote:
>
> This patch solves many warnings when compiling with W=1:
> warning: no previous prototype for '' [-Wmissing-prototypes]
>
> Signed-off-by: Patrice Chotard 
> Signed-off-by: Patrick Delaunay 

Acked-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 1/2] net: dwc_eth_qos: Change eqos_ops function to static

2019-08-03 Thread Ramon Fried
On Thu, Aug 1, 2019 at 12:31 PM Patrick Delaunay
 wrote:
>
> This patch solves many warnings when compiling with W=1:
> warning: no previous prototype for '' [-Wmissing-prototypes]
>
> Signed-off-by: Patrice Chotard 
> Signed-off-by: Patrick Delaunay 
> ---
>
>  drivers/net/dwc_eth_qos.c | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> index 07b3667..6df9956 100644
> --- a/drivers/net/dwc_eth_qos.c
> +++ b/drivers/net/dwc_eth_qos.c
> @@ -621,7 +621,7 @@ err:
> return ret;
>  }
>
> -void eqos_stop_clks_tegra186(struct udevice *dev)
> +static void eqos_stop_clks_tegra186(struct udevice *dev)
>  {
> struct eqos_priv *eqos = dev_get_priv(dev);
>
> @@ -636,7 +636,7 @@ void eqos_stop_clks_tegra186(struct udevice *dev)
> debug("%s: OK\n", __func__);
>  }
>
> -void eqos_stop_clks_stm32(struct udevice *dev)
> +static void eqos_stop_clks_stm32(struct udevice *dev)
>  {
> struct eqos_priv *eqos = dev_get_priv(dev);
>
> @@ -1290,7 +1290,7 @@ err:
> return ret;
>  }
>
> -void eqos_stop(struct udevice *dev)
> +static void eqos_stop(struct udevice *dev)
>  {
> struct eqos_priv *eqos = dev_get_priv(dev);
> int i;
> @@ -1344,7 +1344,7 @@ void eqos_stop(struct udevice *dev)
> debug("%s: OK\n", __func__);
>  }
>
> -int eqos_send(struct udevice *dev, void *packet, int length)
> +static int eqos_send(struct udevice *dev, void *packet, int length)
>  {
> struct eqos_priv *eqos = dev_get_priv(dev);
> struct eqos_desc *tx_desc;
> @@ -1385,7 +1385,7 @@ int eqos_send(struct udevice *dev, void *packet, int 
> length)
> return -ETIMEDOUT;
>  }
>
> -int eqos_recv(struct udevice *dev, int flags, uchar **packetp)
> +static int eqos_recv(struct udevice *dev, int flags, uchar **packetp)
>  {
> struct eqos_priv *eqos = dev_get_priv(dev);
> struct eqos_desc *rx_desc;
> @@ -1409,7 +1409,7 @@ int eqos_recv(struct udevice *dev, int flags, uchar 
> **packetp)
> return length;
>  }
>
> -int eqos_free_pkt(struct udevice *dev, uchar *packet, int length)
> +static int eqos_free_pkt(struct udevice *dev, uchar *packet, int length)
>  {
> struct eqos_priv *eqos = dev_get_priv(dev);
> uchar *packet_expected;
> --
> 2.7.4
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Reviewed-By: Ramon Fried 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot