Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose()

2016-11-07 Thread york sun
On 10/11/2016 07:11 AM, M.H. Lian wrote: >> >> I got it. But this does not look that good to me. There are two controllers, >> and >> bus number should be relative to the controller itself, not system wide. It's >> definitely right to assign bus number 0 to both PCIe host controllers, as >> they

Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose()

2016-10-11 Thread M.H. Lian
t; > Subject: Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in > pci_bus_to_hose() > > Hi Minghuan, > > On Tue, Oct 11, 2016 at 3:12 PM, M.H. Lian wrote: > > Hi Bin, > > > > With the patches our Layerscape PCIe driver has been fully based on DM. >

Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose()

2016-10-11 Thread M.H. Lian
n Meng [mailto:bmeng...@gmail.com] > Sent: Tuesday, October 11, 2016 6:35 PM > To: M.H. Lian > Cc: Simon Glass ; U-Boot Mailing List b...@lists.denx.de>; Mingkai Hu ; Leo Li > > Subject: Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in > pci_bus_to_hose() > &

Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose()

2016-10-11 Thread Bin Meng
gt;> To: M.H. Lian >> Cc: Simon Glass ; U-Boot Mailing List > b...@lists.denx.de>; Mingkai Hu ; Leo Li >> >> Subject: Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in >> pci_bus_to_hose() >> >> Hi Minghuan, >> >> On Tue, Oct

Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose()

2016-10-11 Thread M.H. Lian
pace to PCI0. For E1000#1, we want to get the host pointed to PCI1 bus2 not bus0. Thanks, Minghuan > -Original Message- > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: Monday, October 10, 2016 6:38 PM > To: M.H. Lian > Cc: Simon Glass ; U-Boot Mailing List b...@lists.denx.d

Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose()

2016-10-11 Thread Bin Meng
Hi Minghuan, On Tue, Oct 11, 2016 at 3:12 PM, M.H. Lian wrote: > Hi Bin, > > With the patches our Layerscape PCIe driver has been fully based on DM. > Ethernet driver E1000 needs to define "CONFIG_DM_ETH" to use PCIe DM API > instead of legacy PCI API. > But our other Ethernet driver FM(drivers/

Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose()

2016-10-10 Thread M.H. Lian
SoCs. Thanks, Minghuan > -Original Message- > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: Monday, October 10, 2016 5:03 PM > To: M.H. Lian ; Simon Glass > Cc: U-Boot Mailing List ; Mingkai Hu > ; Leo Li > Subject: Re: [U-Boot] [PATCH 1/9] dm: pci: return t

Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose()

2016-10-10 Thread Bin Meng
Hi Minghuan, On Mon, Oct 10, 2016 at 5:09 PM, M.H. Lian wrote: > Hi Bin, > > Thanks for your comments. > > The series of patches is to change legacy PCIe driver to DM PCIe driver. > The first two patches are to change DM to support multiple PCIe controllers. I don't understand what is broken. If

Re: [U-Boot] [PATCH 1/9] dm: pci: return the real controller in pci_bus_to_hose()

2016-10-10 Thread Bin Meng
+Simon Hi Minghuan, On Mon, Oct 10, 2016 at 4:47 PM, Minghuan Lian wrote: > for the legacy PCI driver, the function pci_bus_to_hose() returns > the real PCIe controller. To keep consistency, this function is > changed to return the PCIe controller pointer of the root bus > instead of the current