Re: [U-Boot] [PATCH 2/2] mmc: sdhci: remove the unnecessary argumetns for sdhci_setup_cfg

[Jaehoon Chung]

Hi Simon,

On 08/04/2016 11:36 AM, Simon Glass wrote:
> On 31 July 2016 at 20:20, Simon Glass  wrote:
>> On 26 July 2016 at 04:06, Jaehoon Chung  wrote:
>>> Some arguments don't need to pass to sdhci_setup_cfg.
>>> Generic variable can be used in sdhci_setup_cfg, and some arguments are
>>> already included in sdhci_host struct.
>>>
>>> It's enough that just pass the board specific things to sdhci_setup_cfg().
>>> After removing the unnecessary arguments, it's more simpler than before.
>>> It doesn't consider "Version" and "Capabilities" anymore in each SoC
>>> driver.
>>>
>>> Signed-off-by: Jaehoon Chung 
>>> ---
>>>  drivers/mmc/msm_sdhci.c  |  4 +---
>>>  drivers/mmc/sdhci.c  | 28 +++-
>>>  drivers/mmc/zynq_sdhci.c |  9 ++---
>>>  include/sdhci.h  | 12 +++-
>>>  4 files changed, 21 insertions(+), 32 deletions(-)
>>
>> Reviewed-by: Simon Glass 
> 
> If you are applying this, can you please fix the typo in the subject?

Sure! Also i'm preparing other mmc patches..Thanks for reminding.

Best Regards,
Jaehoon Chung

> 
> - Simon
> 
> 
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] mmc: sdhci: remove the unnecessary argumetns for sdhci_setup_cfg

[Simon Glass]

On 31 July 2016 at 20:20, Simon Glass  wrote:
> On 26 July 2016 at 04:06, Jaehoon Chung  wrote:
>> Some arguments don't need to pass to sdhci_setup_cfg.
>> Generic variable can be used in sdhci_setup_cfg, and some arguments are
>> already included in sdhci_host struct.
>>
>> It's enough that just pass the board specific things to sdhci_setup_cfg().
>> After removing the unnecessary arguments, it's more simpler than before.
>> It doesn't consider "Version" and "Capabilities" anymore in each SoC
>> driver.
>>
>> Signed-off-by: Jaehoon Chung 
>> ---
>>  drivers/mmc/msm_sdhci.c  |  4 +---
>>  drivers/mmc/sdhci.c  | 28 +++-
>>  drivers/mmc/zynq_sdhci.c |  9 ++---
>>  include/sdhci.h  | 12 +++-
>>  4 files changed, 21 insertions(+), 32 deletions(-)
>
> Reviewed-by: Simon Glass 

If you are applying this, can you please fix the typo in the subject?

- Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] mmc: sdhci: remove the unnecessary argumetns for sdhci_setup_cfg

[Simon Glass]

On 26 July 2016 at 04:06, Jaehoon Chung  wrote:
> Some arguments don't need to pass to sdhci_setup_cfg.
> Generic variable can be used in sdhci_setup_cfg, and some arguments are
> already included in sdhci_host struct.
>
> It's enough that just pass the board specific things to sdhci_setup_cfg().
> After removing the unnecessary arguments, it's more simpler than before.
> It doesn't consider "Version" and "Capabilities" anymore in each SoC
> driver.
>
> Signed-off-by: Jaehoon Chung 
> ---
>  drivers/mmc/msm_sdhci.c  |  4 +---
>  drivers/mmc/sdhci.c  | 28 +++-
>  drivers/mmc/zynq_sdhci.c |  9 ++---
>  include/sdhci.h  | 12 +++-
>  4 files changed, 21 insertions(+), 32 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot