Re: [U-Boot] [PATCH 2/2] tools/imximage: use 0x prefix in HAB Blocks line

2018-04-15 Thread Stefano Babic


On 23/03/2018 12:08, Rasmus Villemoes wrote:
> The u-boot-ivt.img.log file contains 0x prefixes in the HAB Blocks line,
> while the SPL.log does not. For consistency, and to make it easier to
> extract and put into a .csf file for use with NXP's code signing tool,
> add 0x prefixes here.
> 
> Signed-off-by: Rasmus Villemoes 
> ---
>  doc/README.mxc_hab | 14 +++---
>  tools/imximage.c   |  2 +-
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/doc/README.mxc_hab b/doc/README.mxc_hab
> index 75390a505e..a40ebf3e84 100644
> --- a/doc/README.mxc_hab
> +++ b/doc/README.mxc_hab
> @@ -33,12 +33,12 @@ Image Ver:2 (i.MX53/6 compatible)
>  Data Size:327680 Bytes = 320.00 kB = 0.31 MB
>  Load Address: 177ff420
>  Entry Point:  1780
> -HAB Blocks:   177ff400  0004dc00
> -     
> - |   |  |
> - |   |   (1)
> - |   |
> - |   --- (2)
> +HAB Blocks:   0x177ff400 0x 0x0004dc00
> +   ^^ ^^ ^^
> + |  |  |
> + |  |  - (1)
> + |  |
> + |   (2)
>   |
>   --- (3)
>  
> @@ -78,7 +78,7 @@ Example Output of the SPL (imximage) creation:
>   Data Size:61440 Bytes = 60.00 kB = 0.06 MB
>   Load Address: 00907420
>   Entry Point:  00908000
> - HAB Blocks:   00907400  cc00
> + HAB Blocks:   0x00907400 0x 0xcc00
>  
>  Example Output of the u-boot-ivt.img (firmware_ivt) creation:
>   Image Name:   U-Boot 2016.11-rc1-31589-g2a4411
> diff --git a/tools/imximage.c b/tools/imximage.c
> index ed9d935903..6dabb13520 100644
> --- a/tools/imximage.c
> +++ b/tools/imximage.c
> @@ -516,7 +516,7 @@ static void print_hdr_v2(struct imx_header *imx_hdr)
>   offs = (char *)&hdr_v2->data.dcd_table
>   - (char *)hdr_v2;
>  
> - printf("HAB Blocks:   %08x %08x %08x\n",
> + printf("HAB Blocks:   0x%08x 0x%08x 0x%08x\n",
>  (uint32_t)fhdr_v2->self, 0,
>  hdr_v2->boot_data.size - imximage_ivt_offset -
>  imximage_csf_size);
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 2/2] tools/imximage: use 0x prefix in HAB Blocks line

2018-03-24 Thread Breno Matheus Lima
Hi Rasmus,

2018-03-23 9:40 GMT-03:00 Fabio Estevam :
> On Fri, Mar 23, 2018 at 8:08 AM, Rasmus Villemoes
>  wrote:
>> The u-boot-ivt.img.log file contains 0x prefixes in the HAB Blocks line,
>> while the SPL.log does not. For consistency, and to make it easier to
>> extract and put into a .csf file for use with NXP's code signing tool,
>> add 0x prefixes here.
>>
>> Signed-off-by: Rasmus Villemoes 
>
> Reviewed-by: Fabio Estevam 

Tested-by: Breno Lima 

Thanks,
Breno Lima
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 2/2] tools/imximage: use 0x prefix in HAB Blocks line

2018-03-23 Thread Fabio Estevam
On Fri, Mar 23, 2018 at 8:08 AM, Rasmus Villemoes
 wrote:
> The u-boot-ivt.img.log file contains 0x prefixes in the HAB Blocks line,
> while the SPL.log does not. For consistency, and to make it easier to
> extract and put into a .csf file for use with NXP's code signing tool,
> add 0x prefixes here.
>
> Signed-off-by: Rasmus Villemoes 

Reviewed-by: Fabio Estevam 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot