Re: [U-Boot] [PATCH 2/2 V4] Changes to move hawkboard to the new spl infrastructure
Hi Sughosh, On Wed, Jan 11, 2012 at 6:03 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: This patch moves hawkboard to the new spl infrastructure from the older nand_spl one. Removed the hawkboard_nand_config build option -- The spl code now gets compiled with hawkboard_config, after building the main u-boot image, using the CONFIG_SPL_TEXT_BASE. Modified the README.hawkboard to reflect the same. Signed-off-by: Sughosh Ganu urwithsugh...@gmail.com Signed-off-by: Heiko Schocher h...@denx.de Cc: Heiko Schocher h...@denx.de Cc: Christian Riesch christian.rie...@omicron.at Cc: Sudhakar Rajashekhara sudhakar@ti.com Cc: Tom Rini tr...@ti.com I have tested this with both the da850evm and the calimain board (see [1]), and the low level initialization still works :-) Therefore Acked-by: Christian Riesch christian.rie...@omicron.at Regards, Christian [1] http://patchwork.ozlabs.org/patch/135593/ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2 V4] Changes to move hawkboard to the new spl infrastructure
hi Christian, On Thu Jan 12, 2012 at 10:02:47AM +0100, Christian Riesch wrote: Hi Sughosh, On Wed, Jan 11, 2012 at 6:03 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: This patch moves hawkboard to the new spl infrastructure from the older nand_spl one. Removed the hawkboard_nand_config build option -- The spl code now gets compiled with hawkboard_config, after building the main u-boot image, using the CONFIG_SPL_TEXT_BASE. Modified the README.hawkboard to reflect the same. Signed-off-by: Sughosh Ganu urwithsugh...@gmail.com Signed-off-by: Heiko Schocher h...@denx.de Cc: Heiko Schocher h...@denx.de Cc: Christian Riesch christian.rie...@omicron.at Cc: Sudhakar Rajashekhara sudhakar@ti.com Cc: Tom Rini tr...@ti.com I have tested this with both the da850evm and the calimain board (see [1]), and the low level initialization still works :-) Therefore Acked-by: Christian Riesch christian.rie...@omicron.at Thanks for the review and ack :) Can you also please test out this patch. http://patchwork.ozlabs.org/patch/135275/ Just wanted to make sure it does not introduce any regressions. This is a generic arm926ejs fix, so you should be able to test this on any arm926ejs based board -sughosh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2 V4] Changes to move hawkboard to the new spl infrastructure
On Thu, Jan 12, 2012 at 10:39 AM, Sughosh Ganu urwithsugh...@gmail.com wrote: hi Christian, On Thu Jan 12, 2012 at 10:02:47AM +0100, Christian Riesch wrote: Hi Sughosh, On Wed, Jan 11, 2012 at 6:03 PM, Sughosh Ganu urwithsugh...@gmail.com wrote: This patch moves hawkboard to the new spl infrastructure from the older nand_spl one. Removed the hawkboard_nand_config build option -- The spl code now gets compiled with hawkboard_config, after building the main u-boot image, using the CONFIG_SPL_TEXT_BASE. Modified the README.hawkboard to reflect the same. Signed-off-by: Sughosh Ganu urwithsugh...@gmail.com Signed-off-by: Heiko Schocher h...@denx.de Cc: Heiko Schocher h...@denx.de Cc: Christian Riesch christian.rie...@omicron.at Cc: Sudhakar Rajashekhara sudhakar@ti.com Cc: Tom Rini tr...@ti.com I have tested this with both the da850evm and the calimain board (see [1]), and the low level initialization still works :-) Therefore Acked-by: Christian Riesch christian.rie...@omicron.at Thanks for the review and ack :) Can you also please test out this patch. http://patchwork.ozlabs.org/patch/135275/ Just wanted to make sure it does not introduce any regressions. This is a generic arm926ejs fix, so you should be able to test this on any arm926ejs based board Ok, I'll do a few tests and reply in the other thread. Christian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2 V4] Changes to move hawkboard to the new spl infrastructure
Hello Sughosh, Sughosh Ganu wrote: This patch moves hawkboard to the new spl infrastructure from the older nand_spl one. Removed the hawkboard_nand_config build option -- The spl code now gets compiled with hawkboard_config, after building the main u-boot image, using the CONFIG_SPL_TEXT_BASE. Modified the README.hawkboard to reflect the same. Signed-off-by: Sughosh Ganu urwithsugh...@gmail.com Signed-off-by: Heiko Schocher h...@denx.de Cc: Heiko Schocher h...@denx.de Cc: Christian Riesch christian.rie...@omicron.at Cc: Sudhakar Rajashekhara sudhakar@ti.com Cc: Tom Rini tr...@ti.com --- Patch looks good to me, but it doesn't aplly to current TOT [hs@pollux u-boot]$ git am index.html Applying: Changes to move hawkboard to the new spl infrastructure error: patch failed: include/configs/da850evm.h:44 error: include/configs/da850evm.h: patch does not apply Patch failed at 0001 Changes to move hawkboard to the new spl infrastructure When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. [hs@pollux u-boot]$ My tree is commit 9a4209869bd2c37affd931d627b3c3e72952 Author: Rob Herring rob.herr...@calxeda.com Date: Thu Dec 15 11:15:50 2011 + ARM: highbank: enable networking and pxe Do I missing something here? (If I remember right, I had no such issue with your v1 patch ...) bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2 V4] Changes to move hawkboard to the new spl infrastructure
hi Heiko, On Thu Jan 12, 2012 at 08:24:03AM +0100, Heiko Schocher wrote: Hello Sughosh, Sughosh Ganu wrote: This patch moves hawkboard to the new spl infrastructure from the older nand_spl one. Removed the hawkboard_nand_config build option -- The spl code now gets compiled with hawkboard_config, after building the main u-boot image, using the CONFIG_SPL_TEXT_BASE. Modified the README.hawkboard to reflect the same. Signed-off-by: Sughosh Ganu urwithsugh...@gmail.com Signed-off-by: Heiko Schocher h...@denx.de Cc: Heiko Schocher h...@denx.de Cc: Christian Riesch christian.rie...@omicron.at Cc: Sudhakar Rajashekhara sudhakar@ti.com Cc: Tom Rini tr...@ti.com --- Patch looks good to me, but it doesn't aplly to current TOT [hs@pollux u-boot]$ git am index.html Applying: Changes to move hawkboard to the new spl infrastructure error: patch failed: include/configs/da850evm.h:44 error: include/configs/da850evm.h: patch does not apply Patch failed at 0001 Changes to move hawkboard to the new spl infrastructure When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. [hs@pollux u-boot]$ I have based this on u-boot-ti, as this would be applied to the ti tree. -sughosh ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
