subject:"Re\: \[U\-Boot\] \[PATCH 2\/3\] sunxi\:Added Mele i7 eMMC MOD DTS"

Re: [U-Boot] [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTS

2015-07-06 Thread Maxime Ripard

On Mon, Jul 06, 2015 at 02:12:06PM +0800, Chen-Yu Tsai wrote:
 On Mon, Jul 6, 2015 at 3:15 AM, Hans de Goede hdego...@redhat.com wrote:
  Hi,
 
  On 29-06-15 11:47, 加特技的肖特基 wrote:
 
   From 83aa308eb836b0a63f0e30bd10d72040151a1e98 Mon Sep 17 00:00:00 2001
  From: Zhi Yuan Wan dv...@qq.com
  Date: Thu, 25 Jun 2015 20:00:46 +0800
  Subject: [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTS
Signed-off-by: Zhi Yuan Wan dv...@qq.com
 
  ---
arch/arm/dts/sun6i-a31-i7.dts |   10 ++
configs/Mele_I7_defconfig |2 +-
2 files changed, 11 insertions(+), 1 deletion(-)
 
  diff --git a/arch/arm/dts/sun6i-a31-i7.dts b/arch/arm/dts/sun6i-a31-i7.dts
  index e9185da..1046864 100644
  --- a/arch/arm/dts/sun6i-a31-i7.dts
  +++ b/arch/arm/dts/sun6i-a31-i7.dts
  @@ -51,6 +51,7 @@
model = Mele I7 Quad top set box;
compatible = mele,i7, allwinner,sun6i-a31;
 
  +
aliases {
serial0 = uart0;
};
 
 
  Whitespace only change, please drop this bit.
 
  @@ -107,6 +108,15 @@
status = okay;
};
 
  +mmc2 {
  +pinctrl-names = default;
  +pinctrl-0 = mmc2_pins_a;
  +vmmc-supply = reg_vcc3v3;
  +bus-width = 4;
  +non-removable;
  +status = okay;
  +};
  +
pio {
led_pins_i7: led_pins@0 {
allwinner,pins = PH13;
 
 
  This bit looks good, but please submit dts file patches to the upstream
  linux kernel first, using the standard kernel patch submission process.
 
  Also as said before if your I7 version has an eMMC, please add
  a new dts file for this titled: arch/arm/dts/sun6i-a31-mele-i7-emmc.dts .
 
 AFAIK this is an after market mod. See:
 
 http://linux-sunxi.org/Replace_NAND_with_eMMC_howto

I don't think we want to carry this kind of hacks in-tree. If you're
willing to do that to your hardware, you can carry your own patch
against a DT, especially since you'll have to modify it to enable the
eMMC even it was merged.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTS

2015-07-06 Thread Chen-Yu Tsai

On Mon, Jul 6, 2015 at 3:15 AM, Hans de Goede hdego...@redhat.com wrote:
 Hi,

 On 29-06-15 11:47, 加特技的肖特基 wrote:

  From 83aa308eb836b0a63f0e30bd10d72040151a1e98 Mon Sep 17 00:00:00 2001
 From: Zhi Yuan Wan dv...@qq.com
 Date: Thu, 25 Jun 2015 20:00:46 +0800
 Subject: [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTS
   Signed-off-by: Zhi Yuan Wan dv...@qq.com

 ---
   arch/arm/dts/sun6i-a31-i7.dts |   10 ++
   configs/Mele_I7_defconfig |2 +-
   2 files changed, 11 insertions(+), 1 deletion(-)

 diff --git a/arch/arm/dts/sun6i-a31-i7.dts b/arch/arm/dts/sun6i-a31-i7.dts
 index e9185da..1046864 100644
 --- a/arch/arm/dts/sun6i-a31-i7.dts
 +++ b/arch/arm/dts/sun6i-a31-i7.dts
 @@ -51,6 +51,7 @@
   model = Mele I7 Quad top set box;
   compatible = mele,i7, allwinner,sun6i-a31;

 +
   aliases {
   serial0 = uart0;
   };


 Whitespace only change, please drop this bit.

 @@ -107,6 +108,15 @@
   status = okay;
   };

 +mmc2 {
 +pinctrl-names = default;
 +pinctrl-0 = mmc2_pins_a;
 +vmmc-supply = reg_vcc3v3;
 +bus-width = 4;
 +non-removable;
 +status = okay;
 +};
 +
   pio {
   led_pins_i7: led_pins@0 {
   allwinner,pins = PH13;


 This bit looks good, but please submit dts file patches to the upstream
 linux kernel first, using the standard kernel patch submission process.

 Also as said before if your I7 version has an eMMC, please add
 a new dts file for this titled: arch/arm/dts/sun6i-a31-mele-i7-emmc.dts .

AFAIK this is an after market mod. See:

http://linux-sunxi.org/Replace_NAND_with_eMMC_howto

 Please submit this new file upstream.

 diff --git a/configs/Mele_I7_defconfig b/configs/Mele_I7_defconfig
 index bf67433..aad780b 100644
 --- a/configs/Mele_I7_defconfig
 +++ b/configs/Mele_I7_defconfig
 @@ -1,7 +1,7 @@
   CONFIG_ARM=y
   CONFIG_ARCH_SUNXI=y
   CONFIG_MACH_SUN6I=y
 -CONFIG_DRAM_ZQ=120
 +CONFIG_DRAM_ZQ=251
   CONFIG_USB1_VBUS_PIN=PC27
   CONFIG_USB2_VBUS_PIN=
   CONFIG_DEFAULT_DEVICE_TREE=sun6i-a31-i7


 This change is completely unrelated to the emmc changes, please
 submit this as a separate patch. Please also explain why you are
 making this change, where does the 251 value come from ?

 Regards,

 Hans

 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTS

2015-07-05 Thread Hans de Goede


Hi,

On 29-06-15 11:47, ?? wrote:

 From 83aa308eb836b0a63f0e30bd10d72040151a1e98 Mon Sep 17 00:00:00 2001
From: Zhi Yuan Wan dv...@qq.com
Date: Thu, 25 Jun 2015 20:00:46 +0800
Subject: [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTS
  Signed-off-by: Zhi Yuan Wan dv...@qq.com

---
  arch/arm/dts/sun6i-a31-i7.dts |   10 ++
  configs/Mele_I7_defconfig |2 +-
  2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/arch/arm/dts/sun6i-a31-i7.dts b/arch/arm/dts/sun6i-a31-i7.dts
index e9185da..1046864 100644
--- a/arch/arm/dts/sun6i-a31-i7.dts
+++ b/arch/arm/dts/sun6i-a31-i7.dts
@@ -51,6 +51,7 @@
  model = Mele I7 Quad top set box;
  compatible = mele,i7, allwinner,sun6i-a31;

+
  aliases {
  serial0 = uart0;
  };


Whitespace only change, please drop this bit.


@@ -107,6 +108,15 @@
  status = okay;
  };

+mmc2 {
+pinctrl-names = default;
+pinctrl-0 = mmc2_pins_a;
+vmmc-supply = reg_vcc3v3;
+bus-width = 4;
+non-removable;
+status = okay;
+};
+
  pio {
  led_pins_i7: led_pins@0 {
  allwinner,pins = PH13;


This bit looks good, but please submit dts file patches to the upstream
linux kernel first, using the standard kernel patch submission process.

Also as said before if your I7 version has an eMMC, please add
a new dts file for this titled: arch/arm/dts/sun6i-a31-mele-i7-emmc.dts .

Please submit this new file upstream.


diff --git a/configs/Mele_I7_defconfig b/configs/Mele_I7_defconfig
index bf67433..aad780b 100644
--- a/configs/Mele_I7_defconfig
+++ b/configs/Mele_I7_defconfig
@@ -1,7 +1,7 @@
  CONFIG_ARM=y
  CONFIG_ARCH_SUNXI=y
  CONFIG_MACH_SUN6I=y
-CONFIG_DRAM_ZQ=120
+CONFIG_DRAM_ZQ=251
  CONFIG_USB1_VBUS_PIN=PC27
  CONFIG_USB2_VBUS_PIN=
  CONFIG_DEFAULT_DEVICE_TREE=sun6i-a31-i7


This change is completely unrelated to the emmc changes, please
submit this as a separate patch. Please also explain why you are
making this change, where does the 251 value come from ?

Regards,

Hans
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTS

Re: [U-Boot] [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTS

Re: [U-Boot] [PATCH 2/3] sunxi:Added Mele i7 eMMC MOD DTS

3 matches

Site Navigation

Mail list logo

Footer information