Re: [U-Boot] [PATCH 3/7] tegra: Add I2C support to funcmux
On 12/26/2011 11:11 AM, Simon Glass wrote: Add support to funcmux for selecting I2C functions and programming the pinmux appropriately. Signed-off-by: Simon Glass s...@chromium.org Conceptually the changes here look fine. I think that adding the new I2C cases and the tests for valid config values to the existing cases are probably worthing of two separate patches though. -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/7] tegra: Add I2C support to funcmux
Hi Stephen, On Mon, Jan 9, 2012 at 1:36 PM, Stephen Warren swar...@nvidia.com wrote: On 12/26/2011 11:11 AM, Simon Glass wrote: Add support to funcmux for selecting I2C functions and programming the pinmux appropriately. Signed-off-by: Simon Glass s...@chromium.org Conceptually the changes here look fine. I think that adding the new I2C cases and the tests for valid config values to the existing cases are probably worthing of two separate patches though. OK, I might do this as part of the mmc side. Regards, Simon -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/7] tegra: Add I2C support to funcmux
Hi Stephe, On Mon, Jan 9, 2012 at 1:40 PM, Simon Glass s...@chromium.org wrote: Hi Stephen, On Mon, Jan 9, 2012 at 1:36 PM, Stephen Warren swar...@nvidia.com wrote: On 12/26/2011 11:11 AM, Simon Glass wrote: Add support to funcmux for selecting I2C functions and programming the pinmux appropriately. Signed-off-by: Simon Glass s...@chromium.org Conceptually the changes here look fine. I think that adding the new I2C cases and the tests for valid config values to the existing cases are probably worthing of two separate patches though. OK, I might do this as part of the mmc side. Since there are a few things there now I have created a separate funcmux series and moved this I2C patch into that. I will drop it from here when I send the next version. Regards, Simon Regards, Simon -- nvpublic ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
