Re: [U-Boot] [PATCH 4/4] imx: mx6sxsabreauto: Add support for mx6sx SABREAUTO board

2015-02-11 Thread Li Ye-B37916
Hi,

On 2/10/2015 6:51 PM, Stefano Babic wrote:
 Hi,

 On 12/01/2015 09:46, Ye.Li wrote:
 Initial version for mx6sx SABREAUTO board support with features:
 PMIC, QSPI, NAND flash, SD/MMC, USB, Ethernet, I2C, IO Expander.

 Signed-off-by: Ye.Li b37...@freescale.com
 ---
  arch/arm/Kconfig|5 +
  board/freescale/mx6sxsabreauto/Kconfig  |   15 +
  board/freescale/mx6sxsabreauto/MAINTAINERS  |6 +
  board/freescale/mx6sxsabreauto/Makefile |6 +
  board/freescale/mx6sxsabreauto/imximage.cfg |  136 ++
  board/freescale/mx6sxsabreauto/mx6sxsabreauto.c |  498 
 +++
  configs/mx6sxsabreauto_defconfig|3 +
  include/configs/mx6sxsabreauto.h|  275 +
  8 files changed, 944 insertions(+), 0 deletions(-)
  create mode 100644 board/freescale/mx6sxsabreauto/Kconfig
  create mode 100644 board/freescale/mx6sxsabreauto/MAINTAINERS
  create mode 100644 board/freescale/mx6sxsabreauto/Makefile
  create mode 100644 board/freescale/mx6sxsabreauto/imximage.cfg
  create mode 100644 board/freescale/mx6sxsabreauto/mx6sxsabreauto.c
  create mode 100644 configs/mx6sxsabreauto_defconfig
  create mode 100644 include/configs/mx6sxsabreauto.h

 diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
 index 5eb1d03..9c54914 100644
 --- a/arch/arm/Kconfig
 +++ b/arch/arm/Kconfig
 @@ -638,6 +638,10 @@ config TARGET_MX6SXSABRESD
  bool Support mx6sxsabresd
  select CPU_V7
  
 +config TARGET_MX6SXSABREAUTO
 +bool Support mx6sxsabreauto
 +select CPU_V7
 +
  config TARGET_GW_VENTANA
  bool Support gw_ventana
  select CPU_V7
 @@ -916,6 +920,7 @@ source board/freescale/mx6qsabreauto/Kconfig
  source board/freescale/mx6sabresd/Kconfig
  source board/freescale/mx6slevk/Kconfig
  source board/freescale/mx6sxsabresd/Kconfig
 +source board/freescale/mx6sxsabreauto/Kconfig
  source board/freescale/vf610twr/Kconfig
  source board/gateworks/gw_ventana/Kconfig
  source board/genesi/mx51_efikamx/Kconfig
 diff --git a/board/freescale/mx6sxsabreauto/Kconfig 
 b/board/freescale/mx6sxsabreauto/Kconfig
 new file mode 100644
 index 000..b0f5167
 --- /dev/null
 +++ b/board/freescale/mx6sxsabreauto/Kconfig
 @@ -0,0 +1,15 @@
 +if TARGET_MX6SXSABREAUTO
 +
 +config SYS_BOARD
 +default mx6sxsabreauto
 +
 +config SYS_VENDOR
 +default freescale
 +
 +config SYS_SOC
 +default mx6
 +
 +config SYS_CONFIG_NAME
 +default mx6sxsabreauto
 +
 +endif
 diff --git a/board/freescale/mx6sxsabreauto/MAINTAINERS 
 b/board/freescale/mx6sxsabreauto/MAINTAINERS
 new file mode 100644
 index 000..dd3ae41
 --- /dev/null
 +++ b/board/freescale/mx6sxsabreauto/MAINTAINERS
 @@ -0,0 +1,6 @@
 +MX6SXSABREAUTO BOARD
 +M:  Ye Li ye...@freescale.com
 +S:  Maintained
 +F:  board/freescale/mx6sxsabreauto/
 +F:  include/configs/mx6sxsabreauto.h
 +F:  configs/mx6sxsabreauto_defconfig
 diff --git a/board/freescale/mx6sxsabreauto/Makefile 
 b/board/freescale/mx6sxsabreauto/Makefile
 new file mode 100644
 index 000..f0cd1ce
 --- /dev/null
 +++ b/board/freescale/mx6sxsabreauto/Makefile
 @@ -0,0 +1,6 @@
 +# (C) Copyright 2014 Freescale Semiconductor, Inc.
 +#
 +# SPDX-License-Identifier:  GPL-2.0+
 +#
 +
 +obj-y  := mx6sxsabreauto.o
 diff --git a/board/freescale/mx6sxsabreauto/imximage.cfg 
 b/board/freescale/mx6sxsabreauto/imximage.cfg
 new file mode 100644
 index 000..529e555
 --- /dev/null
 +++ b/board/freescale/mx6sxsabreauto/imximage.cfg
 @@ -0,0 +1,136 @@
 +/*
 + * Copyright (C) 2014 Freescale Semiconductor, Inc.
 + *
 + * SPDX-License-Identifier: GPL-2.0+
 + */
 +
 +#define __ASSEMBLY__
 +#include config.h
 +
 +/* image version */
 +
 +IMAGE_VERSION 2
 +
 +/*
 + * Boot Device : one of
 + * spi/sd/nand/onenand, qspi/nor
 + */
 +
 +BOOT_FROM   sd
 +
 +/*
 + * Device Configuration Data (DCD)
 + *
 + * Each entry must have the format:
 + * Addr-type   AddressValue
 + *
 + * where:
 + *  Addr-type register length (1,2 or 4 bytes)
 + *  Address   absolute address of the register
 + *  value value to be stored in the register
 + */
 +
 +/* Enable all clocks */
 +DATA 4 0x020c4068 0x
 +DATA 4 0x020c406c 0x
 +DATA 4 0x020c4070 0x
 +DATA 4 0x020c4074 0x
 +DATA 4 0x020c4078 0x
 +DATA 4 0x020c407c 0x
 +DATA 4 0x020c4080 0x
 +DATA 4 0x020c4084 0x
 +
 I will not block the patch for this: you are the maintainer and you can
 test and check if this ok.

 I would only to point to the discussion with Peng regarding the same
 issue for the mx6sxsabresd. Peng confirmed that he would send a
 following patch for enabling only the clocks are needed. Mybe you can
 synchronize wit him.

Ungating all clocks won't have functional problem, but consume more power at 
booting.  For mx6 platforms,
we won't change it any more, but on following mx7, we will use a new function 
to initialize needed clocks.

 +/* IOMUX - DDR IO Type */
 +DATA 4 0x020e0618 0x000c
 +DATA 4 

Re: [U-Boot] [PATCH 4/4] imx: mx6sxsabreauto: Add support for mx6sx SABREAUTO board

2015-02-11 Thread Peng Fan

Hi,

On 2/11/2015 5:43 PM, Li Ye-B37916 wrote:

Hi,

On 2/10/2015 6:51 PM, Stefano Babic wrote:

Hi,

On 12/01/2015 09:46, Ye.Li wrote:

Initial version for mx6sx SABREAUTO board support with features:
PMIC, QSPI, NAND flash, SD/MMC, USB, Ethernet, I2C, IO Expander.

Signed-off-by: Ye.Li b37...@freescale.com
---
  arch/arm/Kconfig|5 +
  board/freescale/mx6sxsabreauto/Kconfig  |   15 +
  board/freescale/mx6sxsabreauto/MAINTAINERS  |6 +
  board/freescale/mx6sxsabreauto/Makefile |6 +
  board/freescale/mx6sxsabreauto/imximage.cfg |  136 ++
  board/freescale/mx6sxsabreauto/mx6sxsabreauto.c |  498 +++
  configs/mx6sxsabreauto_defconfig|3 +
  include/configs/mx6sxsabreauto.h|  275 +
  8 files changed, 944 insertions(+), 0 deletions(-)
  create mode 100644 board/freescale/mx6sxsabreauto/Kconfig
  create mode 100644 board/freescale/mx6sxsabreauto/MAINTAINERS
  create mode 100644 board/freescale/mx6sxsabreauto/Makefile
  create mode 100644 board/freescale/mx6sxsabreauto/imximage.cfg
  create mode 100644 board/freescale/mx6sxsabreauto/mx6sxsabreauto.c
  create mode 100644 configs/mx6sxsabreauto_defconfig
  create mode 100644 include/configs/mx6sxsabreauto.h

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5eb1d03..9c54914 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -638,6 +638,10 @@ config TARGET_MX6SXSABRESD
bool Support mx6sxsabresd
select CPU_V7
  
+config TARGET_MX6SXSABREAUTO

+   bool Support mx6sxsabreauto
+   select CPU_V7
+
  config TARGET_GW_VENTANA
bool Support gw_ventana
select CPU_V7
@@ -916,6 +920,7 @@ source board/freescale/mx6qsabreauto/Kconfig
  source board/freescale/mx6sabresd/Kconfig
  source board/freescale/mx6slevk/Kconfig
  source board/freescale/mx6sxsabresd/Kconfig
+source board/freescale/mx6sxsabreauto/Kconfig
  source board/freescale/vf610twr/Kconfig
  source board/gateworks/gw_ventana/Kconfig
  source board/genesi/mx51_efikamx/Kconfig
diff --git a/board/freescale/mx6sxsabreauto/Kconfig 
b/board/freescale/mx6sxsabreauto/Kconfig
new file mode 100644
index 000..b0f5167
--- /dev/null
+++ b/board/freescale/mx6sxsabreauto/Kconfig
@@ -0,0 +1,15 @@
+if TARGET_MX6SXSABREAUTO
+
+config SYS_BOARD
+   default mx6sxsabreauto
+
+config SYS_VENDOR
+   default freescale
+
+config SYS_SOC
+   default mx6
+
+config SYS_CONFIG_NAME
+   default mx6sxsabreauto
+
+endif
diff --git a/board/freescale/mx6sxsabreauto/MAINTAINERS 
b/board/freescale/mx6sxsabreauto/MAINTAINERS
new file mode 100644
index 000..dd3ae41
--- /dev/null
+++ b/board/freescale/mx6sxsabreauto/MAINTAINERS
@@ -0,0 +1,6 @@
+MX6SXSABREAUTO BOARD
+M: Ye Li ye...@freescale.com
+S: Maintained
+F: board/freescale/mx6sxsabreauto/
+F: include/configs/mx6sxsabreauto.h
+F: configs/mx6sxsabreauto_defconfig
diff --git a/board/freescale/mx6sxsabreauto/Makefile 
b/board/freescale/mx6sxsabreauto/Makefile
new file mode 100644
index 000..f0cd1ce
--- /dev/null
+++ b/board/freescale/mx6sxsabreauto/Makefile
@@ -0,0 +1,6 @@
+# (C) Copyright 2014 Freescale Semiconductor, Inc.
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y  := mx6sxsabreauto.o
diff --git a/board/freescale/mx6sxsabreauto/imximage.cfg 
b/board/freescale/mx6sxsabreauto/imximage.cfg
new file mode 100644
index 000..529e555
--- /dev/null
+++ b/board/freescale/mx6sxsabreauto/imximage.cfg
@@ -0,0 +1,136 @@
+/*
+ * Copyright (C) 2014 Freescale Semiconductor, Inc.
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+#define __ASSEMBLY__
+#include config.h
+
+/* image version */
+
+IMAGE_VERSION 2
+
+/*
+ * Boot Device : one of
+ * spi/sd/nand/onenand, qspi/nor
+ */
+
+BOOT_FROM  sd
+
+/*
+ * Device Configuration Data (DCD)
+ *
+ * Each entry must have the format:
+ * Addr-type   AddressValue
+ *
+ * where:
+ * Addr-type register length (1,2 or 4 bytes)
+ * Address   absolute address of the register
+ * value value to be stored in the register
+ */
+
+/* Enable all clocks */
+DATA 4 0x020c4068 0x
+DATA 4 0x020c406c 0x
+DATA 4 0x020c4070 0x
+DATA 4 0x020c4074 0x
+DATA 4 0x020c4078 0x
+DATA 4 0x020c407c 0x
+DATA 4 0x020c4080 0x
+DATA 4 0x020c4084 0x
+

I will not block the patch for this: you are the maintainer and you can
test and check if this ok.

I would only to point to the discussion with Peng regarding the same
issue for the mx6sxsabresd. Peng confirmed that he would send a
following patch for enabling only the clocks are needed. Mybe you can
synchronize wit him.


Ungating all clocks won't have functional problem, but consume more power at 
booting.  For mx6 platforms,
we won't change it any more, but on following mx7, we will use a new function 
to initialize needed clocks.


+/* IOMUX - DDR IO Type */
+DATA 4 0x020e0618 0x000c
+DATA 4 0x020e05fc 

Re: [U-Boot] [PATCH 4/4] imx: mx6sxsabreauto: Add support for mx6sx SABREAUTO board

2015-02-10 Thread Stefano Babic
Hi,

On 12/01/2015 09:46, Ye.Li wrote:
 Initial version for mx6sx SABREAUTO board support with features:
 PMIC, QSPI, NAND flash, SD/MMC, USB, Ethernet, I2C, IO Expander.
 
 Signed-off-by: Ye.Li b37...@freescale.com
 ---
  arch/arm/Kconfig|5 +
  board/freescale/mx6sxsabreauto/Kconfig  |   15 +
  board/freescale/mx6sxsabreauto/MAINTAINERS  |6 +
  board/freescale/mx6sxsabreauto/Makefile |6 +
  board/freescale/mx6sxsabreauto/imximage.cfg |  136 ++
  board/freescale/mx6sxsabreauto/mx6sxsabreauto.c |  498 
 +++
  configs/mx6sxsabreauto_defconfig|3 +
  include/configs/mx6sxsabreauto.h|  275 +
  8 files changed, 944 insertions(+), 0 deletions(-)
  create mode 100644 board/freescale/mx6sxsabreauto/Kconfig
  create mode 100644 board/freescale/mx6sxsabreauto/MAINTAINERS
  create mode 100644 board/freescale/mx6sxsabreauto/Makefile
  create mode 100644 board/freescale/mx6sxsabreauto/imximage.cfg
  create mode 100644 board/freescale/mx6sxsabreauto/mx6sxsabreauto.c
  create mode 100644 configs/mx6sxsabreauto_defconfig
  create mode 100644 include/configs/mx6sxsabreauto.h
 
 diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
 index 5eb1d03..9c54914 100644
 --- a/arch/arm/Kconfig
 +++ b/arch/arm/Kconfig
 @@ -638,6 +638,10 @@ config TARGET_MX6SXSABRESD
   bool Support mx6sxsabresd
   select CPU_V7
  
 +config TARGET_MX6SXSABREAUTO
 + bool Support mx6sxsabreauto
 + select CPU_V7
 +
  config TARGET_GW_VENTANA
   bool Support gw_ventana
   select CPU_V7
 @@ -916,6 +920,7 @@ source board/freescale/mx6qsabreauto/Kconfig
  source board/freescale/mx6sabresd/Kconfig
  source board/freescale/mx6slevk/Kconfig
  source board/freescale/mx6sxsabresd/Kconfig
 +source board/freescale/mx6sxsabreauto/Kconfig
  source board/freescale/vf610twr/Kconfig
  source board/gateworks/gw_ventana/Kconfig
  source board/genesi/mx51_efikamx/Kconfig
 diff --git a/board/freescale/mx6sxsabreauto/Kconfig 
 b/board/freescale/mx6sxsabreauto/Kconfig
 new file mode 100644
 index 000..b0f5167
 --- /dev/null
 +++ b/board/freescale/mx6sxsabreauto/Kconfig
 @@ -0,0 +1,15 @@
 +if TARGET_MX6SXSABREAUTO
 +
 +config SYS_BOARD
 + default mx6sxsabreauto
 +
 +config SYS_VENDOR
 + default freescale
 +
 +config SYS_SOC
 + default mx6
 +
 +config SYS_CONFIG_NAME
 + default mx6sxsabreauto
 +
 +endif
 diff --git a/board/freescale/mx6sxsabreauto/MAINTAINERS 
 b/board/freescale/mx6sxsabreauto/MAINTAINERS
 new file mode 100644
 index 000..dd3ae41
 --- /dev/null
 +++ b/board/freescale/mx6sxsabreauto/MAINTAINERS
 @@ -0,0 +1,6 @@
 +MX6SXSABREAUTO BOARD
 +M:   Ye Li ye...@freescale.com
 +S:   Maintained
 +F:   board/freescale/mx6sxsabreauto/
 +F:   include/configs/mx6sxsabreauto.h
 +F:   configs/mx6sxsabreauto_defconfig
 diff --git a/board/freescale/mx6sxsabreauto/Makefile 
 b/board/freescale/mx6sxsabreauto/Makefile
 new file mode 100644
 index 000..f0cd1ce
 --- /dev/null
 +++ b/board/freescale/mx6sxsabreauto/Makefile
 @@ -0,0 +1,6 @@
 +# (C) Copyright 2014 Freescale Semiconductor, Inc.
 +#
 +# SPDX-License-Identifier:   GPL-2.0+
 +#
 +
 +obj-y  := mx6sxsabreauto.o
 diff --git a/board/freescale/mx6sxsabreauto/imximage.cfg 
 b/board/freescale/mx6sxsabreauto/imximage.cfg
 new file mode 100644
 index 000..529e555
 --- /dev/null
 +++ b/board/freescale/mx6sxsabreauto/imximage.cfg
 @@ -0,0 +1,136 @@
 +/*
 + * Copyright (C) 2014 Freescale Semiconductor, Inc.
 + *
 + * SPDX-License-Identifier:  GPL-2.0+
 + */
 +
 +#define __ASSEMBLY__
 +#include config.h
 +
 +/* image version */
 +
 +IMAGE_VERSION 2
 +
 +/*
 + * Boot Device : one of
 + * spi/sd/nand/onenand, qspi/nor
 + */
 +
 +BOOT_FROMsd
 +
 +/*
 + * Device Configuration Data (DCD)
 + *
 + * Each entry must have the format:
 + * Addr-type   AddressValue
 + *
 + * where:
 + *   Addr-type register length (1,2 or 4 bytes)
 + *   Address   absolute address of the register
 + *   value value to be stored in the register
 + */
 +
 +/* Enable all clocks */
 +DATA 4 0x020c4068 0x
 +DATA 4 0x020c406c 0x
 +DATA 4 0x020c4070 0x
 +DATA 4 0x020c4074 0x
 +DATA 4 0x020c4078 0x
 +DATA 4 0x020c407c 0x
 +DATA 4 0x020c4080 0x
 +DATA 4 0x020c4084 0x
 +

I will not block the patch for this: you are the maintainer and you can
test and check if this ok.

I would only to point to the discussion with Peng regarding the same
issue for the mx6sxsabresd. Peng confirmed that he would send a
following patch for enabling only the clocks are needed. Mybe you can
synchronize wit him.


 +/* IOMUX - DDR IO Type */
 +DATA 4 0x020e0618 0x000c
 +DATA 4 0x020e05fc 0x
 +
 +/* Clock */
 +DATA 4 0x020e032c 0x0030
 +
 +/* Address */
 +DATA 4 0x020e0300 0x0030
 +DATA 4 0x020e02fc 0x0030
 +DATA 4 0x020e05f4 0x0030
 +
 +/* Control */
 +DATA 4 0x020e0340 0x0030
 +
 +DATA 4