Re: [U-Boot] [PATCH V2 1/4] mmc: fsl_esdhc: add strobe and tuning entry

[Stefano Babic]

On 21/01/2018 12:00, Peng Fan wrote:
> Add entries that will be used for tuning control.
> The whole layout not changed, just expand reserved3[84] and
> rename other reservedx in sequence.
> 
> Signed-off-by: Peng Fan 
> Cc: Stefano Babic 
> Cc: Fabio Estevam 
> Cc: Jaehoon Chung 
> ---
>  drivers/mmc/fsl_esdhc.c | 20 
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index 71c62f4233..f6279307d8 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -61,23 +61,27 @@ struct fsl_esdhc {
>   uintdllctrl;
>   uintdllstat;
>   uintclktunectrlstatus;
> - charreserved3[84];
> + charreserved3[4];
> + uintstrobe_dllctrl;
> + uintstrobe_dllstat;
> + charreserved4[72];
>   uintvendorspec;
>   uintmmcboot;
>   uintvendorspec2;
> - charreserved4[48];
> + uinttuning_ctrl;/* on i.MX6/7/8 */
> + charreserved5[44];
>   uinthostver;/* Host controller version register */
> - charreserved5[4];   /* reserved */
> - uintdmaerraddr; /* DMA error address register */
>   charreserved6[4];   /* reserved */
> - uintdmaerrattr; /* DMA error attribute register */
> + uintdmaerraddr; /* DMA error address register */
>   charreserved7[4];   /* reserved */
> + uintdmaerrattr; /* DMA error attribute register */
> + charreserved8[4];   /* reserved */
>   uinthostcapblt2;/* Host controller capabilities register 2 */
> - charreserved8[8];   /* reserved */
> + charreserved9[8];   /* reserved */
>   uinttcr;/* Tuning control register */
> - charreserved9[28];  /* reserved */
> + charreserved10[28]; /* reserved */
>   uintsddirctl;   /* SD direction control register */
> - charreserved10[712];/* reserved */
> + charreserved11[712];/* reserved */
>   uintscr;/* eSDHC control register */
>  };
>  
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH V2 1/4] mmc: fsl_esdhc: add strobe and tuning entry

[Jaehoon Chung]

On 01/21/2018 08:00 PM, Peng Fan wrote:
> Add entries that will be used for tuning control.
> The whole layout not changed, just expand reserved3[84] and
> rename other reservedx in sequence.
> 
> Signed-off-by: Peng Fan 
> Cc: Stefano Babic 
> Cc: Fabio Estevam 
> Cc: Jaehoon Chung 

Reviewed-by: Jaehoon Chung 

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/fsl_esdhc.c | 20 
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index 71c62f4233..f6279307d8 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -61,23 +61,27 @@ struct fsl_esdhc {
>   uintdllctrl;
>   uintdllstat;
>   uintclktunectrlstatus;
> - charreserved3[84];
> + charreserved3[4];
> + uintstrobe_dllctrl;
> + uintstrobe_dllstat;
> + charreserved4[72];
>   uintvendorspec;
>   uintmmcboot;
>   uintvendorspec2;
> - charreserved4[48];
> + uinttuning_ctrl;/* on i.MX6/7/8 */
> + charreserved5[44];
>   uinthostver;/* Host controller version register */
> - charreserved5[4];   /* reserved */
> - uintdmaerraddr; /* DMA error address register */
>   charreserved6[4];   /* reserved */
> - uintdmaerrattr; /* DMA error attribute register */
> + uintdmaerraddr; /* DMA error address register */
>   charreserved7[4];   /* reserved */
> + uintdmaerrattr; /* DMA error attribute register */
> + charreserved8[4];   /* reserved */
>   uinthostcapblt2;/* Host controller capabilities register 2 */
> - charreserved8[8];   /* reserved */
> + charreserved9[8];   /* reserved */
>   uinttcr;/* Tuning control register */
> - charreserved9[28];  /* reserved */
> + charreserved10[28]; /* reserved */
>   uintsddirctl;   /* SD direction control register */
> - charreserved10[712];/* reserved */
> + charreserved11[712];/* reserved */
>   uintscr;/* eSDHC control register */
>  };
>  
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot