Re: [U-Boot] [PATCH u-boot 1/2] net: phy: Add support for accessing MMD PHY registers

2019-01-23 Thread Joe Hershberger
On Wed, Jan 23, 2019 at 8:32 AM Vladimir Oltean wrote: > > On 23.01.2019 11:59, Carlo Caione wrote: > > On 23/01/19 00:04, Joe Hershberger wrote: > >> > >> If we have to override the access then probably so. Maybe it would > >> make more sense to have a v2 from you that removes the duplicate code

Re: [U-Boot] [PATCH u-boot 1/2] net: phy: Add support for accessing MMD PHY registers

2019-01-23 Thread Vladimir Oltean
On 23.01.2019 11:59, Carlo Caione wrote: > On 23/01/19 00:04, Joe Hershberger wrote: >> >> If we have to override the access then probably so. Maybe it would >> make more sense to have a v2 from you that removes the duplicate code >> from the ti phy driver and then have Vlad's smartEEE patch be

Re: [U-Boot] [PATCH u-boot 1/2] net: phy: Add support for accessing MMD PHY registers

2019-01-23 Thread Carlo Caione
On 23/01/19 00:04, Joe Hershberger wrote: If we have to override the access then probably so. Maybe it would make more sense to have a v2 from you that removes the duplicate code from the ti phy driver and then have Vlad's smartEEE patch be rebased on that. I have not yet pushed Vlad's patches

Re: [U-Boot] [PATCH u-boot 1/2] net: phy: Add support for accessing MMD PHY registers

2019-01-22 Thread Joe Hershberger
On Tue, Jan 22, 2019 at 4:54 PM Carlo Caione wrote: > > On 22/01/19 22:21, Joe Hershberger wrote: > >On Wed, Jan 16, 2019 at 12:06 PM Carlo Caione wrote: > >> > >> Two new helper functions (phy_read_mmd() and phy_write_mmd()) are added > >> to allow access to the MMD PHY registers. > >> > >> The

Re: [U-Boot] [PATCH u-boot 1/2] net: phy: Add support for accessing MMD PHY registers

2019-01-22 Thread Carlo Caione
On 22/01/19 22:21, Joe Hershberger wrote: On Wed, Jan 16, 2019 at 12:06 PM Carlo Caione wrote: Two new helper functions (phy_read_mmd() and phy_write_mmd()) are added to allow access to the MMD PHY registers. The MMD PHY registers can be accessed by two means: 1. Using two new MMD access

Re: [U-Boot] [PATCH u-boot 1/2] net: phy: Add support for accessing MMD PHY registers

2019-01-22 Thread Joe Hershberger
On Wed, Jan 16, 2019 at 12:06 PM Carlo Caione wrote: > > Two new helper functions (phy_read_mmd() and phy_write_mmd()) are added > to allow access to the MMD PHY registers. > > The MMD PHY registers can be accessed by two means: > > 1. Using two new MMD access function hooks in the PHY driver.