Re: [U-Boot] [PATCH v2] net: e1000: support 'write_hwaddr' in DM

2018-11-24 Thread Bin Meng
Hi Hannes, On Fri, Nov 23, 2018 at 3:34 PM Hannes Schmelzer wrote: > > > > On 30.10.2018 13:06, Hannes Schmelzer wrote: > > > > On 10/30/2018 09:13 AM, Bin Meng wrote: > >> On Thu, Oct 25, 2018 at 10:25 PM Hannes Schmelzer > >> wrote: > >>> This commit ports the existing (non-DM) function for

Re: [U-Boot] [PATCH v2] net: e1000: support 'write_hwaddr' in DM

2018-11-22 Thread Hannes Schmelzer
On 30.10.2018 13:06, Hannes Schmelzer wrote: On 10/30/2018 09:13 AM, Bin Meng wrote: On Thu, Oct 25, 2018 at 10:25 PM Hannes Schmelzer wrote: This commit ports the existing (non-DM) function for writing the MAC- address into the shadow ram (and flash) for DM. Signed-off-by: Hannes

Re: [U-Boot] [PATCH v2] net: e1000: support 'write_hwaddr' in DM

2018-10-30 Thread Hannes Schmelzer
On 10/30/2018 09:13 AM, Bin Meng wrote: On Thu, Oct 25, 2018 at 10:25 PM Hannes Schmelzer wrote: This commit ports the existing (non-DM) function for writing the MAC- address into the shadow ram (and flash) for DM. Signed-off-by: Hannes Schmelzer --- Changes in v2: - fix build for non-DM

Re: [U-Boot] [PATCH v2] net: e1000: support 'write_hwaddr' in DM

2018-10-30 Thread Bin Meng
On Thu, Oct 25, 2018 at 10:25 PM Hannes Schmelzer wrote: > > This commit ports the existing (non-DM) function for writing the MAC- > address into the shadow ram (and flash) for DM. > > Signed-off-by: Hannes Schmelzer > --- > > Changes in v2: > - fix build for non-DM board > - rebase on current

Re: [U-Boot] [PATCH v2] net: e1000: support 'write_hwaddr' in DM

2018-10-29 Thread Joe Hershberger
On Thu, Oct 25, 2018 at 2:34 PM Hannes Schmelzer wrote: > > > On 10/25/2018 08:41 PM, Joe Hershberger wrote: > > On Thu, Oct 25, 2018 at 9:26 AM Hannes Schmelzer > > wrote: > Hi Joe, > > > >> +* reading the current address failed > >> +*/ > >> + if (!ret_val &&

Re: [U-Boot] [PATCH v2] net: e1000: support 'write_hwaddr' in DM

2018-10-25 Thread Hannes Schmelzer
On 10/25/2018 08:41 PM, Joe Hershberger wrote: On Thu, Oct 25, 2018 at 9:26 AM Hannes Schmelzer wrote: Hi Joe, +* reading the current address failed +*/ + if (!ret_val && memcmp(current_mac, mac, 6) == 0) + return 0; + + for (i = 0; i < 3; ++i) +

Re: [U-Boot] [PATCH v2] net: e1000: support 'write_hwaddr' in DM

2018-10-25 Thread Joe Hershberger
On Thu, Oct 25, 2018 at 9:26 AM Hannes Schmelzer wrote: > > This commit ports the existing (non-DM) function for writing the MAC- > address into the shadow ram (and flash) for DM. > > Signed-off-by: Hannes Schmelzer > --- > > Changes in v2: > - fix build for non-DM board > - rebase on current