Re: [U-Boot] [PATCH v2 1/7] sunxi: gpio: add missing compatible strings

[Andre Przywara]

Hi,

On 09/02/18 11:21, Jagan Teki wrote:
> On Fri, Feb 9, 2018 at 7:00 AM, Andre Przywara  wrote:
>> The sunxi GPIO driver is missing some compatible strings for recent
>> SoCs. While most of the sunxi GPIO code seems to not rely on this (and
>> so works anyway), the sunxi_name_to_gpio() function does and fails at
>> the moment (for instance when resolving the MMC CD pin name).
>> Add the compatible strings for the A64, H5 and V3s, which were missing
>> from the list. This now covers all pinctrl nodes in our own DTs.
>>
>> Signed-off-by: Andre Przywara 
>> ---
>>  drivers/gpio/sunxi_gpio.c | 4 
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c
>> index 3cf01b6e36..90fd7c1596 100644
>> --- a/drivers/gpio/sunxi_gpio.c
>> +++ b/drivers/gpio/sunxi_gpio.c
>> @@ -354,12 +354,16 @@ static const struct udevice_id sunxi_gpio_ids[] = {
>> ID("allwinner,sun8i-a83t-pinctrl",  a_all),
>> ID("allwinner,sun8i-h3-pinctrl",a_all),
>> ID("allwinner,sun8i-r40-pinctrl",   a_all),
>> +   ID("allwinner,sun8i-v3s-pinctrl",   a_all),
>> ID("allwinner,sun9i-a80-pinctrl",   a_all),
>> +   ID("allwinner,sun50i-a64-pinctrl",  a_all),
>> +   ID("allwinner,sun50i-h5-pinctrl",   a_all),
> 
> h5 is already added after sun5i-a13

Ah, indeed, good catch.

Thanks for having a look.

Cheers,
Andre.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/7] sunxi: gpio: add missing compatible strings

[Jagan Teki]

On Fri, Feb 9, 2018 at 7:00 AM, Andre Przywara  wrote:
> The sunxi GPIO driver is missing some compatible strings for recent
> SoCs. While most of the sunxi GPIO code seems to not rely on this (and
> so works anyway), the sunxi_name_to_gpio() function does and fails at
> the moment (for instance when resolving the MMC CD pin name).
> Add the compatible strings for the A64, H5 and V3s, which were missing
> from the list. This now covers all pinctrl nodes in our own DTs.
>
> Signed-off-by: Andre Przywara 
> ---
>  drivers/gpio/sunxi_gpio.c | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c
> index 3cf01b6e36..90fd7c1596 100644
> --- a/drivers/gpio/sunxi_gpio.c
> +++ b/drivers/gpio/sunxi_gpio.c
> @@ -354,12 +354,16 @@ static const struct udevice_id sunxi_gpio_ids[] = {
> ID("allwinner,sun8i-a83t-pinctrl",  a_all),
> ID("allwinner,sun8i-h3-pinctrl",a_all),
> ID("allwinner,sun8i-r40-pinctrl",   a_all),
> +   ID("allwinner,sun8i-v3s-pinctrl",   a_all),
> ID("allwinner,sun9i-a80-pinctrl",   a_all),
> +   ID("allwinner,sun50i-a64-pinctrl",  a_all),
> +   ID("allwinner,sun50i-h5-pinctrl",   a_all),

h5 is already added after sun5i-a13
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot