On Thu, Feb 22, 2018 at 02:33:49PM +0100, Miquel Raynal wrote: > Move the NAND parameters from defconfig files to Kconfig for SUNXI > architecture only. Fort now only the CHIP pro is migrated. > > It would have been better to convert this defconfig entry to Kconfig for > all supported machines/architectures but it has been abandoned due to a > fairly high amount of errors reported by the moveconfig.py tool. This is > probably due to defines quite often being multiplications of > values/other defines not correctly handled. > > Signed-off-by: Miquel Raynal <miquel.ray...@bootlin.com> > --- > configs/CHIP_pro_defconfig | 4 +++- > drivers/mtd/nand/Kconfig | 22 ++++++++++++++++++++++ > 2 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/configs/CHIP_pro_defconfig b/configs/CHIP_pro_defconfig > index 75951bf03b..9f682239bf 100644 > --- a/configs/CHIP_pro_defconfig > +++ b/configs/CHIP_pro_defconfig > @@ -5,7 +5,9 @@ CONFIG_MACH_SUN5I=y > CONFIG_DRAM_TIMINGS_DDR3_800E_1066G_1333J=y > CONFIG_USB0_VBUS_PIN="PB10" > CONFIG_DEFAULT_DEVICE_TREE="sun5i-gr8-chip-pro" > -CONFIG_SYS_EXTRA_OPTIONS="SYS_NAND_BLOCK_SIZE=0x40000,SYS_NAND_PAGE_SIZE=4096,SYS_NAND_OOBSIZE=256" > +CONFIG_SYS_NAND_BLOCK_SIZE=0x40000 > +CONFIG_SYS_NAND_OOBSIZE=0x1000 > +CONFIG_SYS_NAND_OOBSIZE=0x100 > CONFIG_SPL=y > CONFIG_SPL_I2C_SUPPORT=y > # CONFIG_CMD_FLASH is not set > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index cf323c5348..fc930a804c 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -168,6 +168,28 @@ config NAND_ZYNQ_USE_BOOTLOADER1_TIMINGS > > comment "Generic NAND options" > > +config SYS_NAND_BLOCK_SIZE > + hex "NAND chip eraseblock size" > + depends on ARCH_SUNXI > + help > + Number of data bytes in one eraseblock for the NAND chip on the > + board. This is the multiple of NAND_PAGE_SIZE and the number of > + pages.
The indentation here ... > +config SYS_NAND_PAGE_SIZE > + hex "NAND chip page size" > + depends on ARCH_SUNXI > + help > + Number of data bytes in one page for the NAND chip on the > + board, not including the OOB area. ... and here ... > +config SYS_NAND_OOBSIZE > + hex "NAND chip OOB size" > + depends on ARCH_SUNXI > + help > + Number of bytes in the Out-Of-Band area for the NAND chip on > + the board. ... but you somehow got it right here :) Otherwise, Acked-by: Maxime Ripard <maxime.rip...@bootlin.com> Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot