Re: [U-Boot] [PATCH v2 3/4] common/lcd_console: move single static variables into common (static) structure

2015-03-18 Thread Igor Grinberg
On 03/18/15 14:14, Hannes Petermaier wrote: On 2015-03-18 13:11, Igor Grinberg wrote: [...] +struct console_t { +short curr_col, curr_row; +short cols, rows; +void *lcd_address; Shouldn't this be fbbase? +}; +static struct console_t cons; [...] Hi Igor, my plan was/is to

Re: [U-Boot] [PATCH v2 3/4] common/lcd_console: move single static variables into common (static) structure

2015-03-18 Thread Igor Grinberg
On 03/18/15 09:37, Hannes Petermaier wrote: From: Hannes Petermaier hannes.peterma...@br-automation.com For coming implementation of lcd_console rotation, we will need some more variables for holding information about framebuffer size, rotation, ... For better readability we catch all

Re: [U-Boot] [PATCH v2 3/4] common/lcd_console: move single static variables into common (static) structure

2015-03-18 Thread Hannes Petermaier
On 2015-03-18 13:11, Igor Grinberg wrote: [...] +struct console_t { + short curr_col, curr_row; + short cols, rows; + void *lcd_address; Shouldn't this be fbbase? +}; +static struct console_t cons; [...] Hi Igor, my plan was/is to make a cleanup patch after this story is

Re: [U-Boot] [PATCH v2 3/4] common/lcd_console: move single static variables into common (static) structure

2015-03-18 Thread Hannes Petermaier
On 2015-03-18 13:47, Igor Grinberg wrote: On 03/18/15 14:14, Hannes Petermaier wrote: On 2015-03-18 13:11, Igor Grinberg wrote: [...] +struct console_t { +short curr_col, curr_row; +short cols, rows; +void *lcd_address; Shouldn't this be fbbase? +}; +static struct console_t

Re: [U-Boot] [PATCH v2 3/4] common/lcd_console: move single static variables into common (static) structure

2015-03-18 Thread Igor Grinberg
On 03/18/15 17:07, Hannes Petermaier wrote: On 2015-03-18 13:47, Igor Grinberg wrote: On 03/18/15 14:14, Hannes Petermaier wrote: On 2015-03-18 13:11, Igor Grinberg wrote: [...] +struct console_t { +short curr_col, curr_row; +short cols, rows; +void *lcd_address; Shouldn't