Re: [U-Boot] [PATCH v2 5/5] spl: fit: Add booting OS first

2017-08-10 Thread York Sun
On 08/07/2017 04:16 PM, York Sun wrote:
> If CONFIG_SPL_OS_BOOT is enabled, boot OS if kernel image is found
> in FIT structure.
> 
> Signed-off-by: York Sun 
> 
> ---
> This presums the kernel image doesn't exist in a FIT image intended for
> U-Boot. If kernel image normally co-exists with U-Boot and other images
> and user intends to boot U-Boot, this patch needs to rewrite to favor
> "loadables" over either "firmware" or "kernel" so user can select which
> image to boot.

Andre,

Need your comment on this.
Since you created spl_load_simple_fit() and it is used for both loading 
kernel and U-Boot (and other images), it favors "firmware" over 
"loadables" when booting U-Boot. I added CONFIG_SPL_OS_BOOT to favor 
"kernel". However, if your image contains both kernel and U-Boot and you 
intend to boot U-Boot, this will break when CONFIG_SPL_OS_BOOT is 
defined. In this case, I can drop detecting "kernel" and use "loadables" 
to find kernel image.

Please respond.

York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH v2 5/5] spl: fit: Add booting OS first

2017-08-09 Thread Tom Rini
On Mon, Aug 07, 2017 at 04:16:26PM -0700, York Sun wrote:

> If CONFIG_SPL_OS_BOOT is enabled, boot OS if kernel image is found
> in FIT structure.
> 
> Signed-off-by: York Sun 
> 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot