Re: [U-Boot] [PATCH v3 1/2] env_mmc: make board configurable the partition for the environment

2014-02-07 Thread Pantelis Antoniou
Hi Hector,

On Jan 23, 2014, at 2:39 PM, Hector Palacios wrote:

 This complements commit 9404a5fc7cb58 env_mmc: allow environment to be
 in an eMMC partition by allowing boards to accommodate the partition
 to use for the environment in different scenarios (similarly to what is
 done with the mmc dev number). Depending on the detected boot media,
 boards may decide to store the environment in a different partition.
 
 The __weak function also allows to remove some ifdefs from the code.
 If CONFIG_SYS_MMC_ENV_PART is not defined, partition 0 is assumed
 (default value for U-Boot when a partition is not provided).
 
 Signed-off-by: Hector Palacios hector.palac...@digi.com
 Reviewed-by: Stephen Warren swar...@nvidia.com

The patch does not apply cleanly after Tom's mmc patches went in.

Can you please rework and report? Thanks.

Regards

-- Pantelis
  

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v3 1/2] env_mmc: make board configurable the partition for the environment

2014-02-07 Thread Palacios, Hector
Hi Antoniou,

On 02/07/2014 05:26 PM, Pantelis Antoniou wrote:
 Hi Hector,

 On Jan 23, 2014, at 2:39 PM, Hector Palacios wrote:

 This complements commit 9404a5fc7cb58 env_mmc: allow environment to be
 in an eMMC partition by allowing boards to accommodate the partition
 to use for the environment in different scenarios (similarly to what is
 done with the mmc dev number). Depending on the detected boot media,
 boards may decide to store the environment in a different partition.

 The __weak function also allows to remove some ifdefs from the code.
 If CONFIG_SYS_MMC_ENV_PART is not defined, partition 0 is assumed
 (default value for U-Boot when a partition is not provided).

 Signed-off-by: Hector Palacios hector.palac...@digi.com
 Reviewed-by: Stephen Warren swar...@nvidia.com

 The patch does not apply cleanly after Tom's mmc patches went in.

 Can you please rework and report? Thanks.

Ooops. I'm afraid I applied this after an unofficial non-upstream Freescale 
patch.
Without it, this series just doesn't fit. I would need to resend a version that 
includes Freescale missing patch, and have this reviewed.

Sorry about that.
-- 
Héctor Palacios
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v3 1/2] env_mmc: make board configurable the partition for the environment

2014-01-23 Thread Otavio Salvador
On Thu, Jan 23, 2014 at 10:39 AM, Hector Palacios
hector.palac...@digi.com wrote:
 This complements commit 9404a5fc7cb58 env_mmc: allow environment to be
 in an eMMC partition by allowing boards to accommodate the partition
 to use for the environment in different scenarios (similarly to what is
 done with the mmc dev number). Depending on the detected boot media,
 boards may decide to store the environment in a different partition.

 The __weak function also allows to remove some ifdefs from the code.
 If CONFIG_SYS_MMC_ENV_PART is not defined, partition 0 is assumed
 (default value for U-Boot when a partition is not provided).

 Signed-off-by: Hector Palacios hector.palac...@digi.com
 Reviewed-by: Stephen Warren swar...@nvidia.com

Acked-by: Otavio Salvador ota...@ossystems.com.br


-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot