Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-10 Thread Marek Vasut
On Monday, November 10, 2014 at 02:01:50 AM, Peng Fan wrote: [...] + in usb_phy_mode, query a PHY for it's mode. And righter after usb_phy_enable in ehci-mx6.c. - type = usb_phy_enable(index, ehci) ? USB_INIT_DEVICE : USB_INIT_HOST; + usb_phy_enable(index, ehci); +

Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-09 Thread Peng Fan
On 11/8/2014 7:33 PM, Marek Vasut wrote: On Saturday, November 08, 2014 at 05:07:21 AM, Peng Fan wrote: 在 11/7/2014 8:17 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:45:51 PM, Peng Fan wrote: 在 11/7/2014 7:09 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:03:30 PM, Peng

Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-08 Thread Marek Vasut
On Saturday, November 08, 2014 at 05:07:21 AM, Peng Fan wrote: 在 11/7/2014 8:17 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:45:51 PM, Peng Fan wrote: 在 11/7/2014 7:09 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:03:30 PM, Peng Fan wrote: [...] @@ -160,7 +174,7

Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-07 Thread Marek Vasut
On Friday, November 07, 2014 at 02:08:12 AM, Peng Fan wrote: Include a weak function board_usb_phy_mode. usb_phy_enable decide whether the controller in device mode or in host mode by '*phy_ctrl USBPHY_CTRL_OTG_ID'. There are two usb port on mx6sxsabresd and also mx6slevk. 1. OTG port

Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-07 Thread Peng Fan
在 11/7/2014 4:25 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 02:08:12 AM, Peng Fan wrote: Include a weak function board_usb_phy_mode. usb_phy_enable decide whether the controller in device mode or in host mode by '*phy_ctrl USBPHY_CTRL_OTG_ID'. There are two usb port on

Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-07 Thread Marek Vasut
On Friday, November 07, 2014 at 12:03:30 PM, Peng Fan wrote: [...] @@ -160,7 +174,7 @@ static int usb_phy_enable(int index, struct usb_ehci *ehci) val |= (USBPHY_CTRL_ENUTMILEVEL2 | USBPHY_CTRL_ENUTMILEVEL3); __raw_writel(val, phy_ctrl); - return val USBPHY_CTRL_OTG_ID; +

Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-07 Thread Peng Fan
在 11/7/2014 7:09 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:03:30 PM, Peng Fan wrote: [...] @@ -160,7 +174,7 @@ static int usb_phy_enable(int index, struct usb_ehci *ehci) val |= (USBPHY_CTRL_ENUTMILEVEL2 | USBPHY_CTRL_ENUTMILEVEL3); __raw_writel(val, phy_ctrl); -

Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-07 Thread Marek Vasut
On Friday, November 07, 2014 at 12:45:51 PM, Peng Fan wrote: 在 11/7/2014 7:09 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:03:30 PM, Peng Fan wrote: [...] @@ -160,7 +174,7 @@ static int usb_phy_enable(int index, struct usb_ehci *ehci) val |= (USBPHY_CTRL_ENUTMILEVEL2 |

Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-07 Thread Peng Fan
在 11/7/2014 8:17 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:45:51 PM, Peng Fan wrote: 在 11/7/2014 7:09 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:03:30 PM, Peng Fan wrote: [...] @@ -160,7 +174,7 @@ static int usb_phy_enable(int index, struct usb_ehci *ehci) val |=

Re: [U-Boot] [PATCH v3 1/3] usb:ehci-mx6 add board_usb_phy_mode function

2014-11-07 Thread Peng Fan
在 11/8/2014 12:07 PM, Peng Fan 写道: 在 11/7/2014 8:17 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:45:51 PM, Peng Fan wrote: 在 11/7/2014 7:09 PM, Marek Vasut 写道: On Friday, November 07, 2014 at 12:03:30 PM, Peng Fan wrote: [...] @@ -160,7 +174,7 @@ static int usb_phy_enable(int