Re: [U-Boot] [PATCH v3 3/6] power: pmic: Palmas: Add the base pmic support

2016-09-25 Thread Keerthy 



On Friday 23 September 2016 09:45 AM, Simon Glass wrote:

Hi,

On 19 September 2016 at 00:17, Keerthy  wrote:

Add support to bind the regulators/child nodes with the pmic.

Signed-off-by: Keerthy 
Reviewed-by: Simon Glass 
---
 drivers/power/pmic/Kconfig  |  7 +
 drivers/power/pmic/Makefile |  1 +
 drivers/power/pmic/palmas.c | 77 +
 include/power/palmas.h  | 25 +++
 4 files changed, 110 insertions(+)
 create mode 100644 drivers/power/pmic/palmas.c
 create mode 100644 include/power/palmas.h


I missed it before, but you should use debug() in drivers, not printf().


Sure. I will fix that in the next version.



Regards,
Simon


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 3/6] power: pmic: Palmas: Add the base pmic support

2016-09-22 Thread Simon Glass 
Hi,

On 19 September 2016 at 00:17, Keerthy  wrote:
> Add support to bind the regulators/child nodes with the pmic.
>
> Signed-off-by: Keerthy 
> Reviewed-by: Simon Glass 
> ---
>  drivers/power/pmic/Kconfig  |  7 +
>  drivers/power/pmic/Makefile |  1 +
>  drivers/power/pmic/palmas.c | 77 
> +
>  include/power/palmas.h  | 25 +++
>  4 files changed, 110 insertions(+)
>  create mode 100644 drivers/power/pmic/palmas.c
>  create mode 100644 include/power/palmas.h

I missed it before, but you should use debug() in drivers, not printf().

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 3/6] power: pmic: Palmas: Add the base pmic support

2016-09-19 Thread Tom Rini 
On Mon, Sep 19, 2016 at 11:47:35AM +0530, Keerthy wrote:

> Add support to bind the regulators/child nodes with the pmic.
> 
> Signed-off-by: Keerthy 
> Reviewed-by: Simon Glass 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot