Re: [U-Boot] [PATCH v4 18/27] drivers: qe: add TFABOOT support
On 10/25/18 01:34, Rajesh Bhagat wrote: > > >> -Original Message- >> From: York Sun >> Sent: Monday, October 22, 2018 9:55 PM >> To: Rajesh Bhagat ; u-boot@lists.denx.de >> Cc: Prabhakar Kushwaha ; Pankit Garg >> >> Subject: Re: [PATCH v4 18/27] drivers: qe: add TFABOOT support >> >> On 10/12/18 07:45, Rajesh Bhagat wrote: >>> Adds TFABOOT support and allows to pick QE firmware on basis of boot >>> source. >>> >>> Signed-off-by: Pankit Garg >>> Signed-off-by: Rajesh Bhagat >>> --- >>> Change in v4: None >>> >>> Change in v3: None >>> >>> Change in v2: >>> - Removed extra CONFIG_TFABOOT flag usage >>> >>> drivers/qe/qe.c | 81 >>> + >>> 1 file changed, 81 insertions(+) >>> >>> diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c index >>> 7010bbc230..daefb5aa07 100644 >>> --- a/drivers/qe/qe.c >>> +++ b/drivers/qe/qe.c >>> @@ -17,9 +17,17 @@ >>> #include >>> #endif >>> >>> +#ifdef CONFIG_TFABOOT >>> +#include >>> +/* required to include IFC and QSPI base address */ #include >>> + #include #include >> >>> +#else >>> #ifdef CONFIG_SYS_QE_FMAN_FW_IN_MMC >>> #include >>> #endif >>> +#endif >>> >> >> >> Would there be any conflict if you drop the #ifdef here? No need to respin >> the >> patch set for this change. I can fix it for you if you confirm. >> > > AFAIR, there was some conflict. Shall I check it again. Please check. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 18/27] drivers: qe: add TFABOOT support
> -Original Message- > From: York Sun > Sent: Monday, October 22, 2018 9:55 PM > To: Rajesh Bhagat ; u-boot@lists.denx.de > Cc: Prabhakar Kushwaha ; Pankit Garg > > Subject: Re: [PATCH v4 18/27] drivers: qe: add TFABOOT support > > On 10/12/18 07:45, Rajesh Bhagat wrote: > > Adds TFABOOT support and allows to pick QE firmware on basis of boot > > source. > > > > Signed-off-by: Pankit Garg > > Signed-off-by: Rajesh Bhagat > > --- > > Change in v4: None > > > > Change in v3: None > > > > Change in v2: > > - Removed extra CONFIG_TFABOOT flag usage > > > > drivers/qe/qe.c | 81 > > + > > 1 file changed, 81 insertions(+) > > > > diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c index > > 7010bbc230..daefb5aa07 100644 > > --- a/drivers/qe/qe.c > > +++ b/drivers/qe/qe.c > > @@ -17,9 +17,17 @@ > > #include > > #endif > > > > +#ifdef CONFIG_TFABOOT > > +#include > > +/* required to include IFC and QSPI base address */ #include > > + #include #include > > > +#else > > #ifdef CONFIG_SYS_QE_FMAN_FW_IN_MMC > > #include > > #endif > > +#endif > > > > > Would there be any conflict if you drop the #ifdef here? No need to respin the > patch set for this change. I can fix it for you if you confirm. > AFAIR, there was some conflict. Shall I check it again. > York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v4 18/27] drivers: qe: add TFABOOT support
On 10/12/18 07:45, Rajesh Bhagat wrote: > Adds TFABOOT support and allows to pick QE firmware > on basis of boot source. > > Signed-off-by: Pankit Garg > Signed-off-by: Rajesh Bhagat > --- > Change in v4: None > > > Change in v3: None > > > > Change in v2: > > - Removed extra CONFIG_TFABOOT flag usage > > drivers/qe/qe.c | 81 + > 1 file changed, 81 insertions(+) > > diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c > index 7010bbc230..daefb5aa07 100644 > --- a/drivers/qe/qe.c > +++ b/drivers/qe/qe.c > @@ -17,9 +17,17 @@ > #include > #endif > > +#ifdef CONFIG_TFABOOT > +#include > +/* required to include IFC and QSPI base address */ > +#include > +#include > +#include > +#else > #ifdef CONFIG_SYS_QE_FMAN_FW_IN_MMC > #include > #endif > +#endif > Would there be any conflict if you drop the #ifdef here? No need to respin the patch set for this change. I can fix it for you if you confirm. York ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
