Re: [U-Boot] [PATCH v5] ARM: sun71: dts: add support for Bananapi BPI-R1

[Jagan Teki]

On Fri, Oct 14, 2016 at 4:58 AM, Stephen Arnold
 wrote:
> Okay, rebased on u-boot master again and updated the config for
> i2c/spl.  I have an RFC patch for u-boot and an updated kernel dts to
> test; I also brought in the (small) sun7i-a20.dtsi patch to add the
> standard A20 i2c4 pins_a which is the only i2c brought out on the Pi
> header (goes with pin fix for uart3).
>
> Since this is not quite what I'm running now, and I had to go back and
> trace some wiring on the schematic for USB, I think I've got it dialed
> in now, so I'll test it when my kernel is finished.
>
> If that looks good, I'll make a kernel patch and try that list for a change...

OK, please send.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v5] ARM: sun71: dts: add support for Bananapi BPI-R1

[Stephen Arnold]

Okay, rebased on u-boot master again and updated the config for
i2c/spl.  I have an RFC patch for u-boot and an updated kernel dts to
test; I also brought in the (small) sun7i-a20.dtsi patch to add the
standard A20 i2c4 pins_a which is the only i2c brought out on the Pi
header (goes with pin fix for uart3).

Since this is not quite what I'm running now, and I had to go back and
trace some wiring on the schematic for USB, I think I've got it dialed
in now, so I'll test it when my kernel is finished.

If that looks good, I'll make a kernel patch and try that list for a change...

Thanks, Steve

On Wed, Oct 12, 2016 at 9:27 AM, Jagan Teki  wrote:
> On Wed, Oct 12, 2016 at 12:18 AM, Stephen Arnold
>  wrote:
>> Okay, but I could use a little clarity; do you want the u-boot dts to
>> look just like my (proposed) kernel dts?  Or do I start with kernel
>> dts and remove the gmac/axp209 stuff?
>>
>> If we can merge all of this feedback into a single list of changes,
>> then I can take a whack at it later this week (after a few work
>> things).  Back to the test mtg...
>
> Please take a reference of Linux dts and add tested nodes/properties,
> this would be certainly gives a better understanding and maintenance
> easy.
>
> thanks!
> --
> Jagan Teki
> Free Software Engineer | www.openedev.com
> U-Boot, Linux | Upstream Maintainer
> Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v5] ARM: sun71: dts: add support for Bananapi BPI-R1

[Jagan Teki]

On Wed, Oct 12, 2016 at 12:18 AM, Stephen Arnold
 wrote:
> Okay, but I could use a little clarity; do you want the u-boot dts to
> look just like my (proposed) kernel dts?  Or do I start with kernel
> dts and remove the gmac/axp209 stuff?
>
> If we can merge all of this feedback into a single list of changes,
> then I can take a whack at it later this week (after a few work
> things).  Back to the test mtg...

Please take a reference of Linux dts and add tested nodes/properties,
this would be certainly gives a better understanding and maintenance
easy.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v5] ARM: sun71: dts: add support for Bananapi BPI-R1

[Stephen Arnold]

Okay, but I could use a little clarity; do you want the u-boot dts to
look just like my (proposed) kernel dts?  Or do I start with kernel
dts and remove the gmac/axp209 stuff?

If we can merge all of this feedback into a single list of changes,
then I can take a whack at it later this week (after a few work
things).  Back to the test mtg...

Thanks in advance, Steve

On Mon, Oct 10, 2016 at 3:34 AM, Jagan Teki  wrote:
> On Mon, Oct 10, 2016 at 2:34 AM, Stephen Arnold
>  wrote:
>> From: Steve Arnold 
>>
>> * changes from lamobo-r1 required include:
>>   - unset ahci power pin
>>   - usbvbus gpio pin change
>>   - mmc cd gpio pin change
>>   - enable uart2, set default LED trigger
>>   - CONFIG_GMAC_TX_DELAY change
>>
>> Changes for v2:
>>   - incorprated feedback for config options (remove 3, add 1)
>> Changes for v3/v4:
>>   - re-submit (no change to patch payload) with cover
>> Changes for v5:
>>   - re-submit as one patch (no change to patch payload)
>>
>> Signed-off-by: Steve Arnold 
>> Cc: Ian Campbell 
>> Cc: Hans De Goede 
>>
>>  arch/arm/dts/Makefile  |   1 +
>>  arch/arm/dts/sun7i-a20-bananapi-r1.dts | 376 
>> +
>>  configs/Bananapi_R1_defconfig  |  16 ++
>>  3 files changed, 393 insertions(+)
>>  create mode 100644 arch/arm/dts/sun7i-a20-bananapi-r1.dts
>>  create mode 100644 configs/Bananapi_R1_defconfig
>>
>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>> index 8458f6b..8aa8646 100644
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -217,6 +217,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
>> sun7i-a20-ainol-aw1.dtb \
>> sun7i-a20-bananapi.dtb \
>> sun7i-a20-bananapi-m1-plus.dtb \
>> +   sun7i-a20-bananapi-r1.dtb \
>> sun7i-a20-bananapro.dtb \
>> sun7i-a20-cubieboard2.dtb \
>> sun7i-a20-cubietruck.dtb \
>> diff --git a/arch/arm/dts/sun7i-a20-bananapi-r1.dts 
>> b/arch/arm/dts/sun7i-a20-bananapi-r1.dts
>> new file mode 100644
>> index 000..1a550f9
>> --- /dev/null
>> +++ b/arch/arm/dts/sun7i-a20-bananapi-r1.dts
>> @@ -0,0 +1,376 @@
>> +/*
>> + * Copyright 2015 Hans de Goede 
>> + * Changes copyright 2016 Stephen Arnold 
>
> Remove "Changes" text and add your copy on top, it some how look take
> reference from Hans.
>
>> + *
>> + * This file is dual-licensed: you can use it either under the terms
>> + * of the GPL or the X11 license, at your option. Note that this dual
>> + * licensing only applies to this file, and not this project as a
>> + * whole.
>> + *
>> + *  a) This file is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 of the
>> + * License, or (at your option) any later version.
>> + *
>> + * This file is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * Or, alternatively,
>> + *
>> + *  b) Permission is hereby granted, free of charge, to any person
>> + * obtaining a copy of this software and associated documentation
>> + * files (the "Software"), to deal in the Software without
>> + * restriction, including without limitation the rights to use,
>> + * copy, modify, merge, publish, distribute, sublicense, and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> + * Software is furnished to do so, subject to the following
>> + * conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> + * included in all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
>> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
>> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
>> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
>> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>> + * OTHER DEALINGS IN THE SOFTWARE.
>> + */
>> +
>> +/dts-v1/;
>> +#include "sun7i-a20.dtsi"
>> +#include "sunxi-common-regulators.dtsi"
>> +
>> +#include 
>> +#include 
>> +#include 
>> +
>> +/ {
>> +   model = "Banana Pi BPI-R1";
>> +   compatible = "sinovoip,bpi-r1", "allwinner,sun7i-a20";
>> +
>> +   aliases {
>> +   serial0 = 
>> +   serial1 = 
>> +   serial2 = 
>> +   serial3 = 
>> +   

Re: [U-Boot] [PATCH v5] ARM: sun71: dts: add support for Bananapi BPI-R1

[Jagan Teki]

On Mon, Oct 10, 2016 at 2:34 AM, Stephen Arnold
 wrote:
> From: Steve Arnold 
>
> * changes from lamobo-r1 required include:
>   - unset ahci power pin
>   - usbvbus gpio pin change
>   - mmc cd gpio pin change
>   - enable uart2, set default LED trigger
>   - CONFIG_GMAC_TX_DELAY change
>
> Changes for v2:
>   - incorprated feedback for config options (remove 3, add 1)
> Changes for v3/v4:
>   - re-submit (no change to patch payload) with cover
> Changes for v5:
>   - re-submit as one patch (no change to patch payload)
>
> Signed-off-by: Steve Arnold 
> Cc: Ian Campbell 
> Cc: Hans De Goede 
>
>  arch/arm/dts/Makefile  |   1 +
>  arch/arm/dts/sun7i-a20-bananapi-r1.dts | 376 
> +
>  configs/Bananapi_R1_defconfig  |  16 ++
>  3 files changed, 393 insertions(+)
>  create mode 100644 arch/arm/dts/sun7i-a20-bananapi-r1.dts
>  create mode 100644 configs/Bananapi_R1_defconfig
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 8458f6b..8aa8646 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -217,6 +217,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
> sun7i-a20-ainol-aw1.dtb \
> sun7i-a20-bananapi.dtb \
> sun7i-a20-bananapi-m1-plus.dtb \
> +   sun7i-a20-bananapi-r1.dtb \
> sun7i-a20-bananapro.dtb \
> sun7i-a20-cubieboard2.dtb \
> sun7i-a20-cubietruck.dtb \
> diff --git a/arch/arm/dts/sun7i-a20-bananapi-r1.dts 
> b/arch/arm/dts/sun7i-a20-bananapi-r1.dts
> new file mode 100644
> index 000..1a550f9
> --- /dev/null
> +++ b/arch/arm/dts/sun7i-a20-bananapi-r1.dts
> @@ -0,0 +1,376 @@
> +/*
> + * Copyright 2015 Hans de Goede 
> + * Changes copyright 2016 Stephen Arnold 

Remove "Changes" text and add your copy on top, it some how look take
reference from Hans.

> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This file is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +#include "sun7i-a20.dtsi"
> +#include "sunxi-common-regulators.dtsi"
> +
> +#include 
> +#include 
> +#include 
> +
> +/ {
> +   model = "Banana Pi BPI-R1";
> +   compatible = "sinovoip,bpi-r1", "allwinner,sun7i-a20";
> +
> +   aliases {
> +   serial0 = 
> +   serial1 = 
> +   serial2 = 
> +   serial3 = 
> +   };
> +
> +   chosen {
> +   stdout-path = "serial0:115200n8";
> +   };
> +
> +   leds {
> +   compatible = "gpio-leds";
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_pins_bpi_r1>;
> +
> +   green {
> +   label = "bpi-r1:green:usr";
> +   gpios = < 7 24 GPIO_ACTIVE_HIGH>; /* PH24 */
> +   linux,default-trigger = "heartbeat";

This property not needed, skip this.

> +   };
> +   };
> +
> +   reg_gmac_3v3: