Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 11/03/2016 03:21 PM, Dinh Nguyen wrote:
> 
> 
> On 11/02/2016 03:47 PM, Marek Vasut wrote:
>> On 11/02/2016 05:30 PM, Dinh Nguyen wrote:
>>> On Tue, Nov 1, 2016 at 3:43 PM, Dinh Nguyen  wrote:


 On 11/01/2016 03:42 PM, Marek Vasut wrote:
> On 11/01/2016 09:39 PM, Dinh Nguyen wrote:
>>
>>
>> On 11/01/2016 03:09 PM, Marek Vasut wrote:
>>> On 11/01/2016 04:43 PM, Dinh Nguyen wrote:


 On 10/29/2016 02:59 PM, Marek Vasut wrote:
> On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
>> On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
>>> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:


 On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
> Hi,
>
> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA 
> platform makes
> use of the PL330 to transfer zereos to the SDRAM which enables 
> the ECC bit.
>
> This is only an RFC because after rebasing to v2016.11-rc1, I had 
> to revert
> the following patch "a78cd8613204 ARM: Rework and correct barrier 
> definitions"
> in order for this patch set to work correctly. With the above 
> patch applied,
> after the SDRAM scrubbing is complete, the SPL is failing to find 
> the MMC
> device.
>

 I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
 barrier definitions" is causing SPL to fail after the SDRAM scrub
 operation. It appears that before the above mentioned patch, the 
 dmb()
 operation is defined as this:

 #define dmb()  __asm__ __volatile__ ("" : : : "memory")

 after the patch, the dmb is now:

 #define DMBasm volatile ("dmb sy" : : : "memory")

 So the "dmb sy" as described in the ARM documentation is a "Full 
 system
 DMB operation". For whatever reason, this change is causing the SPL
 error after the SDRAM scrub operation.
>>>
>>> Thanks for looking into this, can you poke into it some more ?
>>>
>>
>> Of course..
>
> The patch is causing a failure even in normal operation -- if you boot
> the socfpga board and type "reset", it won't reset with the patch.
>

 Can I ask what board are you seeing this on? I'm seeing that on my 
 Atlas
 board, it does not reset properly(even with the patch reverted). But
 "reset" is working fine on my devkit, with and without the patch.
>>>
>>> SoCKit and MCVEVK.
>>>
>>> I tried bisecting it, it worked on 2016.07 and doesn't on 2016.09 , and
>>> I arrived at this patch. Maybe you can double-check this ?
>>>
>>
>> Okay, I can check it on the SoCKit.
>
> It also happens on MCVEVK, but that's probably moot for your test ;-)
>

 I don't have an MCVEVK.

>>>
>>> The "reset" functionality is working fine on the SoCKit with 2016.11-rc3.
>>
>> Does it work on 2016.09.01 too ?
>>
> 
> Yes...reset works fine on 2016.09.01 and 2016.09 on my SoCKit.
> 
> Dinh
> 
Well it doesn't work on mine ... compiler problem ?

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Dinh Nguyen]

On 11/02/2016 03:47 PM, Marek Vasut wrote:
> On 11/02/2016 05:30 PM, Dinh Nguyen wrote:
>> On Tue, Nov 1, 2016 at 3:43 PM, Dinh Nguyen  wrote:
>>>
>>>
>>> On 11/01/2016 03:42 PM, Marek Vasut wrote:
 On 11/01/2016 09:39 PM, Dinh Nguyen wrote:
>
>
> On 11/01/2016 03:09 PM, Marek Vasut wrote:
>> On 11/01/2016 04:43 PM, Dinh Nguyen wrote:
>>>
>>>
>>> On 10/29/2016 02:59 PM, Marek Vasut wrote:
 On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
> On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
>> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
>>>
>>>
>>> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
 Hi,

 This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA 
 platform makes
 use of the PL330 to transfer zereos to the SDRAM which enables the 
 ECC bit.

 This is only an RFC because after rebasing to v2016.11-rc1, I had 
 to revert
 the following patch "a78cd8613204 ARM: Rework and correct barrier 
 definitions"
 in order for this patch set to work correctly. With the above 
 patch applied,
 after the SDRAM scrubbing is complete, the SPL is failing to find 
 the MMC
 device.

>>>
>>> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
>>> barrier definitions" is causing SPL to fail after the SDRAM scrub
>>> operation. It appears that before the above mentioned patch, the 
>>> dmb()
>>> operation is defined as this:
>>>
>>> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
>>>
>>> after the patch, the dmb is now:
>>>
>>> #define DMBasm volatile ("dmb sy" : : : "memory")
>>>
>>> So the "dmb sy" as described in the ARM documentation is a "Full 
>>> system
>>> DMB operation". For whatever reason, this change is causing the SPL
>>> error after the SDRAM scrub operation.
>>
>> Thanks for looking into this, can you poke into it some more ?
>>
>
> Of course..

 The patch is causing a failure even in normal operation -- if you boot
 the socfpga board and type "reset", it won't reset with the patch.

>>>
>>> Can I ask what board are you seeing this on? I'm seeing that on my Atlas
>>> board, it does not reset properly(even with the patch reverted). But
>>> "reset" is working fine on my devkit, with and without the patch.
>>
>> SoCKit and MCVEVK.
>>
>> I tried bisecting it, it worked on 2016.07 and doesn't on 2016.09 , and
>> I arrived at this patch. Maybe you can double-check this ?
>>
>
> Okay, I can check it on the SoCKit.

 It also happens on MCVEVK, but that's probably moot for your test ;-)

>>>
>>> I don't have an MCVEVK.
>>>
>>
>> The "reset" functionality is working fine on the SoCKit with 2016.11-rc3.
> 
> Does it work on 2016.09.01 too ?
> 

Yes...reset works fine on 2016.09.01 and 2016.09 on my SoCKit.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 11/02/2016 05:30 PM, Dinh Nguyen wrote:
> On Tue, Nov 1, 2016 at 3:43 PM, Dinh Nguyen  wrote:
>>
>>
>> On 11/01/2016 03:42 PM, Marek Vasut wrote:
>>> On 11/01/2016 09:39 PM, Dinh Nguyen wrote:


 On 11/01/2016 03:09 PM, Marek Vasut wrote:
> On 11/01/2016 04:43 PM, Dinh Nguyen wrote:
>>
>>
>> On 10/29/2016 02:59 PM, Marek Vasut wrote:
>>> On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
 On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
>>
>>
>> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
>>> Hi,
>>>
>>> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA 
>>> platform makes
>>> use of the PL330 to transfer zereos to the SDRAM which enables the 
>>> ECC bit.
>>>
>>> This is only an RFC because after rebasing to v2016.11-rc1, I had 
>>> to revert
>>> the following patch "a78cd8613204 ARM: Rework and correct barrier 
>>> definitions"
>>> in order for this patch set to work correctly. With the above patch 
>>> applied,
>>> after the SDRAM scrubbing is complete, the SPL is failing to find 
>>> the MMC
>>> device.
>>>
>>
>> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
>> barrier definitions" is causing SPL to fail after the SDRAM scrub
>> operation. It appears that before the above mentioned patch, the 
>> dmb()
>> operation is defined as this:
>>
>> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
>>
>> after the patch, the dmb is now:
>>
>> #define DMBasm volatile ("dmb sy" : : : "memory")
>>
>> So the "dmb sy" as described in the ARM documentation is a "Full 
>> system
>> DMB operation". For whatever reason, this change is causing the SPL
>> error after the SDRAM scrub operation.
>
> Thanks for looking into this, can you poke into it some more ?
>

 Of course..
>>>
>>> The patch is causing a failure even in normal operation -- if you boot
>>> the socfpga board and type "reset", it won't reset with the patch.
>>>
>>
>> Can I ask what board are you seeing this on? I'm seeing that on my Atlas
>> board, it does not reset properly(even with the patch reverted). But
>> "reset" is working fine on my devkit, with and without the patch.
>
> SoCKit and MCVEVK.
>
> I tried bisecting it, it worked on 2016.07 and doesn't on 2016.09 , and
> I arrived at this patch. Maybe you can double-check this ?
>

 Okay, I can check it on the SoCKit.
>>>
>>> It also happens on MCVEVK, but that's probably moot for your test ;-)
>>>
>>
>> I don't have an MCVEVK.
>>
> 
> The "reset" functionality is working fine on the SoCKit with 2016.11-rc3.

Does it work on 2016.09.01 too ?

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Dinh Nguyen]

On Tue, Nov 1, 2016 at 3:43 PM, Dinh Nguyen  wrote:
>
>
> On 11/01/2016 03:42 PM, Marek Vasut wrote:
>> On 11/01/2016 09:39 PM, Dinh Nguyen wrote:
>>>
>>>
>>> On 11/01/2016 03:09 PM, Marek Vasut wrote:
 On 11/01/2016 04:43 PM, Dinh Nguyen wrote:
>
>
> On 10/29/2016 02:59 PM, Marek Vasut wrote:
>> On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
>>> On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
 On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
>
>
> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
>> Hi,
>>
>> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA 
>> platform makes
>> use of the PL330 to transfer zereos to the SDRAM which enables the 
>> ECC bit.
>>
>> This is only an RFC because after rebasing to v2016.11-rc1, I had to 
>> revert
>> the following patch "a78cd8613204 ARM: Rework and correct barrier 
>> definitions"
>> in order for this patch set to work correctly. With the above patch 
>> applied,
>> after the SDRAM scrubbing is complete, the SPL is failing to find 
>> the MMC
>> device.
>>
>
> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
> barrier definitions" is causing SPL to fail after the SDRAM scrub
> operation. It appears that before the above mentioned patch, the dmb()
> operation is defined as this:
>
> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
>
> after the patch, the dmb is now:
>
> #define DMBasm volatile ("dmb sy" : : : "memory")
>
> So the "dmb sy" as described in the ARM documentation is a "Full 
> system
> DMB operation". For whatever reason, this change is causing the SPL
> error after the SDRAM scrub operation.

 Thanks for looking into this, can you poke into it some more ?

>>>
>>> Of course..
>>
>> The patch is causing a failure even in normal operation -- if you boot
>> the socfpga board and type "reset", it won't reset with the patch.
>>
>
> Can I ask what board are you seeing this on? I'm seeing that on my Atlas
> board, it does not reset properly(even with the patch reverted). But
> "reset" is working fine on my devkit, with and without the patch.

 SoCKit and MCVEVK.

 I tried bisecting it, it worked on 2016.07 and doesn't on 2016.09 , and
 I arrived at this patch. Maybe you can double-check this ?

>>>
>>> Okay, I can check it on the SoCKit.
>>
>> It also happens on MCVEVK, but that's probably moot for your test ;-)
>>
>
> I don't have an MCVEVK.
>

The "reset" functionality is working fine on the SoCKit with 2016.11-rc3.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Dinh Nguyen]

On 11/01/2016 03:42 PM, Marek Vasut wrote:
> On 11/01/2016 09:39 PM, Dinh Nguyen wrote:
>>
>>
>> On 11/01/2016 03:09 PM, Marek Vasut wrote:
>>> On 11/01/2016 04:43 PM, Dinh Nguyen wrote:


 On 10/29/2016 02:59 PM, Marek Vasut wrote:
> On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
>> On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
>>> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:


 On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
> Hi,
>
> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA 
> platform makes
> use of the PL330 to transfer zereos to the SDRAM which enables the 
> ECC bit.
>
> This is only an RFC because after rebasing to v2016.11-rc1, I had to 
> revert
> the following patch "a78cd8613204 ARM: Rework and correct barrier 
> definitions"
> in order for this patch set to work correctly. With the above patch 
> applied,
> after the SDRAM scrubbing is complete, the SPL is failing to find the 
> MMC
> device.
>

 I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
 barrier definitions" is causing SPL to fail after the SDRAM scrub
 operation. It appears that before the above mentioned patch, the dmb()
 operation is defined as this:

 #define dmb()  __asm__ __volatile__ ("" : : : "memory")

 after the patch, the dmb is now:

 #define DMBasm volatile ("dmb sy" : : : "memory")

 So the "dmb sy" as described in the ARM documentation is a "Full system
 DMB operation". For whatever reason, this change is causing the SPL
 error after the SDRAM scrub operation.
>>>
>>> Thanks for looking into this, can you poke into it some more ?
>>>
>>
>> Of course..
>
> The patch is causing a failure even in normal operation -- if you boot
> the socfpga board and type "reset", it won't reset with the patch.
>

 Can I ask what board are you seeing this on? I'm seeing that on my Atlas
 board, it does not reset properly(even with the patch reverted). But
 "reset" is working fine on my devkit, with and without the patch.
>>>
>>> SoCKit and MCVEVK.
>>>
>>> I tried bisecting it, it worked on 2016.07 and doesn't on 2016.09 , and
>>> I arrived at this patch. Maybe you can double-check this ?
>>>
>>
>> Okay, I can check it on the SoCKit.
> 
> It also happens on MCVEVK, but that's probably moot for your test ;-)
> 

I don't have an MCVEVK.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 11/01/2016 09:39 PM, Dinh Nguyen wrote:
> 
> 
> On 11/01/2016 03:09 PM, Marek Vasut wrote:
>> On 11/01/2016 04:43 PM, Dinh Nguyen wrote:
>>>
>>>
>>> On 10/29/2016 02:59 PM, Marek Vasut wrote:
 On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
> On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
>> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
>>>
>>>
>>> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
 Hi,

 This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA 
 platform makes
 use of the PL330 to transfer zereos to the SDRAM which enables the ECC 
 bit.

 This is only an RFC because after rebasing to v2016.11-rc1, I had to 
 revert
 the following patch "a78cd8613204 ARM: Rework and correct barrier 
 definitions"
 in order for this patch set to work correctly. With the above patch 
 applied,
 after the SDRAM scrubbing is complete, the SPL is failing to find the 
 MMC
 device.

>>>
>>> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
>>> barrier definitions" is causing SPL to fail after the SDRAM scrub
>>> operation. It appears that before the above mentioned patch, the dmb()
>>> operation is defined as this:
>>>
>>> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
>>>
>>> after the patch, the dmb is now:
>>>
>>> #define DMBasm volatile ("dmb sy" : : : "memory")
>>>
>>> So the "dmb sy" as described in the ARM documentation is a "Full system
>>> DMB operation". For whatever reason, this change is causing the SPL
>>> error after the SDRAM scrub operation.
>>
>> Thanks for looking into this, can you poke into it some more ?
>>
>
> Of course..

 The patch is causing a failure even in normal operation -- if you boot
 the socfpga board and type "reset", it won't reset with the patch.

>>>
>>> Can I ask what board are you seeing this on? I'm seeing that on my Atlas
>>> board, it does not reset properly(even with the patch reverted). But
>>> "reset" is working fine on my devkit, with and without the patch.
>>
>> SoCKit and MCVEVK.
>>
>> I tried bisecting it, it worked on 2016.07 and doesn't on 2016.09 , and
>> I arrived at this patch. Maybe you can double-check this ?
>>
> 
> Okay, I can check it on the SoCKit.

It also happens on MCVEVK, but that's probably moot for your test ;-)

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Dinh Nguyen]

On 11/01/2016 03:09 PM, Marek Vasut wrote:
> On 11/01/2016 04:43 PM, Dinh Nguyen wrote:
>>
>>
>> On 10/29/2016 02:59 PM, Marek Vasut wrote:
>>> On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
 On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
>>
>>
>> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
>>> Hi,
>>>
>>> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform 
>>> makes
>>> use of the PL330 to transfer zereos to the SDRAM which enables the ECC 
>>> bit.
>>>
>>> This is only an RFC because after rebasing to v2016.11-rc1, I had to 
>>> revert
>>> the following patch "a78cd8613204 ARM: Rework and correct barrier 
>>> definitions"
>>> in order for this patch set to work correctly. With the above patch 
>>> applied,
>>> after the SDRAM scrubbing is complete, the SPL is failing to find the 
>>> MMC
>>> device.
>>>
>>
>> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
>> barrier definitions" is causing SPL to fail after the SDRAM scrub
>> operation. It appears that before the above mentioned patch, the dmb()
>> operation is defined as this:
>>
>> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
>>
>> after the patch, the dmb is now:
>>
>> #define DMBasm volatile ("dmb sy" : : : "memory")
>>
>> So the "dmb sy" as described in the ARM documentation is a "Full system
>> DMB operation". For whatever reason, this change is causing the SPL
>> error after the SDRAM scrub operation.
>
> Thanks for looking into this, can you poke into it some more ?
>

 Of course..
>>>
>>> The patch is causing a failure even in normal operation -- if you boot
>>> the socfpga board and type "reset", it won't reset with the patch.
>>>
>>
>> Can I ask what board are you seeing this on? I'm seeing that on my Atlas
>> board, it does not reset properly(even with the patch reverted). But
>> "reset" is working fine on my devkit, with and without the patch.
> 
> SoCKit and MCVEVK.
> 
> I tried bisecting it, it worked on 2016.07 and doesn't on 2016.09 , and
> I arrived at this patch. Maybe you can double-check this ?
>

Okay, I can check it on the SoCKit.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 11/01/2016 04:43 PM, Dinh Nguyen wrote:
> 
> 
> On 10/29/2016 02:59 PM, Marek Vasut wrote:
>> On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
>>> On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
 On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
>
>
> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
>> Hi,
>>
>> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform 
>> makes
>> use of the PL330 to transfer zereos to the SDRAM which enables the ECC 
>> bit.
>>
>> This is only an RFC because after rebasing to v2016.11-rc1, I had to 
>> revert
>> the following patch "a78cd8613204 ARM: Rework and correct barrier 
>> definitions"
>> in order for this patch set to work correctly. With the above patch 
>> applied,
>> after the SDRAM scrubbing is complete, the SPL is failing to find the MMC
>> device.
>>
>
> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
> barrier definitions" is causing SPL to fail after the SDRAM scrub
> operation. It appears that before the above mentioned patch, the dmb()
> operation is defined as this:
>
> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
>
> after the patch, the dmb is now:
>
> #define DMBasm volatile ("dmb sy" : : : "memory")
>
> So the "dmb sy" as described in the ARM documentation is a "Full system
> DMB operation". For whatever reason, this change is causing the SPL
> error after the SDRAM scrub operation.

 Thanks for looking into this, can you poke into it some more ?

>>>
>>> Of course..
>>
>> The patch is causing a failure even in normal operation -- if you boot
>> the socfpga board and type "reset", it won't reset with the patch.
>>
> 
> Can I ask what board are you seeing this on? I'm seeing that on my Atlas
> board, it does not reset properly(even with the patch reverted). But
> "reset" is working fine on my devkit, with and without the patch.

SoCKit and MCVEVK.

I tried bisecting it, it worked on 2016.07 and doesn't on 2016.09 , and
I arrived at this patch. Maybe you can double-check this ?

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Dinh Nguyen]

On 10/29/2016 02:59 PM, Marek Vasut wrote:
> On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
>> On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
>>> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:


 On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
> Hi,
>
> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform 
> makes
> use of the PL330 to transfer zereos to the SDRAM which enables the ECC 
> bit.
>
> This is only an RFC because after rebasing to v2016.11-rc1, I had to 
> revert
> the following patch "a78cd8613204 ARM: Rework and correct barrier 
> definitions"
> in order for this patch set to work correctly. With the above patch 
> applied,
> after the SDRAM scrubbing is complete, the SPL is failing to find the MMC
> device.
>

 I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
 barrier definitions" is causing SPL to fail after the SDRAM scrub
 operation. It appears that before the above mentioned patch, the dmb()
 operation is defined as this:

 #define dmb()  __asm__ __volatile__ ("" : : : "memory")

 after the patch, the dmb is now:

 #define DMBasm volatile ("dmb sy" : : : "memory")

 So the "dmb sy" as described in the ARM documentation is a "Full system
 DMB operation". For whatever reason, this change is causing the SPL
 error after the SDRAM scrub operation.
>>>
>>> Thanks for looking into this, can you poke into it some more ?
>>>
>>
>> Of course..
> 
> The patch is causing a failure even in normal operation -- if you boot
> the socfpga board and type "reset", it won't reset with the patch.
> 

Can I ask what board are you seeing this on? I'm seeing that on my Atlas
board, it does not reset properly(even with the patch reverted). But
"reset" is working fine on my devkit, with and without the patch.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
> On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
>> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
>>>
>>>
>>> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
 Hi,

 This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform 
 makes
 use of the PL330 to transfer zereos to the SDRAM which enables the ECC bit.

 This is only an RFC because after rebasing to v2016.11-rc1, I had to revert
 the following patch "a78cd8613204 ARM: Rework and correct barrier 
 definitions"
 in order for this patch set to work correctly. With the above patch 
 applied,
 after the SDRAM scrubbing is complete, the SPL is failing to find the MMC
 device.

>>>
>>> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
>>> barrier definitions" is causing SPL to fail after the SDRAM scrub
>>> operation. It appears that before the above mentioned patch, the dmb()
>>> operation is defined as this:
>>>
>>> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
>>>
>>> after the patch, the dmb is now:
>>>
>>> #define DMBasm volatile ("dmb sy" : : : "memory")
>>>
>>> So the "dmb sy" as described in the ARM documentation is a "Full system
>>> DMB operation". For whatever reason, this change is causing the SPL
>>> error after the SDRAM scrub operation.
>>
>> Thanks for looking into this, can you poke into it some more ?
>>
> 
> Of course..

The patch is causing a failure even in normal operation -- if you boot
the socfpga board and type "reset", it won't reset with the patch.

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 10/18/2016 05:50 PM, Dinh Nguyen wrote:
> On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
>> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
>>>
>>>
>>> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
 Hi,

 This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform 
 makes
 use of the PL330 to transfer zereos to the SDRAM which enables the ECC bit.

 This is only an RFC because after rebasing to v2016.11-rc1, I had to revert
 the following patch "a78cd8613204 ARM: Rework and correct barrier 
 definitions"
 in order for this patch set to work correctly. With the above patch 
 applied,
 after the SDRAM scrubbing is complete, the SPL is failing to find the MMC
 device.

>>>
>>> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
>>> barrier definitions" is causing SPL to fail after the SDRAM scrub
>>> operation. It appears that before the above mentioned patch, the dmb()
>>> operation is defined as this:
>>>
>>> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
>>>
>>> after the patch, the dmb is now:
>>>
>>> #define DMBasm volatile ("dmb sy" : : : "memory")
>>>
>>> So the "dmb sy" as described in the ARM documentation is a "Full system
>>> DMB operation". For whatever reason, this change is causing the SPL
>>> error after the SDRAM scrub operation.
>>
>> Thanks for looking into this, can you poke into it some more ?
>>
> 
> Of course..

Thanks, I sense a great share of enthusiasm in that reply ;-)

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Dinh Nguyen]

On Sun, Oct 16, 2016 at 10:59 AM, Marek Vasut  wrote:
> On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
>>
>>
>> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
>>> Hi,
>>>
>>> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform 
>>> makes
>>> use of the PL330 to transfer zereos to the SDRAM which enables the ECC bit.
>>>
>>> This is only an RFC because after rebasing to v2016.11-rc1, I had to revert
>>> the following patch "a78cd8613204 ARM: Rework and correct barrier 
>>> definitions"
>>> in order for this patch set to work correctly. With the above patch applied,
>>> after the SDRAM scrubbing is complete, the SPL is failing to find the MMC
>>> device.
>>>
>>
>> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
>> barrier definitions" is causing SPL to fail after the SDRAM scrub
>> operation. It appears that before the above mentioned patch, the dmb()
>> operation is defined as this:
>>
>> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
>>
>> after the patch, the dmb is now:
>>
>> #define DMBasm volatile ("dmb sy" : : : "memory")
>>
>> So the "dmb sy" as described in the ARM documentation is a "Full system
>> DMB operation". For whatever reason, this change is causing the SPL
>> error after the SDRAM scrub operation.
>
> Thanks for looking into this, can you poke into it some more ?
>

Of course..

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 10/15/2016 12:10 AM, Dinh Nguyen wrote:
> 
> 
> On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
>> Hi,
>>
>> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform makes
>> use of the PL330 to transfer zereos to the SDRAM which enables the ECC bit.
>>
>> This is only an RFC because after rebasing to v2016.11-rc1, I had to revert
>> the following patch "a78cd8613204 ARM: Rework and correct barrier 
>> definitions"
>> in order for this patch set to work correctly. With the above patch applied,
>> after the SDRAM scrubbing is complete, the SPL is failing to find the MMC
>> device.
>>
> 
> I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
> barrier definitions" is causing SPL to fail after the SDRAM scrub
> operation. It appears that before the above mentioned patch, the dmb()
> operation is defined as this:
> 
> #define dmb()  __asm__ __volatile__ ("" : : : "memory")
> 
> after the patch, the dmb is now:
> 
> #define DMBasm volatile ("dmb sy" : : : "memory")
> 
> So the "dmb sy" as described in the ARM documentation is a "Full system
> DMB operation". For whatever reason, this change is causing the SPL
> error after the SDRAM scrub operation.

Thanks for looking into this, can you poke into it some more ?

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 10/15/2016 12:13 AM, Dinh Nguyen wrote:
> 
> 
> On 10/14/2016 10:09 AM, Marek Vasut wrote:
>> On 10/14/2016 03:08 PM, Dinh Nguyen wrote:
>>>
>>>
>>> On 10/14/2016 02:23 AM, Marek Vasut wrote:
 On 10/10/2016 05:52 PM, Dinh Nguyen wrote:
> Hi,

 Hi,

> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform 
> makes
> use of the PL330 to transfer zereos to the SDRAM which enables the ECC 
> bit.

 Is there some considerable performanCONFIG_HPS_SDR_CTRLCFG_CTRLCFG_ECCENce 
 benefit over memset() in this case ?

>>>
>>> Yes, with the DMA, it takes ~1.5 secs, with memset, it's ~15 secs.
>>
>> Understood, thanks. I hope the scrubbing can be disabled in non-ECC case ?
>>
> 
> Yes, the scrubbing is only done if CONFIG_HPS_SDR_CTRLCFG_CTRLCFG_ECCEN
> == 1.

Understood, thanks for confirming. I will check 1/4 and 4/4 shortly, I
just got back from ELCE and I'm dead tired.


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Dinh Nguyen]

On 10/14/2016 10:09 AM, Marek Vasut wrote:
> On 10/14/2016 03:08 PM, Dinh Nguyen wrote:
>>
>>
>> On 10/14/2016 02:23 AM, Marek Vasut wrote:
>>> On 10/10/2016 05:52 PM, Dinh Nguyen wrote:
 Hi,
>>>
>>> Hi,
>>>
 This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform 
 makes
 use of the PL330 to transfer zereos to the SDRAM which enables the ECC bit.
>>>
>>> Is there some considerable performanCONFIG_HPS_SDR_CTRLCFG_CTRLCFG_ECCENce 
>>> benefit over memset() in this case ?
>>>
>>
>> Yes, with the DMA, it takes ~1.5 secs, with memset, it's ~15 secs.
> 
> Understood, thanks. I hope the scrubbing can be disabled in non-ECC case ?
> 

Yes, the scrubbing is only done if CONFIG_HPS_SDR_CTRLCFG_CTRLCFG_ECCEN
== 1.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Dinh Nguyen]

On 10/10/2016 10:52 AM, Dinh Nguyen wrote:
> Hi,
> 
> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform makes
> use of the PL330 to transfer zereos to the SDRAM which enables the ECC bit.
> 
> This is only an RFC because after rebasing to v2016.11-rc1, I had to revert
> the following patch "a78cd8613204 ARM: Rework and correct barrier definitions"
> in order for this patch set to work correctly. With the above patch applied,
> after the SDRAM scrubbing is complete, the SPL is failing to find the MMC
> device.
> 

I kinda figured out why patch "a78cd8613204 ARM: Rework and correct
barrier definitions" is causing SPL to fail after the SDRAM scrub
operation. It appears that before the above mentioned patch, the dmb()
operation is defined as this:

#define dmb()  __asm__ __volatile__ ("" : : : "memory")

after the patch, the dmb is now:

#define DMBasm volatile ("dmb sy" : : : "memory")

So the "dmb sy" as described in the ARM documentation is a "Full system
DMB operation". For whatever reason, this change is causing the SPL
error after the SDRAM scrub operation.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 10/14/2016 03:08 PM, Dinh Nguyen wrote:
> 
> 
> On 10/14/2016 02:23 AM, Marek Vasut wrote:
>> On 10/10/2016 05:52 PM, Dinh Nguyen wrote:
>>> Hi,
>>
>> Hi,
>>
>>> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform 
>>> makes
>>> use of the PL330 to transfer zereos to the SDRAM which enables the ECC bit.
>>
>> Is there some considerable performance benefit over memset() in this case ?
>>
> 
> Yes, with the DMA, it takes ~1.5 secs, with memset, it's ~15 secs.

Understood, thanks. I hope the scrubbing can be disabled in non-ECC case ?

> Dinh
> 


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Dinh Nguyen]

On 10/14/2016 02:23 AM, Marek Vasut wrote:
> On 10/10/2016 05:52 PM, Dinh Nguyen wrote:
>> Hi,
> 
> Hi,
> 
>> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform makes
>> use of the PL330 to transfer zereos to the SDRAM which enables the ECC bit.
> 
> Is there some considerable performance benefit over memset() in this case ?
> 

Yes, with the DMA, it takes ~1.5 secs, with memset, it's ~15 secs.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC] 0/4] Add Pl330 DMA support

[Marek Vasut]

On 10/10/2016 05:52 PM, Dinh Nguyen wrote:
> Hi,

Hi,

> This patchset adds the PL330 DMA driver to U-Boot. The SoCFPGA platform makes
> use of the PL330 to transfer zereos to the SDRAM which enables the ECC bit.

Is there some considerable performance benefit over memset() in this case ?

> This is only an RFC because after rebasing to v2016.11-rc1, I had to revert
> the following patch "a78cd8613204 ARM: Rework and correct barrier definitions"
> in order for this patch set to work correctly. With the above patch applied,
> after the SDRAM scrubbing is complete, the SPL is failing to find the MMC
> device.
> 
> I'm continue to debug this, but would like to solicit comments with this
> patchset.
> 
> Thanks,
> Dinh
> 
> 
> Dinh Nguyen (4):
>   drivers: dma: Add the ARM PL330 DMA driver
>   dma: Kconfig: Add CONFIG_PL330_DMA entry
>   dm: add DMA_SUPPORTS_DEV_TO_MEM type to DMA_UCLASS
>   arm: socfpga: scrub the SDRAM to properly enable ECC support
> 
>  arch/arm/include/asm/pl330.h   | 105 +++
>  arch/arm/mach-socfpga/include/mach/reset_manager.h |  21 +
>  arch/arm/mach-socfpga/include/mach/sdram.h |   2 +
>  arch/arm/mach-socfpga/spl.c|   8 +
>  arch/arm/mach-socfpga/wrap_sdram_config.c  |  28 +
>  configs/socfpga_cyclone5_defconfig |   2 +
>  drivers/dma/Kconfig|   4 +
>  drivers/dma/Makefile   |   1 +
>  drivers/dma/dma-uclass.c   |   3 +-
>  drivers/dma/pl330.c| 942 
> +
>  10 files changed, 1115 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/include/asm/pl330.h
>  create mode 100644 drivers/dma/pl330.c
> 


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot