Re: [U-Boot] [RFC PATCH 17/20] cmd: mtd: add 'mtd' command

2018-07-11 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Wed, 11 Jul 2018 16:01:09 +0200: > On Wed, 11 Jul 2018 15:51:39 +0200 > Miquel Raynal wrote: > > > > > + > > > > + argc -= 3; > > > > + argv += 3; > > > > + > > > > + /* Do the parsing */ > > > > + if (!strncmp(cmd, "read", 4) ||

Re: [U-Boot] [RFC PATCH 17/20] cmd: mtd: add 'mtd' command

2018-07-11 Thread Boris Brezillon
On Wed, 11 Jul 2018 15:51:39 +0200 Miquel Raynal wrote: > > > + > > > + argc -= 3; > > > + argv += 3; > > > + > > > + /* Do the parsing */ > > > + if (!strncmp(cmd, "read", 4) || !strncmp(cmd, "write", 5)) { > > > + bool read, raw, woob; > > > + uint *waddr = NULL; > > > +

Re: [U-Boot] [RFC PATCH 17/20] cmd: mtd: add 'mtd' command

2018-07-11 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Wed, 6 Jun 2018 21:45:24 +0200: > Hi Miquel, > > On Wed, 6 Jun 2018 17:30:37 +0200 > Miquel Raynal wrote: > > > There should not be a 'nand' command, a 'sf' command and certainly not > > another 'spi-nand'. Write a 'mtd' command instead to manage all MTD >

Re: [U-Boot] [RFC PATCH 17/20] cmd: mtd: add 'mtd' command

2018-07-06 Thread Stefan Roese
Hi Miquel, On 06.07.2018 15:42, Miquel Raynal wrote: Hi Stefan, Stefan Roese wrote on Fri, 6 Jul 2018 15:21:20 +0200: Hi Miquel, On 06.07.2018 14:26, Miquel Raynal wrote: Jagan Teki wrote on Fri, 6 Jul 2018 17:08:57 +0530: On Wed, Jun 6, 2018 at 9:00 PM, Miquel Raynal wrote: There

Re: [U-Boot] [RFC PATCH 17/20] cmd: mtd: add 'mtd' command

2018-07-06 Thread Miquel Raynal
Hi Stefan, Stefan Roese wrote on Fri, 6 Jul 2018 15:21:20 +0200: > Hi Miquel, > > On 06.07.2018 14:26, Miquel Raynal wrote: > > Jagan Teki wrote on Fri, 6 Jul 2018 17:08:57 > > +0530: > > >> On Wed, Jun 6, 2018 at 9:00 PM, Miquel Raynal > > >> wrote: > >>> There should not be a 'nand'

Re: [U-Boot] [RFC PATCH 17/20] cmd: mtd: add 'mtd' command

2018-07-06 Thread Stefan Roese
Hi Miquel, On 06.07.2018 14:26, Miquel Raynal wrote: Jagan Teki wrote on Fri, 6 Jul 2018 17:08:57 +0530: On Wed, Jun 6, 2018 at 9:00 PM, Miquel Raynal wrote: There should not be a 'nand' command, a 'sf' command and certainly not another 'spi-nand'. Write a 'mtd' command instead to manage

Re: [U-Boot] [RFC PATCH 17/20] cmd: mtd: add 'mtd' command

2018-07-06 Thread Miquel Raynal
Hi Jagan, Jagan Teki wrote on Fri, 6 Jul 2018 17:08:57 +0530: > On Wed, Jun 6, 2018 at 9:00 PM, Miquel Raynal > wrote: > > There should not be a 'nand' command, a 'sf' command and certainly not > > another 'spi-nand'. Write a 'mtd' command instead to manage all MTD > > devices at once. This

Re: [U-Boot] [RFC PATCH 17/20] cmd: mtd: add 'mtd' command

2018-07-06 Thread Jagan Teki
On Wed, Jun 6, 2018 at 9:00 PM, Miquel Raynal wrote: > There should not be a 'nand' command, a 'sf' command and certainly not > another 'spi-nand'. Write a 'mtd' command instead to manage all MTD > devices at once. This should be the preferred way to access any MTD > device. So are you planning

Re: [U-Boot] [RFC PATCH 17/20] cmd: mtd: add 'mtd' command

2018-06-06 Thread Boris Brezillon
Hi Miquel, On Wed, 6 Jun 2018 17:30:37 +0200 Miquel Raynal wrote: > There should not be a 'nand' command, a 'sf' command and certainly not > another 'spi-nand'. Write a 'mtd' command instead to manage all MTD > devices at once. This should be the preferred way to access any MTD > device. Just